tree 35947c6951e5f8b683f9d5d685f84c3921447cd1
parent 9cfc80a7865ae17e71631cfe481a8d067a3dcc85
author Jiawei Shao <jiawei.shao@intel.com> 1705624956 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1705624956 +0000

Support larger maxVertexAttributes (30)

This patch adds the support of larger maxVertexAttributes (30) in Dawn.
The main reason to choose 30 as the Tier1 value of maxVertexAttributes
is that on D3D12 D3D12_IA_VERTEX_INPUT_RESOURCE_SLOT_COUNT is 32, while
both SV_VertexID and SV_InstanceID will consume one vertex input slot.
Otherwise when creating such render pipeline DXC will crash and FXC will
generate below error message:
error X4506: vs_5_1 input limit (32) exceeded, shader uses 33 inputs.

This patch also fixes a bug on the assignment of maxVertexAttributes on
the OpenGL backend. According to OpenGL ES SPEC, attribindex must be
less than the value of GL_MAX_VERTEX_ATTRIBS, so GL_MAX_VERTEX_ATTRIBS
should exactly mean maxVertexAttributes in WebGPU.

Fixed: dawn:2223
Test: dawn_end2end_tests
Change-Id: I1916b2d676296e98f74bf6d17684000ccd7a03bc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/170140
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>