commit b867e14cac14aabe1836e414640f48f7b14daef9
author Austin Eng <enga@chromium.org> Tue Mar 24 18:24:24 2020 +0000
committer Commit Bot service account <commit-bot@chromium.org> Tue Mar 24 18:24:24 2020 +0000
tree d9f2a8cd37f5b73dde9070dcce14347a6fcab294
parent 4c6c40d47dc54ffe935c89b564b23f671b220d1b

Add DAWN_NO_DISCARD to ErrorData

ErrorData should not be discarded. The error must be handled.

Bug: chromium:1063810
Change-Id: I55e782e499f307b91790db10a42878afdc7540dd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/17501
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

src/dawn_native/ErrorData.h

diff --git a/src/dawn_native/ErrorData.h b/src/dawn_native/ErrorData.h
index 52769b4..9c8ee83 100644
--- a/src/dawn_native/ErrorData.h
+++ b/src/dawn_native/ErrorData.h
@@ -15,6 +15,8 @@
 #ifndef DAWNNATIVE_ERRORDATA_H_
 #define DAWNNATIVE_ERRORDATA_H_
 
+#include "common/Compiler.h"
+
 #include <cstdint>
 #include <memory>
 #include <string>
@@ -31,13 +33,13 @@
 namespace dawn_native {
     enum class InternalErrorType : uint32_t;
 
-    class ErrorData {
+    class DAWN_NO_DISCARD ErrorData {
       public:
-        static std::unique_ptr<ErrorData> Create(InternalErrorType type,
-                                                 std::string message,
-                                                 const char* file,
-                                                 const char* function,
-                                                 int line);
+        static DAWN_NO_DISCARD std::unique_ptr<ErrorData> Create(InternalErrorType type,
+                                                                 std::string message,
+                                                                 const char* file,
+                                                                 const char* function,
+                                                                 int line);
         ErrorData(InternalErrorType type, std::string message);
 
         struct BacktraceRecord {