Google Git
Sign in
dawn / dawn / 8520f8ea8a09bb919314228c7cce8a333149e2bd
commit8520f8ea8a09bb919314228c7cce8a333149e2bd[log] [tgz]
authorStephen White <senorblanco@chromium.org>Thu Sep 28 18:27:20 2023 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Sep 28 18:27:20 2023 +0000
treee8d9f7c067e8652c2d01d93c1eb26a52bbb281c8
parent6f2ede60bf320ce42315de35eb257c289e1215f0 [diff]
GL: fix mipmap settings of wrapped EGLImage.

Dawn samples textures with a minFilter of GL_LINEAR_MIPMAP_NEAREST or
GL_LINEAR_MIPMAP_LINEAR, requiring a valid mip chain.  EGLImages
always have a single mip level, but the wrapping code was not setting
GL_TEXTURE_MAX_LEVEL, leaving at its default of 1000. This resulted in
texture incompleteness and a black frame.

Fixed by setting GL_TEXTURE_MAX_LEVEL to zero.

Tests didn't catch this, since they were using a 1x1x1 texture. Modified
the tests to use 2x1x1 instead.

Bug: chromium:1467273
Change-Id: Ibc45ab3537140d746edc71ad68730250a618eb31
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/154020
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2 files changed
tree: e8d9f7c067e8652c2d01d93c1eb26a52bbb281c8
  1. .vscode/
  2. build_overrides/
  3. docs/
  4. generator/
  5. include/
  6. infra/
  7. scripts/
  8. src/
  9. test/
  10. third_party/
  11. tools/
  12. webgpu-cts/
  13. build
  14. buildtools
  15. testing
  16. .bazelrc
  17. .clang-format
  18. .clang-tidy
  19. .gitattributes
  20. .gitignore
  21. .gitmodules
  22. .gn
  23. AUTHORS
  24. BUILD.bazel
  25. BUILD.gn
  26. CMakeLists.txt
  27. CMakeSettings.json
  28. CODE_OF_CONDUCT.md
  29. codereview.settings
  30. CONTRIBUTING.md
  31. CPPLINT.cfg
  32. dawn.json
  33. dawn_wire.json
  34. DEPS
  35. DIR_METADATA
  36. Doxyfile
  37. go.mod
  38. go.sum
  39. go_presubmit_support.py
  40. LICENSE
  41. OWNERS
  42. PRESUBMIT.py
  43. README.chromium
  44. README.md
  45. WORKSPACE.bazel
README.md

Dawn's logo: a sun rising behind a stylized mountain inspired by the WebGPU logo. The text Dawn is written below it.

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the work-in-progress WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

Status

(TODO)

License

Apache 2.0 Public License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.