)]}' { "commit": "c3de402889bfe9d7949503e6f66ac3ee18bdbc98", "tree": "2f3e294c879118f3a3ccc899734b45d65b3c6ea2", "parents": [ "1c8567bd2af2b3ac39ba6f59457244bf9894fea3" ], "author": { "name": "jacksonrl", "email": "203005141+jacksonrl@users.noreply.github.com", "time": "Mon Dec 01 08:52:39 2025 -0800" }, "committer": { "name": "Dawn LUCI CQ", "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Dec 01 08:52:39 2025 -0800" }, "message": "set ios to 14 in github action ci\n\nThis fixes the iOS ci which has been broken since https://github.com/google/dawn/actions/runs/19482018618\n\n\u003cdetails\u003e\n\n\u003csummary\u003e error \u003c/summary\u003e\n\n```\n\n/Users/runner/work/dawn/dawn/src/dawn/native/metal/CommandRecordingContext.h:63:41: warning: \u0027MTLBlitPassDescriptor\u0027 is only available on iOS 14.0 or newer [-Wunguarded-availability-new]\n 63 | id\u003cMTLBlitCommandEncoder\u003e BeginBlit(MTLBlitPassDescriptor* descriptor);\n | ^\n/Applications/Xcode_26.1.1.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS26.1.sdk/System/Library/Frameworks/Metal.framework/Headers/MTLBlitPass.h:65:12: note: \u0027MTLBlitPassDescriptor\u0027 has been marked as being introduced in iOS 14.0 here, but the deployment target is iOS 13.0.0\n 65 | @interface MTLBlitPassDescriptor : NSObject \u003cNSCopying\u003e\n | ^\n/Users/runner/work/dawn/dawn/src/dawn/native/metal/CommandRecordingContext.h:63:31: note: annotate \u0027BeginBlit\u0027 with an availability attribute to silence this warning\n 63 | id\u003cMTLBlitCommandEncoder\u003e BeginBlit(MTLBlitPassDescriptor* descriptor);\n | ^\n/Users/runner/work/dawn/dawn/src/dawn/native/metal/CommandRecordingContext.h:71:47: warning: \u0027MTLComputePassDescriptor\u0027 is only available on iOS 14.0 or newer [-Wunguarded-availability-new]\n 71 | id\u003cMTLComputeCommandEncoder\u003e BeginCompute(MTLComputePassDescriptor* descriptor);\n | ^\n/Applications/Xcode_26.1.1.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS26.1.sdk/System/Library/Frameworks/Metal.framework/Headers/MTLComputePass.h:67:12: note: \u0027MTLComputePassDescriptor\u0027 has been marked as being introduced in iOS 14.0 here, but the deployment target is iOS 13.0.0\n 67 | @interface MTLComputePassDescriptor : NSObject \u003cNSCopying\u003e\n | ^\n/Users/runner/work/dawn/dawn/src/dawn/native/metal/CommandRecordingContext.h:71:34: note: annotate \u0027BeginCompute\u0027 with an availability attribute to silence this warning\n 71 | id\u003cMTLComputeCommandEncoder\u003e BeginCompute(MTLComputePassDescriptor* descriptor);\n |\n\n\t ...\n\n\t /Users/runner/work/dawn/dawn/src/dawn/native/Buffer.cpp:317:24: error: \u0027notify_all\u0027 is unavailable: introduced in iOS 14.0\n 317 | buffer-\u003emState.notify_all();\n | ^\n/Applications/Xcode_26.1_Release_Candidate.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS26.1.sdk/usr/include/c++/v1/__atomic/atomic.h:128:56: note: \u0027notify_all\u0027 has been explicitly marked unavailable here\n 128 | _LIBCPP_AVAILABILITY_SYNC _LIBCPP_HIDE_FROM_ABI void notify_all() _NOEXCEPT { std::__atomic_notify_all(*this); }\n | ^\n/Users/runner/work/dawn/dawn/src/dawn/native/Buffer.cpp:853:16: error: \u0027wait\u0027 is unavailable: introduced in iOS 14.0\n 853 | mState.wait(BufferState::PendingMap, std::memory_order_acquire);\n | ^\n/Applications/Xcode_26.1_Release_Candidate.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS26.1.sdk/usr/include/c++/v1/__atomic/atomic.h:118:3: note: \u0027wait\u0027 has been explicitly marked unavailable here\n 118 | wait(_Tp __v, memory_order __m \u003d memory_order_seq_cst) const _NOEXCEPT {\n | ^\n\n```\n\n\u003c/details\u003e\n\nUbuntu debug and MacOS x86 debug are also failing sometimes, and aren\u0027t fixed here:\n\nubuntu:\n\n`System.IO.IOException: No space left on device : \u0027/home/runner/actions-runner/cached/_diag/Worker_20251128-093455-utc.log\u0027`\n\nmacos x86 debug:\n\n\u003cdetails\u003e\n\nCMake Error at third_party/CMakeLists.txt:131 (add_subdirectory):\n The source directory\n\n /Users/runner/work/dawn/dawn/third_party/spirv-headers/src\n\n does not contain a CMakeLists.txt file.\n\nCMake Error at third_party/CMakeLists.txt:156 (add_subdirectory):\n The source directory\n\n /Users/runner/work/dawn/dawn/third_party/glslang/src\n\n does not contain a CMakeLists.txt file.\n\nCMake Error at src/tint/CMakeLists.txt:52 (message):\n Building IR binary format \u0027TINT_BUILD_IR_BINARY\u0027 is enabled, but protobuf\n target is not available, possibly missing\n \u0027/Users/runner/work/dawn/dawn/third_party/protobuf\u0027\n\n\u003c/details\u003e\n\nI have not actually tested this because the GitHub free tier seems to limit iOS runners or I ran too many actions today. The test should run on this PR though so we can see if this fixes it.\n\nThis is an imported pull request from\nhttps://github.com/google/dawn/pull/51\n\nGITHUB_PR_HEAD_SHA\u003d2b02a212c5347cf5ff90f4bee018308811cf6024\nORIGINAL_AUTHOR\u003djacksonrl \u003c203005141+jacksonrl@users.noreply.github.com\u003e\nGitOrigin-RevId: 953196415a330b99bd4c96d1aa66e2854af319fc\nChange-Id: Id332521f03ac7258f2bc62398220e4039ab64232\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/277355\nCommit-Queue: dan sinclair \u003cdsinclair@chromium.org\u003e\nReviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\nReviewed-by: dan sinclair \u003cdsinclair@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "265fe1336efa6b30f4d3136540a02b3d9ca061bb", "old_mode": 33188, "old_path": ".github/workflows/ci.yml", "new_id": "8db748d9722bcb69b34a05970c0dc7fdf06b1f66", "new_mode": 33188, "new_path": ".github/workflows/ci.yml" } ] }