)]}'
{
  "commit": "c451f620e51376e4d7652f5a0d08ca562932da7a",
  "tree": "addbfcc549a6c77a1498cafd650448f6003be3f4",
  "parents": [
    "70b36f0ff8ef21170d8d6c1abe8e48bc7a890ddb"
  ],
  "author": {
    "name": "James Price",
    "email": "jrprice@google.com",
    "time": "Mon May 27 17:28:21 2024 +0000"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Mon May 27 17:28:21 2024 +0000"
  },
  "message": "[msl] Support workgroup vars in ModuleScopeVars\n\nWorkgroup variables will be allocated by Dawn and passed as entry\npoint parameters (to workaround an MSL compiler bug with threadgroup\nmatrices), and we aggregate all of them into a single structure to\navoid hitting MSL\u0027s limit for threadgroup memory arguments.\n\nBug: 42251016\nChange-Id: I5b4b793b2cebdccc8f88b130434610e3477f3b00\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/189801\nReviewed-by: dan sinclair \u003cdsinclair@chromium.org\u003e\nCommit-Queue: James Price \u003cjrprice@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "b91c2bdb7409a4f95a19e44ee6858f2c9932c516",
      "old_mode": 33188,
      "old_path": "src/tint/lang/msl/writer/printer/var_test.cc",
      "new_id": "4b3c2f92f3a8679a94e3296f3f6d87c94bfe9a83",
      "new_mode": 33188,
      "new_path": "src/tint/lang/msl/writer/printer/var_test.cc"
    },
    {
      "type": "modify",
      "old_id": "00a569fbdbb6235599ab0fb9552fa234af0bad37",
      "old_mode": 33188,
      "old_path": "src/tint/lang/msl/writer/raise/module_scope_vars.cc",
      "new_id": "6a4ecb2b5c3638de56d7bec625563d3fd9bcd977",
      "new_mode": 33188,
      "new_path": "src/tint/lang/msl/writer/raise/module_scope_vars.cc"
    },
    {
      "type": "modify",
      "old_id": "3bef228096b8b10fd953037b93d2319a3420d59f",
      "old_mode": 33188,
      "old_path": "src/tint/lang/msl/writer/raise/module_scope_vars_test.cc",
      "new_id": "cf3fe76ead090c5d987be4b378aa6ef296466ac0",
      "new_mode": 33188,
      "new_path": "src/tint/lang/msl/writer/raise/module_scope_vars_test.cc"
    },
    {
      "type": "modify",
      "old_id": "37f0e9b138a2b75175d31be610b42ad9a16b2a4f",
      "old_mode": 33188,
      "old_path": "test/tint/buffer/uniform/std140/unnested/mat2x2_f16/to_workgroup.wgsl.expected.ir.msl",
      "new_id": "db158da7c868560f7aa839c152a994be943abecd",
      "new_mode": 33188,
      "new_path": "test/tint/buffer/uniform/std140/unnested/mat2x2_f16/to_workgroup.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "363c97149cc826fb9b41f4ed8d4aa48cb64a9585",
      "old_mode": 33188,
      "old_path": "test/tint/buffer/uniform/std140/unnested/mat2x2_f32/to_workgroup.wgsl.expected.ir.msl",
      "new_id": "938d418abf99b1ecd7eedd32c8844f151830f05e",
      "new_mode": 33188,
      "new_path": "test/tint/buffer/uniform/std140/unnested/mat2x2_f32/to_workgroup.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "2a286d383ef927bdc07b6c5910409e9dcda46fef",
      "old_mode": 33188,
      "old_path": "test/tint/buffer/uniform/std140/unnested/mat2x3_f16/to_workgroup.wgsl.expected.ir.msl",
      "new_id": "f0e615f4b96a082388404ed3865e159df6cd5968",
      "new_mode": 33188,
      "new_path": "test/tint/buffer/uniform/std140/unnested/mat2x3_f16/to_workgroup.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "93c51a441b85b138a64e248d8aa293dc672c3a7d",
      "old_mode": 33188,
      "old_path": "test/tint/buffer/uniform/std140/unnested/mat2x3_f32/to_workgroup.wgsl.expected.ir.msl",
      "new_id": "bb2ee0c176da6aa922bc3e52f13c4b7922698bae",
      "new_mode": 33188,
      "new_path": "test/tint/buffer/uniform/std140/unnested/mat2x3_f32/to_workgroup.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "9a8c6ea3c3c339b132c03848c343da680028ea32",
      "old_mode": 33188,
      "old_path": "test/tint/buffer/uniform/std140/unnested/mat2x4_f16/to_workgroup.wgsl.expected.ir.msl",
      "new_id": "85389c0d7483e43eaebb1dac282866acdbf00b22",
      "new_mode": 33188,
      "new_path": "test/tint/buffer/uniform/std140/unnested/mat2x4_f16/to_workgroup.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "0a303a59c8a14550bcdf0dab281ecd1decfa2ea8",
      "old_mode": 33188,
      "old_path": "test/tint/buffer/uniform/std140/unnested/mat2x4_f32/to_workgroup.wgsl.expected.ir.msl",
      "new_id": "52da3cb54fb12a52c5d163897ea89fbd756f9820",
      "new_mode": 33188,
      "new_path": "test/tint/buffer/uniform/std140/unnested/mat2x4_f32/to_workgroup.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "d5fae9d55f6b4db2f112d29c1827c94bbbdb28c2",
      "old_mode": 33188,
      "old_path": "test/tint/buffer/uniform/std140/unnested/mat3x2_f16/to_workgroup.wgsl.expected.ir.msl",
      "new_id": "5893867a3754f6841b724091801299bf9cf5285d",
      "new_mode": 33188,
      "new_path": "test/tint/buffer/uniform/std140/unnested/mat3x2_f16/to_workgroup.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "45c60a8f9cbe1c0f4418fdb877580e171a59a6fb",
      "old_mode": 33188,
      "old_path": "test/tint/buffer/uniform/std140/unnested/mat3x2_f32/to_workgroup.wgsl.expected.ir.msl",
      "new_id": "da3e2fdaec3565517c4e44027aaa71e9a553c6d9",
      "new_mode": 33188,
      "new_path": "test/tint/buffer/uniform/std140/unnested/mat3x2_f32/to_workgroup.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "aef9a3228de61ee020696f30852141853980c854",
      "old_mode": 33188,
      "old_path": "test/tint/buffer/uniform/std140/unnested/mat3x3_f16/to_workgroup.wgsl.expected.ir.msl",
      "new_id": "3276f46a35cafacc9554619f97a817f29a9c8738",
      "new_mode": 33188,
      "new_path": "test/tint/buffer/uniform/std140/unnested/mat3x3_f16/to_workgroup.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "db86b8c2024b8aaf1c2e978e7a1cd83771e63a92",
      "old_mode": 33188,
      "old_path": "test/tint/buffer/uniform/std140/unnested/mat3x3_f32/to_workgroup.wgsl.expected.ir.msl",
      "new_id": "105e86d7810220dc1d2e78c8271cd2f766937e64",
      "new_mode": 33188,
      "new_path": "test/tint/buffer/uniform/std140/unnested/mat3x3_f32/to_workgroup.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "6f095014065b9cd3f521248574c1f227732debee",
      "old_mode": 33188,
      "old_path": "test/tint/buffer/uniform/std140/unnested/mat3x4_f16/to_workgroup.wgsl.expected.ir.msl",
      "new_id": "fce2da865865e9c07c48c8ff0cefeaf76a0d30b0",
      "new_mode": 33188,
      "new_path": "test/tint/buffer/uniform/std140/unnested/mat3x4_f16/to_workgroup.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "675d4d35cc880b6e6200aa01497676f9671e9f70",
      "old_mode": 33188,
      "old_path": "test/tint/buffer/uniform/std140/unnested/mat3x4_f32/to_workgroup.wgsl.expected.ir.msl",
      "new_id": "bc3018c059ae8725d548f013d0e01cc1936bc6d6",
      "new_mode": 33188,
      "new_path": "test/tint/buffer/uniform/std140/unnested/mat3x4_f32/to_workgroup.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "ced9ab1c52d20d920c8ed9270b2ca5b3c67afda6",
      "old_mode": 33188,
      "old_path": "test/tint/buffer/uniform/std140/unnested/mat4x2_f16/to_workgroup.wgsl.expected.ir.msl",
      "new_id": "2a21f89c177d89e7cd936f9710183b6786638d5b",
      "new_mode": 33188,
      "new_path": "test/tint/buffer/uniform/std140/unnested/mat4x2_f16/to_workgroup.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "ff6fa4766effd193d04fe6e00ff5cdb9c84d5b12",
      "old_mode": 33188,
      "old_path": "test/tint/buffer/uniform/std140/unnested/mat4x2_f32/to_workgroup.wgsl.expected.ir.msl",
      "new_id": "5ffe4bd6b89302195174c6fc4f38a906be26f74e",
      "new_mode": 33188,
      "new_path": "test/tint/buffer/uniform/std140/unnested/mat4x2_f32/to_workgroup.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "4ec861509a450277a9512fc874e11976f579df25",
      "old_mode": 33188,
      "old_path": "test/tint/buffer/uniform/std140/unnested/mat4x3_f16/to_workgroup.wgsl.expected.ir.msl",
      "new_id": "2a836c1467a9406e0f98953a2e9ea5db1486759d",
      "new_mode": 33188,
      "new_path": "test/tint/buffer/uniform/std140/unnested/mat4x3_f16/to_workgroup.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "ded9db0ce49f57a2325fadee1e170e4b42a6b823",
      "old_mode": 33188,
      "old_path": "test/tint/buffer/uniform/std140/unnested/mat4x3_f32/to_workgroup.wgsl.expected.ir.msl",
      "new_id": "1d930a40dd22e6d5eaae0ab69e7521a7002c8e65",
      "new_mode": 33188,
      "new_path": "test/tint/buffer/uniform/std140/unnested/mat4x3_f32/to_workgroup.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "68cc6fdc10f379eec134afb0119998af266db2cf",
      "old_mode": 33188,
      "old_path": "test/tint/buffer/uniform/std140/unnested/mat4x4_f16/to_workgroup.wgsl.expected.ir.msl",
      "new_id": "67b0ff77650e759a090938b00498711f390b359a",
      "new_mode": 33188,
      "new_path": "test/tint/buffer/uniform/std140/unnested/mat4x4_f16/to_workgroup.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "9818ee481edbb177daf79e7e2961d4b3f65ae191",
      "old_mode": 33188,
      "old_path": "test/tint/buffer/uniform/std140/unnested/mat4x4_f32/to_workgroup.wgsl.expected.ir.msl",
      "new_id": "1143198b7edfa6a11ae5d899cc85e0a455da7f97",
      "new_mode": 33188,
      "new_path": "test/tint/buffer/uniform/std140/unnested/mat4x4_f32/to_workgroup.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "fbd61a056b81e17c15f9e27537594a63ce5bd8d0",
      "old_mode": 33188,
      "old_path": "test/tint/bug/chromium/40943165.wgsl.expected.ir.msl",
      "new_id": "a7b592904a8b7b2cac24721b89fd52713ed6640d",
      "new_mode": 33188,
      "new_path": "test/tint/bug/chromium/40943165.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "c450d39b179b92cee31c3040043f378b97030112",
      "old_mode": 33188,
      "old_path": "test/tint/bug/tint/1926.wgsl.expected.ir.msl",
      "new_id": "812684cde5cd23c121bc0855ba08f9c70b0f19a5",
      "new_mode": 33188,
      "new_path": "test/tint/bug/tint/1926.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "5a6429dfe01d3451acb2091cf6a5b8f3f0d092dc",
      "old_mode": 33188,
      "old_path": "test/tint/ptr_ref/load/local/ptr_workgroup.wgsl.expected.ir.msl",
      "new_id": "5f96aa4712b4a02bfdba790a226e954a18547a70",
      "new_mode": 33188,
      "new_path": "test/tint/ptr_ref/load/local/ptr_workgroup.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "25d79e7098fe590fa2653df338f34f241d683765",
      "old_mode": 33188,
      "old_path": "test/tint/ptr_ref/load/param/workgroup/i32.wgsl.expected.ir.msl",
      "new_id": "fbd0e7df677bde1bf9464387b19ffe9e13f8731d",
      "new_mode": 33188,
      "new_path": "test/tint/ptr_ref/load/param/workgroup/i32.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "4be387c702c9dbdf7bc62e563dc4a0a7a27efacf",
      "old_mode": 33188,
      "old_path": "test/tint/ptr_ref/load/param/workgroup/i32_in_struct.wgsl.expected.ir.msl",
      "new_id": "0e25c93946fb31c11d5b5aee454fde5ee7b1b68c",
      "new_mode": 33188,
      "new_path": "test/tint/ptr_ref/load/param/workgroup/i32_in_struct.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "6866579cb94308e4b406a088618a6383781d1bf4",
      "old_mode": 33188,
      "old_path": "test/tint/ptr_ref/load/param/workgroup/vec2_f32_in_mat2x2.wgsl.expected.ir.msl",
      "new_id": "9e76b8baf205cc707eb551959c97bc0d2636a883",
      "new_mode": 33188,
      "new_path": "test/tint/ptr_ref/load/param/workgroup/vec2_f32_in_mat2x2.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "1e11dc4995cb724775183d0d83767d0e883278ca",
      "old_mode": 33188,
      "old_path": "test/tint/ptr_ref/load/param/workgroup/vec4_f32.wgsl.expected.ir.msl",
      "new_id": "3764937100779bd6a9aa6e481b9f54cb8eafd597",
      "new_mode": 33188,
      "new_path": "test/tint/ptr_ref/load/param/workgroup/vec4_f32.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "a6f5b853e0c2bd604358d7def541708b5f80d749",
      "old_mode": 33188,
      "old_path": "test/tint/ptr_ref/load/param/workgroup/vec4_f32_in_mat2x4.wgsl.expected.ir.msl",
      "new_id": "fb1ab2d3ef1cc58d993b0964e3eb8e24b770fbd9",
      "new_mode": 33188,
      "new_path": "test/tint/ptr_ref/load/param/workgroup/vec4_f32_in_mat2x4.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "62142f981e1fd7909354cbc7380832cb54aac31f",
      "old_mode": 33188,
      "old_path": "test/tint/ptr_ref/load/param/workgroup/vec4_f32_in_struct.wgsl.expected.ir.msl",
      "new_id": "96d683fbdc1ab37a7eda8b12d200ffbf0e31d82b",
      "new_mode": 33188,
      "new_path": "test/tint/ptr_ref/load/param/workgroup/vec4_f32_in_struct.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "b5cca68bacaf6e8ef618059bf2c8a08c38ae68b4",
      "old_mode": 33188,
      "old_path": "test/tint/ptr_ref/store/param/workgroup/i32.wgsl.expected.ir.msl",
      "new_id": "57dbb78525cca094d97827873f6b2b50337756fd",
      "new_mode": 33188,
      "new_path": "test/tint/ptr_ref/store/param/workgroup/i32.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "cc3cff5b2522e31ca97071f65b2a484e54c13fd4",
      "old_mode": 33188,
      "old_path": "test/tint/ptr_ref/store/param/workgroup/i32_in_struct.wgsl.expected.ir.msl",
      "new_id": "1defcd2f13e1d8b1f9e3b71dc3ccc3148f605876",
      "new_mode": 33188,
      "new_path": "test/tint/ptr_ref/store/param/workgroup/i32_in_struct.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "ef57e5ae86055556fb496648965e9a08f31554e6",
      "old_mode": 33188,
      "old_path": "test/tint/ptr_ref/store/param/workgroup/vec2_f32_in_mat2x2.wgsl.expected.ir.msl",
      "new_id": "f089435d007c19f9dfd9d10db24639600ae48220",
      "new_mode": 33188,
      "new_path": "test/tint/ptr_ref/store/param/workgroup/vec2_f32_in_mat2x2.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "2de34c8ee8361b89880789d9998b22c2fbdec53a",
      "old_mode": 33188,
      "old_path": "test/tint/ptr_ref/store/param/workgroup/vec4_f32.wgsl.expected.ir.msl",
      "new_id": "416f51bfdc5490e323efe5737400de262ef795ad",
      "new_mode": 33188,
      "new_path": "test/tint/ptr_ref/store/param/workgroup/vec4_f32.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "0f5c1ccd689a7b2f55c2cf59540c79231970b142",
      "old_mode": 33188,
      "old_path": "test/tint/ptr_ref/store/param/workgroup/vec4_f32_in_mat2x4.wgsl.expected.ir.msl",
      "new_id": "c4d63429ecf1589422d250acd261d9656a958df0",
      "new_mode": 33188,
      "new_path": "test/tint/ptr_ref/store/param/workgroup/vec4_f32_in_mat2x4.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "901779979d89d54e21945f057726fa77ec2c763b",
      "old_mode": 33188,
      "old_path": "test/tint/ptr_ref/store/param/workgroup/vec4_f32_in_struct.wgsl.expected.ir.msl",
      "new_id": "e943602955a2938160812d99a97001b114646989",
      "new_mode": 33188,
      "new_path": "test/tint/ptr_ref/store/param/workgroup/vec4_f32_in_struct.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "85e02617e98ed554a13af01401864da6181d71bd",
      "old_mode": 33188,
      "old_path": "test/tint/types/module_scope_used_in_functions.wgsl.expected.ir.msl",
      "new_id": "2b6c64905fc43822a1cff121ba9750621909064b",
      "new_mode": 33188,
      "new_path": "test/tint/types/module_scope_used_in_functions.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "e3cf1cdaec02d0a4b455a889795e87827ac2e01c",
      "old_mode": 33188,
      "old_path": "test/tint/types/module_scope_var.wgsl.expected.ir.msl",
      "new_id": "b44443a030d1e3c224007935f58e97229c536161",
      "new_mode": 33188,
      "new_path": "test/tint/types/module_scope_var.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "68d08208da5b521ca7870be77d121ddad61863f5",
      "old_mode": 33188,
      "old_path": "test/tint/types/module_scope_vars_pointers.wgsl.expected.ir.msl",
      "new_id": "bc857e6808b8827dd02e7a3608c5f6ab26fbf8ec",
      "new_mode": 33188,
      "new_path": "test/tint/types/module_scope_vars_pointers.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "a1c80e0b5c71a18b425ca5093b57ebc665113e78",
      "old_mode": 33188,
      "old_path": "test/tint/var/initialization/workgroup/matrix.wgsl.expected.ir.msl",
      "new_id": "44e6f0a437eb77f5b006aafa2633acda1a04471a",
      "new_mode": 33188,
      "new_path": "test/tint/var/initialization/workgroup/matrix.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "e1f46e9e2ff6b1efe79e348913dec6bbf1f5af3d",
      "old_mode": 33188,
      "old_path": "test/tint/var/initialization/workgroup/scalar.wgsl.expected.ir.msl",
      "new_id": "97b64c868bef6fb5fd03bddda2ab336a053d6334",
      "new_mode": 33188,
      "new_path": "test/tint/var/initialization/workgroup/scalar.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "6655af977e44ff521e63e6fd48e61a4de0472e62",
      "old_mode": 33188,
      "old_path": "test/tint/var/initialization/workgroup/struct.wgsl.expected.ir.msl",
      "new_id": "e974d4322ad4eed908dde6d3bfc263b3cf27d7bc",
      "new_mode": 33188,
      "new_path": "test/tint/var/initialization/workgroup/struct.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "a8308b374fa0e60884720462c91db8d874d3f5b9",
      "old_mode": 33188,
      "old_path": "test/tint/var/initialization/workgroup/vector.wgsl.expected.ir.msl",
      "new_id": "d24feebbfaf5dea8bcfc320a89ecaf7a39272cb0",
      "new_mode": 33188,
      "new_path": "test/tint/var/initialization/workgroup/vector.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "81f00ccb6dbc1c08d9d9ef4c464aed4c9b0164ec",
      "old_mode": 33188,
      "old_path": "test/tint/var/uses/many_workgroup_vars.wgsl.expected.ir.msl",
      "new_id": "0a83ab796f394f7464475e2ed291105ffe7e912e",
      "new_mode": 33188,
      "new_path": "test/tint/var/uses/many_workgroup_vars.wgsl.expected.ir.msl"
    }
  ]
}