)]}' { "commit": "cf1fdf413cba44667db8206466b265510b05f47a", "tree": "dd80359920778d52139a2e914838da06a45da7cb", "parents": [ "c3c2c9b6b09c5f7cdd6cebe77e29dbc2e16eaa4a" ], "author": { "name": "Austin Eng", "email": "enga@chromium.org", "time": "Mon Jun 15 23:42:13 2020 +0000" }, "committer": { "name": "Commit Bot service account", "email": "commit-bot@chromium.org", "time": "Mon Jun 15 23:42:13 2020 +0000" }, "message": "Handle OOM buffer allocations better\n\nThis CL checks buffer sizes before creating map read/write handles.\nIt is an error to map a buffer that can\u0027t be addressed on the CPU.\n\nIt also changes client-side synchronous errors on mapAsync to be\nnormal map failures, and not device lost errors. These should be\nrecoverable.\n\nThe CL adds additional testing for really large, but not UINT64_MAX\nbuffers, and fixes a VVL warning when buffer allocations exceed the\nsize of their memory heap.\n\nBug: dawn:450, dawn:398, chromium:1014740\nChange-Id: Ieb34c04c3d01c429b7e3b7810729d5e91ecb6270\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/22626\nCommit-Queue: Austin Eng \u003cenga@chromium.org\u003e\nReviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "aa2670001da96b0c45eabfc1f49f65b571d05e36", "old_mode": 33188, "old_path": "dawn.json", "new_id": "168691734e00f49b659d305a6d0f3d4d1c511ba6", "new_mode": 33188, "new_path": "dawn.json" }, { "type": "modify", "old_id": "4df366a7147f43ec59a6ab50130c8a689215c14c", "old_mode": 33188, "old_path": "src/dawn_native/Buffer.cpp", "new_id": "3c97655fbaa685317f424beb7b655d2218063d71", "new_mode": 33188, "new_path": "src/dawn_native/Buffer.cpp" }, { "type": "modify", "old_id": "b05e3410565ab808221a61460f5d94378e6cfca6", "old_mode": 33188, "old_path": "src/dawn_native/Buffer.h", "new_id": "8a1feb755efbe522f014c05d6d0e85c165d29e0c", "new_mode": 33188, "new_path": "src/dawn_native/Buffer.h" }, { "type": "modify", "old_id": "697b741324da385350b62d0294eba6b7f514eaf9", "old_mode": 33188, "old_path": "src/dawn_native/Device.cpp", "new_id": "7a0d04eea2cff2f78fb901f2f7e0390181b343ac", "new_mode": 33188, "new_path": "src/dawn_native/Device.cpp" }, { "type": "modify", "old_id": "b94f7628df6c61ac2dd24a0d356b3c832fd59210", "old_mode": 33188, "old_path": "src/dawn_native/Device.h", "new_id": "94d916f7c2b2b71499b0a905d4b2176d5159785e", "new_mode": 33188, "new_path": "src/dawn_native/Device.h" }, { "type": "modify", "old_id": "1b01a07e2ea9d7e4a4ae2eb5f76d8261ea056c16", "old_mode": 33188, "old_path": "src/dawn_native/d3d12/ResourceAllocatorManagerD3D12.cpp", "new_id": "4e48f2edafc627b7237a419833fbf9271bcb9236", "new_mode": 33188, "new_path": "src/dawn_native/d3d12/ResourceAllocatorManagerD3D12.cpp" }, { "type": "modify", "old_id": "cd35b4cf21cc5c95eedb59c5aa37d53334ca6a29", "old_mode": 33188, "old_path": "src/dawn_native/vulkan/BufferVk.cpp", "new_id": "0b9385e9393283868cea834c13ea42b9a7204b37", "new_mode": 33188, "new_path": "src/dawn_native/vulkan/BufferVk.cpp" }, { "type": "modify", "old_id": "cff743498505b839fd158a031658e05967768a1c", "old_mode": 33188, "old_path": "src/dawn_native/vulkan/ResourceMemoryAllocatorVk.cpp", "new_id": "22523a368749b445d41538967dc79dceb25d8ba1", "new_mode": 33188, "new_path": "src/dawn_native/vulkan/ResourceMemoryAllocatorVk.cpp" }, { "type": "modify", "old_id": "6106901cf2dd8d20dd56f12b97e7f71e22120910", "old_mode": 33188, "old_path": "src/dawn_wire/client/ApiProcs.cpp", "new_id": "64f6f56061501ad9a9b33eb864e50c8204c06990", "new_mode": 33188, "new_path": "src/dawn_wire/client/ApiProcs.cpp" }, { "type": "modify", "old_id": "bfd66344609954d017fcd991f7b38e5653dbd430", "old_mode": 33188, "old_path": "src/dawn_wire/client/ClientInlineMemoryTransferService.cpp", "new_id": "e7737107274a9979f37187a416a0ec95f2b6407a", "new_mode": 33188, "new_path": "src/dawn_wire/client/ClientInlineMemoryTransferService.cpp" }, { "type": "modify", "old_id": "ceaf27cff846751f12fd62edb030e2c9c7898351", "old_mode": 33188, "old_path": "src/tests/end2end/BufferTests.cpp", "new_id": "e854c44d10db16551e98e5b15f58018289ec17fe", "new_mode": 33188, "new_path": "src/tests/end2end/BufferTests.cpp" }, { "type": "modify", "old_id": "1d7d8286867b36fb8aef40e0af4fa6c5f7b4d537", "old_mode": 33188, "old_path": "src/tests/unittests/wire/WireMemoryTransferServiceTests.cpp", "new_id": "bb1efb6b105a09bc128e8a1999849ac248a37935", "new_mode": 33188, "new_path": "src/tests/unittests/wire/WireMemoryTransferServiceTests.cpp" } ] }