)]}' { "commit": "d1c4e8a03656aa0beb066976d48477a3b82c93f4", "tree": "f319873032d02e6b5391bbd2225f09173798d4a6", "parents": [ "3f9cb96f1f332e9c76a7bb512a97d8d14fd6c5f3" ], "author": { "name": "Kai Ninomiya", "email": "kainino@chromium.org", "time": "Wed Aug 19 15:20:42 2026 -0700" }, "committer": { "name": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com", "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Aug 19 15:20:42 2026 -0700" }, "message": "[dawn] Fix inconsistent parameter names in .h vs .cpp\n\nFix instances of the readability-inconsistent-declaration-parameter-name\ncheck in Dawn (but not in Tint and not in implementations of webgpu.h\nfor now). Unfortunately it doesn\u0027t usually generate a fixit, so these\nare done by hand. Note also there\u0027s a Strict option, but we don\u0027t use it\nbecause the default is much quieter and good enough (\"One name is also\nallowed to be a case-insensitive prefix/suffix of the other.\").\n\nFixes a number of parameter order/name errors (but audited usages, and\nfortunately didn\u0027t find any actual bugs). These are quite bad. In some\ncases this should be caught by bugprone-easily-swappable-parameters,\nwhich I also upgraded to P1, however we\u0027ll have to see how to use it:\n- It fails to trigger on at least one of the instances here. I\u0027ve added\n an item to bug 501491694 to track this.\n- It doesn\u0027t have an option to suppress the warning using argument name\n comments, which can be checked by bugprone-argument-comment.\n\nThis is pre-work for fixing the (related) bugprone-argument-comment.\n\nBug: 548071770, 501491694\nChange-Id: I903bd0a3dca75dd3ec525ca560757f7bc399164c\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/333655\nReviewed-by: Shrek Shao \u003cshrekshao@google.com\u003e\nCommit-Queue: Kai Ninomiya \u003ckainino@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "669768ad95f4fbac7617fe87d52e5f2905b57748", "old_mode": 33188, "old_path": ".clang-tidy", "new_id": "78e071eac427f7a69af02ba236efaea88a1448cf", "new_mode": 33188, "new_path": ".clang-tidy" }, { "type": "modify", "old_id": "5b4f18778f21be36e5f600074675b9c04b6ed5aa", "old_mode": 33188, "old_path": "src/dawn/native/CommandEncoder.h", "new_id": "bc4cec0184944c169a156fbd9430de0ca02151db", "new_mode": 33188, "new_path": "src/dawn/native/CommandEncoder.h" }, { "type": "modify", "old_id": "5859bf51c671f8b88f2a0eaf116961149ce44e2d", "old_mode": 33188, "old_path": "src/dawn/native/CommandValidation.h", "new_id": "205e8d7473c21aea226c4d401ef37ffea8bd3d6e", "new_mode": 33188, "new_path": "src/dawn/native/CommandValidation.h" }, { "type": "modify", "old_id": "854c0aa0130831cfedb1c579e18694ded085584d", "old_mode": 33188, "old_path": "src/dawn/native/Device.h", "new_id": "f9afdba2b0e85b8f083d4978b5890a7086a58320", "new_mode": 33188, "new_path": "src/dawn/native/Device.h" }, { "type": "modify", "old_id": "ce74239dff6d9e16449c27f28fd1a3e843158b69", "old_mode": 33188, "old_path": "src/dawn/native/Instance.h", "new_id": "5a2f4a9abe046b7b0200cc0557530cf294fdf95d", "new_mode": 33188, "new_path": "src/dawn/native/Instance.h" }, { "type": "modify", "old_id": "9df10cc87178e06baa094b8eb38f42d0b8e71237", "old_mode": 33188, "old_path": "src/dawn/native/PassResourceUsageTracker.h", "new_id": "b073f5580bc61c8f4ae852c99f8920a7e103bc07", "new_mode": 33188, "new_path": "src/dawn/native/PassResourceUsageTracker.h" }, { "type": "modify", "old_id": "edba52d267e4c487ca935eefb2decfa955f109a2", "old_mode": 33188, "old_path": "src/dawn/native/ProgrammableEncoder.h", "new_id": "dae4c5a1445e6857302495d328f3ccdfc7740067", "new_mode": 33188, "new_path": "src/dawn/native/ProgrammableEncoder.h" }, { "type": "modify", "old_id": "f1030bd9d188d4ddd3ee299b9b29366031ab8df9", "old_mode": 33188, "old_path": "src/dawn/native/RenderEncoderBase.h", "new_id": "4b1fcad08528b042f27019521bdc7cf2ee1bd741", "new_mode": 33188, "new_path": "src/dawn/native/RenderEncoderBase.h" }, { "type": "modify", "old_id": "d559efc058409b7c0383894f0d44b66e82507830", "old_mode": 33188, "old_path": "src/dawn/native/ShaderModule.h", "new_id": "b15fd9dbe60e2d03741b8fa067578bdae7372b39", "new_mode": 33188, "new_path": "src/dawn/native/ShaderModule.h" }, { "type": "modify", "old_id": "3fe6c4377a96e32d0bb541223b331c1eaeaf94d0", "old_mode": 33188, "old_path": "src/dawn/native/d3d/QueueD3D.h", "new_id": "833ac220eb5d99422f1687383b55aea2198f7193", "new_mode": 33188, "new_path": "src/dawn/native/d3d/QueueD3D.h" }, { "type": "modify", "old_id": "8ea054877f76543027fb39e71abdfc4e08b8a6a7", "old_mode": 33188, "old_path": "src/dawn/native/d3d11/BufferD3D11.h", "new_id": "c45f80a6ed47596c9430e4ae88c89b1c91dec9eb", "new_mode": 33188, "new_path": "src/dawn/native/d3d11/BufferD3D11.h" }, { "type": "modify", "old_id": "88ad8027db2099bbbd67bb891d6cd7d05335e8d3", "old_mode": 33188, "old_path": "src/dawn/native/d3d11/QueueD3D11.h", "new_id": "2c3fbdea73fab3d9c0c256491cb7738397311672", "new_mode": 33188, "new_path": "src/dawn/native/d3d11/QueueD3D11.h" }, { "type": "modify", "old_id": "5a855737ae11ef38d6b7251763cb91a61355b9dd", "old_mode": 33188, "old_path": "src/dawn/native/d3d12/BufferD3D12.h", "new_id": "36298888dd553ef99e7200aa819aea6a659d4ff5", "new_mode": 33188, "new_path": "src/dawn/native/d3d12/BufferD3D12.h" }, { "type": "modify", "old_id": "812cf45860f150c8069fcb6b3395c6e58254c869", "old_mode": 33188, "old_path": "src/dawn/native/d3d12/ResidencyManagerD3D12.h", "new_id": "e77bc23ad0b8048c0176341c9031bc9972be86c7", "new_mode": 33188, "new_path": "src/dawn/native/d3d12/ResidencyManagerD3D12.h" }, { "type": "modify", "old_id": "a8181578b58e1d32e16018d88756b417a201d049", "old_mode": 33188, "old_path": "src/dawn/native/metal/BufferMTL.h", "new_id": "beb9c39ee01e0377032fc050488c8af5f52f1fcf", "new_mode": 33188, "new_path": "src/dawn/native/metal/BufferMTL.h" }, { "type": "modify", "old_id": "dff2b2f6acd0aebbf5767e0cebd63ba37a858703", "old_mode": 33188, "old_path": "src/dawn/native/opengl/ContextEGL.cpp", "new_id": "dc6d97d93ebbadc619274da9f3fc99f56167ef67", "new_mode": 33188, "new_path": "src/dawn/native/opengl/ContextEGL.cpp" }, { "type": "modify", "old_id": "350bbd74904cce97bc20cf272031271c468626d5", "old_mode": 33188, "old_path": "src/dawn/native/opengl/ContextEGL.h", "new_id": "426779471fcc9caeb7f512a9625d4b625d13b2d7", "new_mode": 33188, "new_path": "src/dawn/native/opengl/ContextEGL.h" }, { "type": "modify", "old_id": "7713b1253deb0438c3cc7b205b9895828f45de79", "old_mode": 33188, "old_path": "src/dawn/native/opengl/ShaderModuleGL.h", "new_id": "9b014371fc9d6f6ef442d136e7955e2ca5a490fc", "new_mode": 33188, "new_path": "src/dawn/native/opengl/ShaderModuleGL.h" }, { "type": "modify", "old_id": "e40674939937f1430d3762f9202d9351c958e27d", "old_mode": 33188, "old_path": "src/dawn/native/opengl/TextureGL.cpp", "new_id": "4e733893a9689093731a22511334ded4f7009d51", "new_mode": 33188, "new_path": "src/dawn/native/opengl/TextureGL.cpp" }, { "type": "modify", "old_id": "663ed262e15af031c932bf96ed4f2a09343fabf4", "old_mode": 33188, "old_path": "src/dawn/native/opengl/TextureGL.h", "new_id": "67ab287511b201d9c2f90508138d1aecb69938b8", "new_mode": 33188, "new_path": "src/dawn/native/opengl/TextureGL.h" }, { "type": "modify", "old_id": "4fe5b3b2da1bc4c44d7a28bc3c40ad657c00855e", "old_mode": 33188, "old_path": "src/dawn/native/stream/ByteVectorSink.h", "new_id": "6fbe457c28c2440ebf66964c102a73e302a84311", "new_mode": 33188, "new_path": "src/dawn/native/stream/ByteVectorSink.h" }, { "type": "modify", "old_id": "6e04772f8b7307f2ba2afb2b1ac4cddd9015fa9c", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/FramebufferCache.h", "new_id": "9a783cca6e70a2a857cfc4c05da9bb64c259e50f", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/FramebufferCache.h" }, { "type": "modify", "old_id": "c9349ad9cf11c4132a2e65c54c75379148079fcf", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/RenderPassCache.h", "new_id": "f390d03b435e2d3eed2aae52e612596b0b771416", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/RenderPassCache.h" }, { "type": "modify", "old_id": "352d0b27d6c365066d80fcf49f039b0809524442", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/RenderPipelineVk.h", "new_id": "4163ec62beaca7d0da0eb1512d99d739c40a5803", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/RenderPipelineVk.h" }, { "type": "modify", "old_id": "693d9fb25bcdebdf3afebd9c56aa58a25871c2d4", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/ShaderModuleVk.h", "new_id": "f0103db32745c24d483df814d3da501b43f53df9", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/ShaderModuleVk.h" }, { "type": "modify", "old_id": "333f855e00a5bf37c908692f7ddc4b9d1f07e85a", "old_mode": 33188, "old_path": "src/dawn/tests/DawnTest.cpp", "new_id": "0971b75632b9c2af05af4766bef896de8e388075", "new_mode": 33188, "new_path": "src/dawn/tests/DawnTest.cpp" }, { "type": "modify", "old_id": "9d7f677f0b2c21fbb3f764bcbc7bf338547841e2", "old_mode": 33188, "old_path": "src/dawn/tests/DawnTest.h", "new_id": "194eea4937df537788c81779832c885a430d7022", "new_mode": 33188, "new_path": "src/dawn/tests/DawnTest.h" }, { "type": "modify", "old_id": "a63e7eda7f001765833a88ade8c7a87848020615", "old_mode": 33188, "old_path": "src/dawn/tests/perf_tests/DrawCallPerf.cpp", "new_id": "e9a1bd1c46354e195102a4a917750636dfc41344", "new_mode": 33188, "new_path": "src/dawn/tests/perf_tests/DrawCallPerf.cpp" }, { "type": "modify", "old_id": "30528644c636195cba4b5b44717a49d2734e043a", "old_mode": 33188, "old_path": "src/dawn/utils/WGPUHelpers.h", "new_id": "994c3fd8e327a8962a450d842aeda26f6856d7c4", "new_mode": 33188, "new_path": "src/dawn/utils/WGPUHelpers.h" } ] }