tree 08857a560d7c2cf14f4cecf49cefd6f8ab9992e1
parent 6e3b13e446aaa2992ac465bc0eb46748cfd041c8
author Jiawei Shao <jiawei.shao@intel.com> 1706494723 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1706494723 +0000

Reland "Use std::variant in ShaderBindingInfo"

This is a reland of commit 6ff16980d1a68a88a8e4a2a1a184f2c516868178

This patch fixes the build error in ShaderModuleMTL.mm by removing the
structured binding in the for-loop as in the for-loop the lambda
expressions can only capture variables, while structured binding doesn't
introduce variables.

Original change's description:
> Use std::variant in ShaderBindingInfo
>
> This patch uses std::variant to represent 4 possible member types in
> ShaderBindingInfo (BufferBindingLayout, ShaderSamplerBindingInfo,
> ShaderTextureBindingInfo, StorageTextureBindingLayout) as logically
> at any time only one of them can be used.
>
> Bug: dawn:527
> Change-Id: Iad9eaef9706e797cd3db57761dba370047a92fc5
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/171220
> Reviewed-by: Ben Clayton <bclayton@google.com>
> Reviewed-by: Austin Eng <enga@chromium.org>
> Kokoro: Kokoro <noreply+kokoro@google.com>
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>

Bug: dawn:527
Change-Id: Ib763df97561835d397c5768a53b6c5ccfb4d67b4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/171681
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>