)]}'
{
  "commit": "d6eb2e75016b3e893b0260fa91be93e0d49c3c9b",
  "tree": "a6ef8272f878a7692cc8c6d01b418d8edbaa3f6c",
  "parents": [
    "c8eff1c1e1b88b98b2cf1fa52efbac487f4a747c"
  ],
  "author": {
    "name": "Jiawei Shao",
    "email": "jiawei.shao@intel.com",
    "time": "Tue Mar 05 00:03:28 2019 +0000"
  },
  "committer": {
    "name": "Commit Bot service account",
    "email": "commit-bot@chromium.org",
    "time": "Tue Mar 05 00:03:28 2019 +0000"
  },
  "message": "Fix crashes when using error textures in copy commands\n\nThis patch fixes a Dawn crash issue when using textures in error state\nin the copy commands of CommandEncoder.\n\nIn Dawn\u0027s copy commands (copyBufferToTexture and CopyTextureToBuffer),\nwe should check if the texture is in error state or not, or the assert\nASSERT(!IsError()) in texture-\u003eGetFormat() will fail and a crash will\noccur.\n\nIn current Dawn code the validations on the buffer and texture objects\nin the copy commands are executed in CommandEncoder::Finish(), which\nis too late for textures according to the previous investigation. This\npatch moves all these validations to the call of copy commands. The\nchecks on buffers are also moved away to keep the consistency of the\nones on textures.\n\nBUG\u003dchromium:937628\nTEST\u003ddawn_unittests\n\nChange-Id: I0bc44e76262fba5927df20c6a7551b107bad5ca1\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5240\nReviewed-by: Kai Ninomiya \u003ckainino@chromium.org\u003e\nCommit-Queue: Jiawei Shao \u003cjiawei.shao@intel.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "22f7fb83131b0294e07bc420f796975deb273a26",
      "old_mode": 33188,
      "old_path": "src/dawn_native/CommandEncoder.cpp",
      "new_id": "ef186a1b09c1fc7da6bbaa270af2490e5312c156",
      "new_mode": 33188,
      "new_path": "src/dawn_native/CommandEncoder.cpp"
    },
    {
      "type": "modify",
      "old_id": "a11731b962e845a02e3bbf720dce2c79ff4a341b",
      "old_mode": 33188,
      "old_path": "src/tests/unittests/validation/CopyCommandsValidationTests.cpp",
      "new_id": "dbb683657127a321954a782351e18fa8b426b43a",
      "new_mode": 33188,
      "new_path": "src/tests/unittests/validation/CopyCommandsValidationTests.cpp"
    }
  ]
}