)]}' { "commit": "dbf805fe8d93c44a05ff4633df703a6b19e8f1e3", "tree": "6516597abd635c7f6940a2c75ee0f876e183d723", "parents": [ "db34c78910773b9a5b092bf53bf5232582f1310e" ], "author": { "name": "Corentin Wallez", "email": "cwallez@chromium.org", "time": "Mon Jul 06 18:08:10 2020 +0000" }, "committer": { "name": "Commit Bot service account", "email": "commit-bot@chromium.org", "time": "Mon Jul 06 18:08:10 2020 +0000" }, "message": "Update GetMappedRange to not produce validation errors\n\nGetMappedRange never produces errors and instead returns nullptr when it\nis disallowed. When in a correct state, should return a valid pointer as\nmuch as possible, even if the buffer is an error or if the device is\nlost.\n\nAdds tests for error buffers and device loss, and modify existing tests\nto not expect a device error.\n\nAlso removes some dead code in the Vulkan backend and adds a fix for\nmissing deallocation of VkMemory on device shutdown.\n\nBug: dawn:445\n\nChange-Id: Ia844ee3493cdaf75083424743dd194fa94faf591\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/24160\nCommit-Queue: Corentin Wallez \u003ccwallez@chromium.org\u003e\nReviewed-by: Stephen White \u003csenorblanco@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "0414159f1f1596d23f38574be006fffe40df1480", "old_mode": 33188, "old_path": "src/dawn_native/Buffer.cpp", "new_id": "cc1b6e78131c910abd6d7545d52847ea2dfd87d1", "new_mode": 33188, "new_path": "src/dawn_native/Buffer.cpp" }, { "type": "modify", "old_id": "ea67fab4bc7b236a27f130b5d1e001ac30635a04", "old_mode": 33188, "old_path": "src/dawn_native/Buffer.h", "new_id": "3dfaa2a1ac4a64c92a8297ccbcb3e010cb3a4e42", "new_mode": 33188, "new_path": "src/dawn_native/Buffer.h" }, { "type": "modify", "old_id": "74e84690e281a00d476e6efce61d29332361a1be", "old_mode": 33188, "old_path": "src/dawn_native/vulkan/BufferVk.cpp", "new_id": "37758cfb84f4bfd1376d8f9be7ab3488a9758e87", "new_mode": 33188, "new_path": "src/dawn_native/vulkan/BufferVk.cpp" }, { "type": "modify", "old_id": "ace13a90a63e6f605c545759eb97395f16a70ff0", "old_mode": 33188, "old_path": "src/dawn_native/vulkan/BufferVk.h", "new_id": "feb64b44a4cc4d0077ca17ea60a584ec36d8ebff", "new_mode": 33188, "new_path": "src/dawn_native/vulkan/BufferVk.h" }, { "type": "modify", "old_id": "5a2a905ff0c45448ee162488a20da079266ff305", "old_mode": 33188, "old_path": "src/dawn_native/vulkan/DeviceVk.cpp", "new_id": "da8c5924c252fa280cf99033261acdf9cfd86db6", "new_mode": 33188, "new_path": "src/dawn_native/vulkan/DeviceVk.cpp" }, { "type": "modify", "old_id": "993b2b2e9af3216a8ade37ae7035eb68d6a64cc0", "old_mode": 33188, "old_path": "src/dawn_wire/client/Buffer.cpp", "new_id": "eeb5e49b15033eead73375f834a8a80d6c6f1be6", "new_mode": 33188, "new_path": "src/dawn_wire/client/Buffer.cpp" }, { "type": "modify", "old_id": "b0ff2b86214d762bb8fed429cc78bd9e288c60f1", "old_mode": 33188, "old_path": "src/tests/end2end/BufferTests.cpp", "new_id": "71630513577012de0918d18073ad286652002335", "new_mode": 33188, "new_path": "src/tests/end2end/BufferTests.cpp" }, { "type": "modify", "old_id": "fbae56626496a4c25d2a24861c84f884ef4c2d3d", "old_mode": 33188, "old_path": "src/tests/end2end/DeviceLostTests.cpp", "new_id": "40d8fe4b6d2b53a5b8f388cd3aff226a2e4577d0", "new_mode": 33188, "new_path": "src/tests/end2end/DeviceLostTests.cpp" }, { "type": "modify", "old_id": "d1ececfcb15a72c9792a63c1daeb7aadb20c3696", "old_mode": 33188, "old_path": "src/tests/unittests/validation/BufferValidationTests.cpp", "new_id": "eedd18be7bc0fc0749e9cd30476e9a597845a7d3", "new_mode": 33188, "new_path": "src/tests/unittests/validation/BufferValidationTests.cpp" } ] }