)]}' { "commit": "e10e6b0db85341924a2e64c1e6d5b72939192d43", "tree": "ae315643ace4b24b10b62d4612e2c1fa264084bd", "parents": [ "f091fb71f7280ccdacd3403a2579e95d00fb900f" ], "author": { "name": "Corentin Wallez", "email": "cwallez@chromium.org", "time": "Thu Jan 21 12:44:09 2021 +0000" }, "committer": { "name": "Commit Bot service account", "email": "commit-bot@chromium.org", "time": "Thu Jan 21 12:44:09 2021 +0000" }, "message": "Vulkan: Fix layout of Sampled+ROStorage texture.\n\nVulkan requires that storage images be in the GENERAL layout, and requires\nthat we choose a layout at VkDescriptorSet creation. This means that\nsince Sampled+ROStorage texture may sometimes be used as both usages in\nthe same pass, they must always be in the GENERAL layout even for\nSampledTexture bindings.\n\nFix this by looking at the texture\u0027s creation usage in VulkanImageLayout\nfor wgpu::TextureUsage::Sampled.\n\nAlso add a regression test that triggers a Vulkan Validation Layer error\nwithout this fix.\n\nBug: dawn:635\n\nChange-Id: I4a5b94e1af20839b3b8cc080d36fca59d79f09bb\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/38107\nCommit-Queue: Corentin Wallez \u003ccwallez@chromium.org\u003e\nAuto-Submit: Corentin Wallez \u003ccwallez@chromium.org\u003e\nReviewed-by: Austin Eng \u003cenga@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "b99309089c1937de2881daa5ad4fd3ebaa389f40", "old_mode": 33188, "old_path": "src/dawn_native/vulkan/BindGroupVk.cpp", "new_id": "e80f6e265c037490f0f5838a16cf38392542e866", "new_mode": 33188, "new_path": "src/dawn_native/vulkan/BindGroupVk.cpp" }, { "type": "modify", "old_id": "218e60b8a64ad98898f1f06fd6cf6c2ab3ac2c40", "old_mode": 33188, "old_path": "src/dawn_native/vulkan/TextureVk.cpp", "new_id": "d14510448a1b00a90d17ca552c85921de17d5439", "new_mode": 33188, "new_path": "src/dawn_native/vulkan/TextureVk.cpp" }, { "type": "modify", "old_id": "2e4f79d0d3c4d182a3272d5eb4a691d94808804d", "old_mode": 33188, "old_path": "src/dawn_native/vulkan/TextureVk.h", "new_id": "9af6701198f2cf75059064767f1ebfd9540c709d", "new_mode": 33188, "new_path": "src/dawn_native/vulkan/TextureVk.h" }, { "type": "modify", "old_id": "4db671c19374eb01a244dee2aaf7be27e565cb68", "old_mode": 33188, "old_path": "src/tests/end2end/GpuMemorySynchronizationTests.cpp", "new_id": "e5f97f8d2c4682936c4e6c6abbe0edc7a55b807e", "new_mode": 33188, "new_path": "src/tests/end2end/GpuMemorySynchronizationTests.cpp" } ] }