tree cec599dac8461e9ded302e2bad0bd8c3886d6e56
parent e5dc0b76fa8bb4bcfd3845c988a6b57b83ffda36
author Devon Loehr <dloehr@google.com> 1721395528 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1721395528 +0000

Make implicit `this` capture explicit

When declaring a lambda with a value-capture default [=, ...], the
this pointer is implicitly captured by value as well. This results
in potentially-unintuitive behavior and has been deprecated in C++20.
It produces a warning in newer versions of clang
(https://reviews.llvm.org/D142639).

This prevents the warning by changing all lambdas which capture `this`
by value to capture all their variables explicitly, with no default.
This strategy preserves compatibility with prior C++ versions.
It does not change the compiled code at all, since it's just removing
some syntactic sugar.

Bug: chromium:351004963
Change-Id: I29623f5dc5bbee760ac5d9f0abe2df0e2e8c2d4c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/198754
Commit-Queue: Devon Loehr <dloehr@google.com>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: James Price <jrprice@google.com>