)]}' { "commit": "e25ee25e774366f8c178ee5a9cb29def31ce9611", "tree": "d0a0cc017dbfa1278cf83668476cba83a51b8813", "parents": [ "275a95c1dc64638ef4eddc8df8eab66efa516bea" ], "author": { "name": "Bryan Bernhart", "email": "bryan.bernhart@intel.com", "time": "Mon May 18 23:25:31 2020 +0000" }, "committer": { "name": "Commit Bot service account", "email": "commit-bot@chromium.org", "time": "Mon May 18 23:25:31 2020 +0000" }, "message": "D3D12: De-duplicate sampler heap allocations.\n\nAllows bindgroups that use the same samplers to share\na descriptor heap allocation. This is particularly important\nfor sampler heaps which incur expensive pipeline flushes\ndue to the smaller size requiring more frequent switches.\n\nThe device dolls out entries to a sampler heap allocation cache.\nWhen the BindGroup is created, it does a lookup and refs the\nallocation. This ensures the cache does not grow unbounded\nor needlessly store unused entires.\n\nThis change is a follow-up of de-coupling heaps.\n\nBUG\u003ddawn:155\n\nChange-Id: I3ab6f1bdb13a40905cb990cd7a2139e73da30303\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/20783\nCommit-Queue: Bryan Bernhart \u003cbryan.bernhart@intel.com\u003e\nReviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "8e97fae1316e8685a8aa1eb1a3f039e9ae16d0f4", "old_mode": 33188, "old_path": "src/dawn_native/BUILD.gn", "new_id": "b55c05fa2457bf3910b40983bc8cb4dca1a76ed0", "new_mode": 33188, "new_path": "src/dawn_native/BUILD.gn" }, { "type": "modify", "old_id": "840c4047c38d42f9b820dca7cbf080c527fcdc96", "old_mode": 33188, "old_path": "src/dawn_native/BindGroup.cpp", "new_id": "647587c26df857c594d0d7d7ec1a34fefa44ff39", "new_mode": 33188, "new_path": "src/dawn_native/BindGroup.cpp" }, { "type": "modify", "old_id": "6afee61083639909ebf2183a84b0aaba8e02536a", "old_mode": 33188, "old_path": "src/dawn_native/BindGroup.h", "new_id": "12402464fcbef10302b1486930ce2428ee77d243", "new_mode": 33188, "new_path": "src/dawn_native/BindGroup.h" }, { "type": "modify", "old_id": "1465ad010b6054a70bdd2efebc86dc97f57e34d9", "old_mode": 33188, "old_path": "src/dawn_native/CMakeLists.txt", "new_id": "aa5aa702b7809754cc8d66260c5a2664d1fc83b5", "new_mode": 33188, "new_path": "src/dawn_native/CMakeLists.txt" }, { "type": "modify", "old_id": "5aeaf567c06b6de904761be0cc3a2eb7c56ff35f", "old_mode": 33188, "old_path": "src/dawn_native/d3d12/BindGroupD3D12.cpp", "new_id": "76fb0289796324b84b78e0430bec474bf200207e", "new_mode": 33188, "new_path": "src/dawn_native/d3d12/BindGroupD3D12.cpp" }, { "type": "modify", "old_id": "05d67b4ba3b7cbcb3826f75a9c7c353c1698d509", "old_mode": 33188, "old_path": "src/dawn_native/d3d12/BindGroupD3D12.h", "new_id": "54acb3de38eebc7ab4da1a18724c1a2df6b4e68b", "new_mode": 33188, "new_path": "src/dawn_native/d3d12/BindGroupD3D12.h" }, { "type": "modify", "old_id": "c5c799942e76a2229057155d0679f94d69a4bcff", "old_mode": 33188, "old_path": "src/dawn_native/d3d12/BindGroupLayoutD3D12.cpp", "new_id": "2bd7bae971d8dbcf2b53e2c7cf3167ef903e84f9", "new_mode": 33188, "new_path": "src/dawn_native/d3d12/BindGroupLayoutD3D12.cpp" }, { "type": "modify", "old_id": "d04ab75039bcee7b6bbdbad702798290613e2f0d", "old_mode": 33188, "old_path": "src/dawn_native/d3d12/BindGroupLayoutD3D12.h", "new_id": "e739ca25ef1e6727be38b8d883ca6624e5f28ce1", "new_mode": 33188, "new_path": "src/dawn_native/d3d12/BindGroupLayoutD3D12.h" }, { "type": "modify", "old_id": "0ec73aaa76daea56fce9410d7c89c433e2ce1d21", "old_mode": 33188, "old_path": "src/dawn_native/d3d12/CommandBufferD3D12.cpp", "new_id": "ebbef1cc7bb0f4aa1e3f23e22298c3f206a8bcce", "new_mode": 33188, "new_path": "src/dawn_native/d3d12/CommandBufferD3D12.cpp" }, { "type": "modify", "old_id": "cfd109f691eb0b95e50254ced9e93e74c5738bbe", "old_mode": 33188, "old_path": "src/dawn_native/d3d12/DeviceD3D12.cpp", "new_id": "21f4aaffdf4097ecc3729ec51c646126bc6f9fee", "new_mode": 33188, "new_path": "src/dawn_native/d3d12/DeviceD3D12.cpp" }, { "type": "modify", "old_id": "450523024aaee005ab4bd3b9b9e0bdad0fd3e63e", "old_mode": 33188, "old_path": "src/dawn_native/d3d12/DeviceD3D12.h", "new_id": "88011b9b711c4b7be9162f6f40bfdb84cb3af7c4", "new_mode": 33188, "new_path": "src/dawn_native/d3d12/DeviceD3D12.h" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "224051a1c42544a0e60d8fae54b14387999aab86", "new_mode": 33188, "new_path": "src/dawn_native/d3d12/SamplerHeapCacheD3D12.cpp" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "2f41086c8b238551eb8bfca62daee6d25168c162", "new_mode": 33188, "new_path": "src/dawn_native/d3d12/SamplerHeapCacheD3D12.h" }, { "type": "modify", "old_id": "cbe7dcba94f10a9c501b746cd9360f587c200db6", "old_mode": 33188, "old_path": "src/tests/white_box/D3D12DescriptorHeapTests.cpp", "new_id": "b6eb4a6b45000e967ad98931a41a565f9a170fbb", "new_mode": 33188, "new_path": "src/tests/white_box/D3D12DescriptorHeapTests.cpp" } ] }