)]}'
{
  "commit": "e3a55c65bb66bfabb65de7bd69ee062b02bbe911",
  "tree": "857dcd148abe516b2dfedc583742527c032a29fe",
  "parents": [
    "31f1e527d6865cc02b1ceda203c77cb0da070b79"
  ],
  "author": {
    "name": "Colin Blundell",
    "email": "blundell@chromium.org",
    "time": "Tue Feb 06 12:10:46 2024 +0000"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Tue Feb 06 12:10:46 2024 +0000"
  },
  "message": "[toggles] Set labels on backend objects only if toggle is set\n\nWe have found that in Chrome, setting these labels can be a source of\nnon-trivial overhead on performance benchmarks. This CL guards setting\nof these labels with the `use_user_defined_labels_in_backend` toggle.\nNote that labels will still be set on frontend objects, and hence will\nstill be available in e.g. Dawn error messages. The labels on the\nbackend objects are relevant only when debugging via platform-specific\nfacilities (e.g., XCode).\n\nThis CL also changes the `use_user_defined_labels_in_backend` toggle to\ndefault to true if validation is enabled. This is necessary as at least\non Vulkan Dawn\u0027s debugging facilities assume that these labels are\nset [1]. It is consistent in any case, as a client enabling validation\nindicates that they are more concerned about debuggability than\nperformance.\n\n[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/dawn/src/dawn/native/vulkan/BackendVk.cpp;l\u003d263?q\u003dBackendVk.cpp\u0026ss\u003dchromium\n\nChange-Id: I46fd862382f89e61588535c16daeba976d45825e\nBug: dawn:2383\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/172861\nReviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\nKokoro: Kokoro \u003cnoreply+kokoro@google.com\u003e\nCommit-Queue: Colin Blundell \u003cblundell@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "c846ed6ed42e9acc79fcef1e72f3f44374321329",
      "old_mode": 33188,
      "old_path": "src/dawn/native/Adapter.cpp",
      "new_id": "ffed27fa3f3fba3188193f8e408add8e583d6846",
      "new_mode": 33188,
      "new_path": "src/dawn/native/Adapter.cpp"
    },
    {
      "type": "modify",
      "old_id": "85fbc5e900c1ad42dea357df389798330ac88b4a",
      "old_mode": 33188,
      "old_path": "src/dawn/native/Toggles.cpp",
      "new_id": "3910bd345a40589562a95afe6bd7e5d93e9b1a83",
      "new_mode": 33188,
      "new_path": "src/dawn/native/Toggles.cpp"
    },
    {
      "type": "modify",
      "old_id": "a453b2d0b98fd69275d1e3a71ae0aca4657d6e8d",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d11/UtilsD3D11.cpp",
      "new_id": "ba185b7b88558b01ca8228b47ecc380b0bb702fd",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d11/UtilsD3D11.cpp"
    },
    {
      "type": "modify",
      "old_id": "34c0bcc70617513b65b4fbaf153bad275a7125b8",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d12/PhysicalDeviceD3D12.cpp",
      "new_id": "f17def94f4b18ada4f1144dbc792ebed15707243",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d12/PhysicalDeviceD3D12.cpp"
    },
    {
      "type": "modify",
      "old_id": "5a294f324510dde670952cb95a68ff5442486983",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d12/UtilsD3D12.cpp",
      "new_id": "ea12054693b8006b6e0c65652ff8b8b16b23c2c1",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d12/UtilsD3D12.cpp"
    },
    {
      "type": "modify",
      "old_id": "1f06b178b860f725abc602e4c8fd080f496d0ed7",
      "old_mode": 33188,
      "old_path": "src/dawn/native/metal/UtilsMetal.h",
      "new_id": "ee419233be45d531f15f28a3b9992b4352399374",
      "new_mode": 33188,
      "new_path": "src/dawn/native/metal/UtilsMetal.h"
    },
    {
      "type": "modify",
      "old_id": "4cbf88bf046e2f50e13af530f03d1aa4d78913a3",
      "old_mode": 33188,
      "old_path": "src/dawn/native/vulkan/UtilsVulkan.cpp",
      "new_id": "c853e33261d95a9fc6fec37086a46172c95ef6b0",
      "new_mode": 33188,
      "new_path": "src/dawn/native/vulkan/UtilsVulkan.cpp"
    }
  ]
}