tree 857dcd148abe516b2dfedc583742527c032a29fe
parent 31f1e527d6865cc02b1ceda203c77cb0da070b79
author Colin Blundell <blundell@chromium.org> 1707221446 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1707221446 +0000

[toggles] Set labels on backend objects only if toggle is set

We have found that in Chrome, setting these labels can be a source of
non-trivial overhead on performance benchmarks. This CL guards setting
of these labels with the `use_user_defined_labels_in_backend` toggle.
Note that labels will still be set on frontend objects, and hence will
still be available in e.g. Dawn error messages. The labels on the
backend objects are relevant only when debugging via platform-specific
facilities (e.g., XCode).

This CL also changes the `use_user_defined_labels_in_backend` toggle to
default to true if validation is enabled. This is necessary as at least
on Vulkan Dawn's debugging facilities assume that these labels are
set [1]. It is consistent in any case, as a client enabling validation
indicates that they are more concerned about debuggability than
performance.

[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/dawn/src/dawn/native/vulkan/BackendVk.cpp;l=263?q=BackendVk.cpp&ss=chromium

Change-Id: I46fd862382f89e61588535c16daeba976d45825e
Bug: dawn:2383
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/172861
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Colin Blundell <blundell@chromium.org>