Google Git
Sign in
dawn / dawn / e7ad6c436b745a04c770f718dc072b146833379c
commite7ad6c436b745a04c770f718dc072b146833379c[log] [tgz]
authorKai Ninomiya <kainino@chromium.org>Fri Sep 06 10:14:22 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Sep 06 10:14:22 2024 +0000
tree982762d33cf8624c8f68c09dfc5dbc1688133110
parentb339ed4daf668b7377134347f29a41239dee3ed6 [diff]
[emdawnwebgpu] Fix two refcounting bugs, and fix for 64-bit flags

- Ref::~Ref was calling the virtual method Release(), which for
  RefCountedWithExternalCount releases an external ref (but Ref<> is
  supposed to only be an internal ref). I stumbled on this; it did not
  actually cause any crashes, but the external refcount value was wrong.
- There was an atomic fetch_add() inside an assert(), which was skipped
  in release builds.
- Switching bitflags to 64-bit broke the Wasm->JS calling convention (in
  a very hard to find way as usual), so did the TODO that was there to
  fix it.
- Add some runtimeKeepalivePush/Pop calls for the DeviceLost callbacks.
  This seems to be the only instance of `.then()` that didn't have it.
  (I didn't actually see a crash here, I just noticed it. Note, this is
  an odd case because it may never be called, but I think this behavior
  is correct. In the future we might be able to destroy() the device
  when all of its internal and external refs reach 0? Then the
  DeviceLost callbacks should get called and the runtime can shut down.)

Discovered with and debugged/tested against this project:
https://github.com/kainino0x/webgpu-cross-platform-demo/tree/dawnwasm

Fixed: 347732150
Bug: none
Change-Id: I6cb3775b3ea7f63772cb79564e732df77c8aab68
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/205874
Auto-Submit: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
3 files changed
tree: 982762d33cf8624c8f68c09dfc5dbc1688133110
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. AUTHORS
  25. BUILD.bazel
  26. BUILD.gn
  27. CMakeLists.txt
  28. CMakeSettings.json
  29. CODE_OF_CONDUCT.md
  30. codereview.settings
  31. CONTRIBUTING.md
  32. CPPLINT.cfg
  33. DEPS
  34. DIR_METADATA
  35. go.mod
  36. go.sum
  37. go_presubmit_support.py
  38. LICENSE
  39. OWNERS
  40. PRESUBMIT.py
  41. README.chromium
  42. README.md
  43. WATCHLISTS
  44. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.