)]}'
{
  "commit": "e7dbf31cf9efca6bfdee8d7c928f08f45f8779ca",
  "tree": "156eb2a2f0d4e500619193dac35453e2871c2c0d",
  "parents": [
    "197289e9cb5ebbc06d1ac7a36ad7c0a49b9c3b8b"
  ],
  "author": {
    "name": "James Price",
    "email": "jrprice@google.com",
    "time": "Tue Dec 03 23:13:09 2024 +0000"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Tue Dec 03 23:13:09 2024 +0000"
  },
  "message": "[tint] Emit `unreachable` as `return` for non-void functions\n\nThe `PreventInfiniteLoops` transforms changes the control flow such\nthat some `unreachable` instructions become statically reachable. This\nmay upset some downstream compilers that want to ensure that non-void\nfunctions always return.\n\nThere are various places that unreachable instructions show up, so\njust always emit them as `return` statements in the textual backends\ninstead of only handling this in the infinite loop transform.\n\nFixed: 381541325\nChange-Id: I92b5063361b179f0618e0f5130a29dfae98ea735\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/217894\nReviewed-by: Antonio Maiorano \u003camaiorano@google.com\u003e\nCommit-Queue: James Price \u003cjrprice@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "aeae1832a7033c5593d178eceefaf3137af67c91",
      "old_mode": 33188,
      "old_path": "src/tint/lang/glsl/writer/if_test.cc",
      "new_id": "08ff85a42048af3136e0fe5c5e716d3c0e19c302",
      "new_mode": 33188,
      "new_path": "src/tint/lang/glsl/writer/if_test.cc"
    },
    {
      "type": "modify",
      "old_id": "0477b23054d75bfcbc6552b7fe7c334032b2171c",
      "old_mode": 33188,
      "old_path": "src/tint/lang/glsl/writer/printer/printer.cc",
      "new_id": "19938cadfbbc9d58507c4e4b4c0d499ca717a4b4",
      "new_mode": 33188,
      "new_path": "src/tint/lang/glsl/writer/printer/printer.cc"
    },
    {
      "type": "modify",
      "old_id": "524a1c4495ccb1745606acc6dc73b9cf9785a952",
      "old_mode": 33188,
      "old_path": "src/tint/lang/hlsl/writer/if_test.cc",
      "new_id": "c45e6e61717a4efe2c7c82d080c32504f9c8699f",
      "new_mode": 33188,
      "new_path": "src/tint/lang/hlsl/writer/if_test.cc"
    },
    {
      "type": "modify",
      "old_id": "80b9f98ead01239d12314d6250494b05246baf03",
      "old_mode": 33188,
      "old_path": "src/tint/lang/hlsl/writer/printer/printer.cc",
      "new_id": "2bffce738e80645d79150469dcebfca0f05b105c",
      "new_mode": 33188,
      "new_path": "src/tint/lang/hlsl/writer/printer/printer.cc"
    },
    {
      "type": "modify",
      "old_id": "8338165cfaf2bfd8b79dc26fa27a0132387a32ff",
      "old_mode": 33188,
      "old_path": "src/tint/lang/msl/writer/if_test.cc",
      "new_id": "a10591a5d52971a71aa70e1d08617b3e8922d245",
      "new_mode": 33188,
      "new_path": "src/tint/lang/msl/writer/if_test.cc"
    },
    {
      "type": "modify",
      "old_id": "f493452e10907db31c9d96d2fb02302221ba0fff",
      "old_mode": 33188,
      "old_path": "src/tint/lang/msl/writer/printer/printer.cc",
      "new_id": "ab1dd5617d391f154770c5047031064dd2bb89e1",
      "new_mode": 33188,
      "new_path": "src/tint/lang/msl/writer/printer/printer.cc"
    },
    {
      "type": "modify",
      "old_id": "01d1505a0d1a5eb3d498cccae7310a4983e9e0ca",
      "old_mode": 33188,
      "old_path": "test/tint/loops/loop.wgsl.expected.glsl",
      "new_id": "a729ae7effc73abaddc7ddc11049f58b2155ea47",
      "new_mode": 33188,
      "new_path": "test/tint/loops/loop.wgsl.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "8a55eb3bc7ecddf297e185d6ac2fc160230f0bfe",
      "old_mode": 33188,
      "old_path": "test/tint/loops/loop.wgsl.expected.ir.msl",
      "new_id": "8abcec5e8b6bbd3fb9dda353b7aefa7ae3bc12ce",
      "new_mode": 33188,
      "new_path": "test/tint/loops/loop.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "01d1505a0d1a5eb3d498cccae7310a4983e9e0ca",
      "old_mode": 33188,
      "old_path": "test/tint/loops/loop_robustness.wgsl.expected.glsl",
      "new_id": "a729ae7effc73abaddc7ddc11049f58b2155ea47",
      "new_mode": 33188,
      "new_path": "test/tint/loops/loop_robustness.wgsl.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "8a55eb3bc7ecddf297e185d6ac2fc160230f0bfe",
      "old_mode": 33188,
      "old_path": "test/tint/loops/loop_robustness.wgsl.expected.ir.msl",
      "new_id": "8abcec5e8b6bbd3fb9dda353b7aefa7ae3bc12ce",
      "new_mode": 33188,
      "new_path": "test/tint/loops/loop_robustness.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "ba98f1c494065c072f6df7fd64a1352a04d589d2",
      "old_mode": 33188,
      "old_path": "test/tint/loops/loop_with_continuing.wgsl.expected.glsl",
      "new_id": "cabda69badc60455c2efa795b62be7900468c020",
      "new_mode": 33188,
      "new_path": "test/tint/loops/loop_with_continuing.wgsl.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "9e61e13b3ce09b2acfa5953b9b0f15a529762e0d",
      "old_mode": 33188,
      "old_path": "test/tint/loops/loop_with_continuing.wgsl.expected.ir.msl",
      "new_id": "653b197d19058c5ec0d0c716b09ec2380a59cbe9",
      "new_mode": 33188,
      "new_path": "test/tint/loops/loop_with_continuing.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "ba98f1c494065c072f6df7fd64a1352a04d589d2",
      "old_mode": 33188,
      "old_path": "test/tint/loops/loop_with_continuing_robustness.wgsl.expected.glsl",
      "new_id": "cabda69badc60455c2efa795b62be7900468c020",
      "new_mode": 33188,
      "new_path": "test/tint/loops/loop_with_continuing_robustness.wgsl.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "9e61e13b3ce09b2acfa5953b9b0f15a529762e0d",
      "old_mode": 33188,
      "old_path": "test/tint/loops/loop_with_continuing_robustness.wgsl.expected.ir.msl",
      "new_id": "653b197d19058c5ec0d0c716b09ec2380a59cbe9",
      "new_mode": 33188,
      "new_path": "test/tint/loops/loop_with_continuing_robustness.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "a28aa875f75164b70bf99fe48f80453f89b6e2fa",
      "old_mode": 33188,
      "old_path": "test/tint/loops/nested_loops.wgsl.expected.glsl",
      "new_id": "6780ab0c1690960e8f7772eaa6e21e7c6032875f",
      "new_mode": 33188,
      "new_path": "test/tint/loops/nested_loops.wgsl.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "408d69285188662ddd7e4c95204e4e6ae6c61d2c",
      "old_mode": 33188,
      "old_path": "test/tint/loops/nested_loops.wgsl.expected.ir.dxc.hlsl",
      "new_id": "052ea2c44ab44fd4f2e67a5bacef716f4575e005",
      "new_mode": 33188,
      "new_path": "test/tint/loops/nested_loops.wgsl.expected.ir.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "408d69285188662ddd7e4c95204e4e6ae6c61d2c",
      "old_mode": 33188,
      "old_path": "test/tint/loops/nested_loops.wgsl.expected.ir.fxc.hlsl",
      "new_id": "052ea2c44ab44fd4f2e67a5bacef716f4575e005",
      "new_mode": 33188,
      "new_path": "test/tint/loops/nested_loops.wgsl.expected.ir.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "5041162e963ea2b90a9377af94148349e7233456",
      "old_mode": 33188,
      "old_path": "test/tint/loops/nested_loops.wgsl.expected.ir.msl",
      "new_id": "f1447d7f9b97c7526cfb7d6cd3b31b154a6c4c11",
      "new_mode": 33188,
      "new_path": "test/tint/loops/nested_loops.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "a28aa875f75164b70bf99fe48f80453f89b6e2fa",
      "old_mode": 33188,
      "old_path": "test/tint/loops/nested_loops_robustness.wgsl.expected.glsl",
      "new_id": "6780ab0c1690960e8f7772eaa6e21e7c6032875f",
      "new_mode": 33188,
      "new_path": "test/tint/loops/nested_loops_robustness.wgsl.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "408d69285188662ddd7e4c95204e4e6ae6c61d2c",
      "old_mode": 33188,
      "old_path": "test/tint/loops/nested_loops_robustness.wgsl.expected.ir.dxc.hlsl",
      "new_id": "052ea2c44ab44fd4f2e67a5bacef716f4575e005",
      "new_mode": 33188,
      "new_path": "test/tint/loops/nested_loops_robustness.wgsl.expected.ir.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "408d69285188662ddd7e4c95204e4e6ae6c61d2c",
      "old_mode": 33188,
      "old_path": "test/tint/loops/nested_loops_robustness.wgsl.expected.ir.fxc.hlsl",
      "new_id": "052ea2c44ab44fd4f2e67a5bacef716f4575e005",
      "new_mode": 33188,
      "new_path": "test/tint/loops/nested_loops_robustness.wgsl.expected.ir.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "5041162e963ea2b90a9377af94148349e7233456",
      "old_mode": 33188,
      "old_path": "test/tint/loops/nested_loops_robustness.wgsl.expected.ir.msl",
      "new_id": "f1447d7f9b97c7526cfb7d6cd3b31b154a6c4c11",
      "new_mode": 33188,
      "new_path": "test/tint/loops/nested_loops_robustness.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "c94016d5148a30337c3604f779fd9920f0f42578",
      "old_mode": 33188,
      "old_path": "test/tint/loops/nested_loops_with_continuing.wgsl.expected.glsl",
      "new_id": "9133f30d393467bc0a43e021d6c6c1ec07ec6974",
      "new_mode": 33188,
      "new_path": "test/tint/loops/nested_loops_with_continuing.wgsl.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "75b60e6cbb2d680a5c400e3557175d25a3fe06e4",
      "old_mode": 33188,
      "old_path": "test/tint/loops/nested_loops_with_continuing.wgsl.expected.ir.dxc.hlsl",
      "new_id": "65a61dd5742bb360b6aa5eb26826550a1f4dfd51",
      "new_mode": 33188,
      "new_path": "test/tint/loops/nested_loops_with_continuing.wgsl.expected.ir.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "75b60e6cbb2d680a5c400e3557175d25a3fe06e4",
      "old_mode": 33188,
      "old_path": "test/tint/loops/nested_loops_with_continuing.wgsl.expected.ir.fxc.hlsl",
      "new_id": "65a61dd5742bb360b6aa5eb26826550a1f4dfd51",
      "new_mode": 33188,
      "new_path": "test/tint/loops/nested_loops_with_continuing.wgsl.expected.ir.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "2b4726c2bdf5ab42c3d86674c2d183ded12bda36",
      "old_mode": 33188,
      "old_path": "test/tint/loops/nested_loops_with_continuing.wgsl.expected.ir.msl",
      "new_id": "d0e6af14b17762302b3544bf1a9166615a6950e0",
      "new_mode": 33188,
      "new_path": "test/tint/loops/nested_loops_with_continuing.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "c94016d5148a30337c3604f779fd9920f0f42578",
      "old_mode": 33188,
      "old_path": "test/tint/loops/nested_loops_with_continuing_robustness.wgsl.expected.glsl",
      "new_id": "9133f30d393467bc0a43e021d6c6c1ec07ec6974",
      "new_mode": 33188,
      "new_path": "test/tint/loops/nested_loops_with_continuing_robustness.wgsl.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "75b60e6cbb2d680a5c400e3557175d25a3fe06e4",
      "old_mode": 33188,
      "old_path": "test/tint/loops/nested_loops_with_continuing_robustness.wgsl.expected.ir.dxc.hlsl",
      "new_id": "65a61dd5742bb360b6aa5eb26826550a1f4dfd51",
      "new_mode": 33188,
      "new_path": "test/tint/loops/nested_loops_with_continuing_robustness.wgsl.expected.ir.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "75b60e6cbb2d680a5c400e3557175d25a3fe06e4",
      "old_mode": 33188,
      "old_path": "test/tint/loops/nested_loops_with_continuing_robustness.wgsl.expected.ir.fxc.hlsl",
      "new_id": "65a61dd5742bb360b6aa5eb26826550a1f4dfd51",
      "new_mode": 33188,
      "new_path": "test/tint/loops/nested_loops_with_continuing_robustness.wgsl.expected.ir.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "2b4726c2bdf5ab42c3d86674c2d183ded12bda36",
      "old_mode": 33188,
      "old_path": "test/tint/loops/nested_loops_with_continuing_robustness.wgsl.expected.ir.msl",
      "new_id": "d0e6af14b17762302b3544bf1a9166615a6950e0",
      "new_mode": 33188,
      "new_path": "test/tint/loops/nested_loops_with_continuing_robustness.wgsl.expected.ir.msl"
    }
  ]
}