)]}'
{
  "commit": "f031ca2d440d22d194d67d3c28ff1ae06c6a7a59",
  "tree": "c03d1356bcff0e25c35f1fc0c23163660583ef2c",
  "parents": [
    "a4117ca21bbd6e8b87e810f9e35d47860cf07a59"
  ],
  "author": {
    "name": "Antonio Maiorano",
    "email": "amaiorano@google.com",
    "time": "Thu Feb 02 22:16:42 2023 +0000"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Thu Feb 02 22:16:42 2023 +0000"
  },
  "message": "tint/hlsl: fix assignment to matrix element\n\nWhen calling the generated helper, the column and row arguments were\nswapped.\n\nImproved the unit tests to actually show this, rather than passing in a\nsingle value for both column and row.\n\nBug: tint:1824\nBug: tint:1333\nChange-Id: I32a92dec5e594dabd9d8d2b08474c0d6f3645520\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/118420\nReviewed-by: Ben Clayton \u003cbclayton@google.com\u003e\nKokoro: Kokoro \u003cnoreply+kokoro@google.com\u003e\nCommit-Queue: Antonio Maiorano \u003camaiorano@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "b89029bb6f45c687dcf51e6d44a622433087cea1",
      "old_mode": 33188,
      "old_path": "src/tint/writer/hlsl/generator_impl.cc",
      "new_id": "b360157fa6d29333d21948b8a78cf1485c34d672",
      "new_mode": 33188,
      "new_path": "src/tint/writer/hlsl/generator_impl.cc"
    },
    {
      "type": "modify",
      "old_id": "a01903efdec1de7b934330251cb0344156ae7853",
      "old_mode": 33188,
      "old_path": "src/tint/writer/hlsl/generator_impl_assign_test.cc",
      "new_id": "e1d8300d09fd32e481bc0ba5d2eb18bfec9d515a",
      "new_mode": 33188,
      "new_path": "src/tint/writer/hlsl/generator_impl_assign_test.cc"
    },
    {
      "type": "modify",
      "old_id": "d9c9833994e7eb34858a94c2ccdccc1c0197d962",
      "old_mode": 33188,
      "old_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/local_assign_scalar_x.wgsl.expected.dxc.hlsl",
      "new_id": "3bf110e884c17aa51940eee48440e99b138e6a70",
      "new_mode": 33188,
      "new_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/local_assign_scalar_x.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "d9c9833994e7eb34858a94c2ccdccc1c0197d962",
      "old_mode": 33188,
      "old_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/local_assign_scalar_x.wgsl.expected.fxc.hlsl",
      "new_id": "3bf110e884c17aa51940eee48440e99b138e6a70",
      "new_mode": 33188,
      "new_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/local_assign_scalar_x.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "254519f61ed521460d4b6c73249738fc126810e8",
      "old_mode": 33188,
      "old_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/local_assign_scalar_xy.wgsl.expected.dxc.hlsl",
      "new_id": "910f84508c1a769c5c718b58188715db2b25a7d1",
      "new_mode": 33188,
      "new_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/local_assign_scalar_xy.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "254519f61ed521460d4b6c73249738fc126810e8",
      "old_mode": 33188,
      "old_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/local_assign_scalar_xy.wgsl.expected.fxc.hlsl",
      "new_id": "910f84508c1a769c5c718b58188715db2b25a7d1",
      "new_mode": 33188,
      "new_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/local_assign_scalar_xy.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "75a62179b4fcf23541a965459742dbc048e0ae4e",
      "old_mode": 33188,
      "old_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/local_assign_scalar_y.wgsl.expected.dxc.hlsl",
      "new_id": "cedfc5a0e4ea78ae9bba5494a5869b8dec692ede",
      "new_mode": 33188,
      "new_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/local_assign_scalar_y.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "75a62179b4fcf23541a965459742dbc048e0ae4e",
      "old_mode": 33188,
      "old_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/local_assign_scalar_y.wgsl.expected.fxc.hlsl",
      "new_id": "cedfc5a0e4ea78ae9bba5494a5869b8dec692ede",
      "new_mode": 33188,
      "new_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/local_assign_scalar_y.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "c52f15737970ed282a25df537c3cbe881a26041b",
      "old_mode": 33188,
      "old_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/module_assign_scalar_x.wgsl.expected.dxc.hlsl",
      "new_id": "4b4aeb10450edcfad96e69adb6e1c4b5f02e961d",
      "new_mode": 33188,
      "new_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/module_assign_scalar_x.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "c52f15737970ed282a25df537c3cbe881a26041b",
      "old_mode": 33188,
      "old_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/module_assign_scalar_x.wgsl.expected.fxc.hlsl",
      "new_id": "4b4aeb10450edcfad96e69adb6e1c4b5f02e961d",
      "new_mode": 33188,
      "new_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/module_assign_scalar_x.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "1487ddd1d930cc0be39c02665b1616b21f4a434d",
      "old_mode": 33188,
      "old_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/module_assign_scalar_xy.wgsl.expected.dxc.hlsl",
      "new_id": "7cb37c4ba40da5b9326c81c207c13530942cadd8",
      "new_mode": 33188,
      "new_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/module_assign_scalar_xy.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "1487ddd1d930cc0be39c02665b1616b21f4a434d",
      "old_mode": 33188,
      "old_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/module_assign_scalar_xy.wgsl.expected.fxc.hlsl",
      "new_id": "7cb37c4ba40da5b9326c81c207c13530942cadd8",
      "new_mode": 33188,
      "new_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/module_assign_scalar_xy.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "75a62179b4fcf23541a965459742dbc048e0ae4e",
      "old_mode": 33188,
      "old_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/module_assign_scalar_y.wgsl.expected.dxc.hlsl",
      "new_id": "cedfc5a0e4ea78ae9bba5494a5869b8dec692ede",
      "new_mode": 33188,
      "new_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/module_assign_scalar_y.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "75a62179b4fcf23541a965459742dbc048e0ae4e",
      "old_mode": 33188,
      "old_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/module_assign_scalar_y.wgsl.expected.fxc.hlsl",
      "new_id": "cedfc5a0e4ea78ae9bba5494a5869b8dec692ede",
      "new_mode": 33188,
      "new_path": "test/tint/bug/fxc/matrix_assignment_dynamic_index/module_assign_scalar_y.wgsl.expected.fxc.hlsl"
    }
  ]
}