)]}'
{
  "commit": "f0893de068a98a81bc06279f2ff807b0be2463b9",
  "tree": "0c8e374a7d87be8c69be807300baf082f2c08872",
  "parents": [
    "6e4a366841ee807f84932a190cb8fa8d8af10e11"
  ],
  "author": {
    "name": "Antonio Maiorano",
    "email": "amaiorano@google.com",
    "time": "Fri Oct 11 22:18:47 2024 +0000"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Fri Oct 11 22:18:47 2024 +0000"
  },
  "message": "HLSL-IR: ICE on @color attribute\n\nWe don\u0027t yet gracefully handle and emit errors when using unsupported\nextensions like `chromium_experimental_framebuffer_fetch`, which is\nrequired for using `@color` attributes. This means we generate HLSL that\nthen fails FXC/DXC validation with confusing error messages. For now,\nlet\u0027s ICE on this attribute in the HLSL printer.\n\nBug: 368367513\nChange-Id: I0654d9abf0a22a7fe6759fd2a5882a6b0227fb3c\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/210636\nReviewed-by: James Price \u003cjrprice@google.com\u003e\nCommit-Queue: James Price \u003cjrprice@google.com\u003e\nAuto-Submit: Antonio Maiorano \u003camaiorano@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "94126ec9491cb418cc40d97b86510113be240fa0",
      "old_mode": 33188,
      "old_path": "src/tint/lang/hlsl/writer/printer/printer.cc",
      "new_id": "2da44e189c1cfac7305ee8843faee1d61e3c674f",
      "new_mode": 33188,
      "new_path": "src/tint/lang/hlsl/writer/printer/printer.cc"
    },
    {
      "type": "modify",
      "old_id": "7edf5572b3cc882e72e8c41406f8a499f5e3e018",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/additional_params/a.wgsl.expected.ir.dxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/additional_params/a.wgsl.expected.ir.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "5b07af98be343000fdaa4e9115feb3fe9a824701",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/additional_params/a.wgsl.expected.ir.fxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/additional_params/a.wgsl.expected.ir.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "7bbb78395078e7708d06ee7e52519a8ab9ec572f",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/additional_params/b.wgsl.expected.ir.dxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/additional_params/b.wgsl.expected.ir.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "be295ce9dc55a8e15217b33d0d0bc7c6a8bfc7e6",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/additional_params/b.wgsl.expected.ir.fxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/additional_params/b.wgsl.expected.ir.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "a15d886d9bf34fbe337759d34a94ee79d62bf452",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/additional_params/c.wgsl.expected.ir.dxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/additional_params/c.wgsl.expected.ir.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "2238847a0bda4b577d0d3fa68dc0d29a25e33306",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/additional_params/c.wgsl.expected.ir.fxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/additional_params/c.wgsl.expected.ir.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "20c255ce22d5d149a70873e71f83a7717f16c594",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/additional_params/d.wgsl.expected.ir.dxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/additional_params/d.wgsl.expected.ir.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "6d82423b22a9cc26f1fdc158d0b3e62b3ff12a2f",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/additional_params/d.wgsl.expected.ir.fxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/additional_params/d.wgsl.expected.ir.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "2b40e5a3b6c6411feced697f528df548721149be",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/additional_params/e.wgsl.expected.ir.dxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/additional_params/e.wgsl.expected.ir.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "e90c54e172c8ff7bcb4d5c90cc4bf84ad45a9bd6",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/additional_params/e.wgsl.expected.ir.fxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/additional_params/e.wgsl.expected.ir.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "668fdac3eac336e765cf26b41fa29fa50cd1373c",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/additional_params/f.wgsl.expected.ir.dxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/additional_params/f.wgsl.expected.ir.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "f7865650e0dd71c1594559cca86a2d6b4eeb631b",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/additional_params/f.wgsl.expected.ir.fxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/additional_params/f.wgsl.expected.ir.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "d4019a4259574afbef8913311bf8802e3a2e6bd3",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/additional_params/g.wgsl.expected.ir.dxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/additional_params/g.wgsl.expected.ir.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "788429582088086b321c65ed13db6c1a50751ced",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/additional_params/g.wgsl.expected.ir.fxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/additional_params/g.wgsl.expected.ir.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "aa89eece3e3a824dcaf8359cdd0591fce74ee404",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/additional_params/h.wgsl.expected.ir.dxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/additional_params/h.wgsl.expected.ir.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "336f8bb71ff305575ab7acfed311c721e9379858",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/additional_params/h.wgsl.expected.ir.fxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/additional_params/h.wgsl.expected.ir.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "c4b8227d3799594793240ef2a42f3049dee646e7",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/additional_params/i.wgsl.expected.ir.dxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/additional_params/i.wgsl.expected.ir.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "f629d603cdf49c543f04e87f6c8b6351bdab0451",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/additional_params/i.wgsl.expected.ir.fxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/additional_params/i.wgsl.expected.ir.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "b007eed79f2649eec74602ae4a7674a275f8120c",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/additional_params/j.wgsl.expected.ir.dxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/additional_params/j.wgsl.expected.ir.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "7f538d5b17fbfb3aea3d1f282d11507b8b8f4a55",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/additional_params/j.wgsl.expected.ir.fxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/additional_params/j.wgsl.expected.ir.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "08539b4223201f5db385b60340e9aa59ab1b678b",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/multiple_outputs/multiple_inputs.wgsl.expected.ir.dxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/multiple_outputs/multiple_inputs.wgsl.expected.ir.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "f918fde01312aa9e4679570f766f5b12eeda3d7d",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/multiple_outputs/multiple_inputs.wgsl.expected.ir.fxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/multiple_outputs/multiple_inputs.wgsl.expected.ir.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "5e43b8a4d2cdc66a8baec3bde114b02f71c3e0a4",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/multiple_outputs/single_input.wgsl.expected.ir.dxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/multiple_outputs/single_input.wgsl.expected.ir.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "f6c1ef1bf8aa07c74feb5023f93ffa2388236504",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/multiple_outputs/single_input.wgsl.expected.ir.fxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/multiple_outputs/single_input.wgsl.expected.ir.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "24bee40a1a5b0d4204a2d2a9145b9b27d238085c",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/one_output/multiple_inputs.wgsl.expected.ir.dxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/one_output/multiple_inputs.wgsl.expected.ir.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "6edaa6bb7e3bf123611dc37b6acd40cbe6c3002a",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/one_output/multiple_inputs.wgsl.expected.ir.fxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/one_output/multiple_inputs.wgsl.expected.ir.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "f1a72c2f58c0dce9a83223c04ab64aeb2adb349d",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/one_output/single_input.wgsl.expected.ir.dxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/one_output/single_input.wgsl.expected.ir.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "8efc01fa48733696a341110af97398a09c95f5a5",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/one_output/single_input.wgsl.expected.ir.fxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/one_output/single_input.wgsl.expected.ir.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "9d390fbd7c754f3f5834bb93690a15fd493105ce",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/zero_outputs/multiple_inputs.wgsl.expected.ir.dxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/zero_outputs/multiple_inputs.wgsl.expected.ir.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "b4022c66cb1303a90aa031911de89f3fde150143",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/zero_outputs/multiple_inputs.wgsl.expected.ir.fxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/zero_outputs/multiple_inputs.wgsl.expected.ir.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "254bb4f3eada9a30585cfb41baf07cc45eb8f084",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/zero_outputs/single_input.wgsl.expected.ir.dxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/zero_outputs/single_input.wgsl.expected.ir.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "f947064810cbc79b5359994f343309a0d40190ff",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/texel_fetch/zero_outputs/single_input.wgsl.expected.ir.fxc.hlsl",
      "new_id": "a120576ff94c7dfeae5b770cc1c2cd5efc115ff3",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/texel_fetch/zero_outputs/single_input.wgsl.expected.ir.fxc.hlsl"
    }
  ]
}