)]}'
{
  "commit": "f9eef8958cdc8bca8c628326080926ce61a178d0",
  "tree": "0c8379dd1e233e0aafe0f0270040d5faf0490223",
  "parents": [
    "39111caf4fecbe55ded075d667482085f7581182"
  ],
  "author": {
    "name": "Kai Ninomiya",
    "email": "kainino@chromium.org",
    "time": "Tue May 26 22:20:42 2026 -0700"
  },
  "committer": {
    "name": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Tue May 26 22:20:42 2026 -0700"
  },
  "message": "[dawn][common] Slightly improve check failure message in consteval\n\nDAWN_CHECK already works correctly in consteval, but the error message\nis obtuse. It works because HandleAssertionFailure is not valid to call\nin consteval, and if the assert fails, it tries to call that.\n\nThis simply calls a different non-constexpr function whose name explains\nwhat\u0027s going on. According to my online research this is really the only\nto produce a custom error message in this case (at least until C++26).\n\nExample error message:\n\n../../src/dawn/tests/unittests/TypedIntegerTests.cpp:60:15: error: constexpr variable \u0027k\u0027 must be initialized by a constant expression\n   60 | constexpr int k \u003d f();\n      |               ^   ~~~\n../../src/dawn/tests/unittests/TypedIntegerTests.cpp:56:5: note: non-constexpr function \u0027XXXXXXXXXX_CheckFailedInConsteval_XXXXXXXXXX\u0027 cannot be used in a constant expression\n   56 |     DAWN_CHECK(false);\n      |     ^\n../../src/dawn/common/Assert.h:115:31: note: expanded from macro \u0027DAWN_CHECK\u0027\n  115 | #define DAWN_CHECK(condition) DAWN_CHECK_CALLSITE_HELPER(__FILE__, __func__, __LINE__, condition)\n      |                               ^\n../../src/dawn/common/Assert.h:65:17: note: expanded from macro \u0027DAWN_CHECK_CALLSITE_HELPER\u0027\n   65 |                 ::dawn::XXXXXXXXXX_CheckFailedInConsteval_XXXXXXXXXX();       \\\n      |                 ^\n../../src/dawn/tests/unittests/TypedIntegerTests.cpp:60:19: note: in call to \u0027f()\u0027\n   60 | constexpr int k \u003d f();\n      |                   ^~~\n../../src/dawn/common/Assert.h:138:13: note: declared here\n  138 | inline void XXXXXXXXXX_CheckFailedInConsteval_XXXXXXXXXX() {}\n      |             ^\n\nBug: 515563577\nChange-Id: I300e1d2c4a39fea65fd2aabcd3a83a02a8d03263\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/310655\nCommit-Queue: Kai Ninomiya \u003ckainino@chromium.org\u003e\nReviewed-by: Antonio Maiorano \u003camaiorano@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "1532c0b1b090824318ac67314e6141bf80bb1d4c",
      "old_mode": 33188,
      "old_path": "src/dawn/common/Assert.h",
      "new_id": "e688d21d817d0f08770825f7002fdc2e7b56451f",
      "new_mode": 33188,
      "new_path": "src/dawn/common/Assert.h"
    }
  ]
}