)]}' { "commit": "fab658d209f09779c7e2f90fb34cebdf7ded681e", "tree": "8508c4eab4d8e3317187de269d19b4ed2afa17c2", "parents": [ "f6de1a7f0fc218536139727e879f95f533652224" ], "author": { "name": "Lokbondo Kung", "email": "lokokung@google.com", "time": "Tue Aug 27 08:34:12 2024 +0000" }, "committer": { "name": "Dawn LUCI CQ", "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Aug 27 08:34:12 2024 +0000" }, "message": "Reland \"[webgpu-headers] Define depthWriteEnabled as WGPUOptionalBool\"\n\nFixes the crash caused via ApplyClearColorValueWithDrawHelper not\nexplicitly setting depthWriteEnabled to false.\n\nThis is a reland of commit 8c230a7cbab3512441955df12fed83bc00c21c13\n\nOriginal change\u0027s description:\n\u003e [webgpu-headers] Define depthWriteEnabled as WGPUOptionalBool\n\u003e\n\u003e The following CLs must be merged before:\n\u003e - https://chromium-review.googlesource.com/c/chromium/src/+/5683307\n\u003e - https://skia-review.googlesource.com/c/skia/+/874238\n\u003e\n\u003e https://github.com/webgpu-native/webgpu-headers/pull/308\n\u003e\n\u003e Bug: 42241167\n\u003e Change-Id: Ib6266b6981fb8caf38b734977ceaeeeed2cf55f9\n\u003e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/197214\n\u003e Reviewed-by: Austin Eng \u003cenga@chromium.org\u003e\n\u003e Commit-Queue: Fr \u003cbeaufort.francois@gmail.com\u003e\n\nBug: 42241167\nChange-Id: I18a1ae28d9df218da25dae57ad64c931e380221e\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/203774\nCommit-Queue: Loko Kung \u003clokokung@google.com\u003e\nReviewed-by: Kai Ninomiya (OOO until 8月23日) \u003ckainino@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "dff8f81dae1065a4e1007edc1dcd77b1bc5b87c0", "old_mode": 33188, "old_path": "generator/dawn_json_generator.py", "new_id": "4932e423dd7c60685a8800999976056f4c544cb5", "new_mode": 33188, "new_path": "generator/dawn_json_generator.py" }, { "type": "modify", "old_id": "3322b6b35a1cbb691b0da17724434efb8129b595", "old_mode": 33188, "old_path": "generator/templates/api.h", "new_id": "6106216eff93895b3c8c0b30310b0cca511d6c59", "new_mode": 33188, "new_path": "generator/templates/api.h" }, { "type": "modify", "old_id": "e88d34a5be41bda9ed85a2bf4eb04f0120e22bab", "old_mode": 33188, "old_path": "generator/templates/api_cpp.h", "new_id": "49315cb0cb502d0304eef7bb39189636ab649e76", "new_mode": 33188, "new_path": "generator/templates/api_cpp.h" }, { "type": "modify", "old_id": "42d03a387c4fba7f674c5aa0c0d6a926925b5bd0", "old_mode": 33188, "old_path": "generator/templates/api_cpp_print.h", "new_id": "4c7c84a2ea09366c2363dab970687f53d6af9e28", "new_mode": 33188, "new_path": "generator/templates/api_cpp_print.h" }, { "type": "modify", "old_id": "95dcddd19fbec44ee12b1cd11ea97700a0ab8d8f", "old_mode": 33188, "old_path": "generator/templates/dawn/native/ValidationUtils.cpp", "new_id": "a7cd252ce75961e124478d5124c7d8bf9e8c8724", "new_mode": 33188, "new_path": "generator/templates/dawn/native/ValidationUtils.cpp" }, { "type": "modify", "old_id": "f0fc7893095577fd59a469c8480de811080756cd", "old_mode": 33188, "old_path": "generator/templates/dawn/native/api_absl_format.cpp", "new_id": "bdac4ade997dcd91637f5288190761b4ca7f08f7", "new_mode": 33188, "new_path": "generator/templates/dawn/native/api_absl_format.cpp" }, { "type": "modify", "old_id": "6f419e8bbf0b76b11ab4dad5f131865b0b3f4005", "old_mode": 33188, "old_path": "src/dawn/common/xlib_with_undefs.h", "new_id": "9fc224206743600fd8c149243503133520d5539a", "new_mode": 33188, "new_path": "src/dawn/common/xlib_with_undefs.h" }, { "type": "modify", "old_id": "ad1b051aaf867899df046a7c46b133dc90270332", "old_mode": 33188, "old_path": "src/dawn/dawn.json", "new_id": "9ab4fbbbfe05460eaa401b0454b95a1d92905bf2", "new_mode": 33188, "new_path": "src/dawn/dawn.json" }, { "type": "modify", "old_id": "0ff2f3f1691855f4b7e1590981e14efeab9c01a1", "old_mode": 33188, "old_path": "src/dawn/native/ApplyClearColorValueWithDrawHelper.cpp", "new_id": "945be8090e032035e51debc737534f66ce19f042", "new_mode": 33188, "new_path": "src/dawn/native/ApplyClearColorValueWithDrawHelper.cpp" }, { "type": "modify", "old_id": "c6bf28a7933e1cf200e510d6d0ca23fcf4dabef1", "old_mode": 33188, "old_path": "src/dawn/native/BlitBufferToDepthStencil.cpp", "new_id": "0ecdc89c59e21541ffd03d4d576599cb3b935abd", "new_mode": 33188, "new_path": "src/dawn/native/BlitBufferToDepthStencil.cpp" }, { "type": "modify", "old_id": "124607b72fca0a9df8eb002dcb3c10a6f0e4f848", "old_mode": 33188, "old_path": "src/dawn/native/BlitColorToColorWithDraw.cpp", "new_id": "14566ce65137dba87c9ba35912893b30d0a8cadd", "new_mode": 33188, "new_path": "src/dawn/native/BlitColorToColorWithDraw.cpp" }, { "type": "modify", "old_id": "79d3da83ae6af8cbc80f81379ab3ca42e27802bb", "old_mode": 33188, "old_path": "src/dawn/native/BlitDepthToDepth.cpp", "new_id": "c2115767300c819419058ab6966b51d1a7ef817c", "new_mode": 33188, "new_path": "src/dawn/native/BlitDepthToDepth.cpp" }, { "type": "modify", "old_id": "813de672799fb34a01db6d7c77d96b670acfeb8e", "old_mode": 33188, "old_path": "src/dawn/native/RenderPipeline.cpp", "new_id": "64d8f4123e2692a4764a4dd429de1d076e5419ea", "new_mode": 33188, "new_path": "src/dawn/native/RenderPipeline.cpp" }, { "type": "modify", "old_id": "91fc84123557cef99933d089669da129f999cdb6", "old_mode": 33188, "old_path": "src/dawn/native/d3d11/RenderPipelineD3D11.cpp", "new_id": "2c86c56edd166230f670ea2939576bcef2136043", "new_mode": 33188, "new_path": "src/dawn/native/d3d11/RenderPipelineD3D11.cpp" }, { "type": "modify", "old_id": "0784d272375f27ae901632fd0f32fc0a8037279f", "old_mode": 33188, "old_path": "src/dawn/native/d3d12/RenderPipelineD3D12.cpp", "new_id": "7d727d5cde4017e69dd25421c36bad301a3a2426", "new_mode": 33188, "new_path": "src/dawn/native/d3d12/RenderPipelineD3D12.cpp" }, { "type": "modify", "old_id": "f0ddef54a16b625ca64e23b1f972b228bbc73a44", "old_mode": 33188, "old_path": "src/dawn/native/metal/RenderPipelineMTL.mm", "new_id": "51356d1f8664ddf435d6e4f77048e4f8947d4fb3", "new_mode": 33188, "new_path": "src/dawn/native/metal/RenderPipelineMTL.mm" }, { "type": "modify", "old_id": "57991a0bc6206f85023ddd1c45b89066b5cdf5ce", "old_mode": 33188, "old_path": "src/dawn/native/opengl/RenderPipelineGL.cpp", "new_id": "cd0387c752af7ba64704dd994e7dbc49039f43d4", "new_mode": 33188, "new_path": "src/dawn/native/opengl/RenderPipelineGL.cpp" }, { "type": "modify", "old_id": "b88fbd8c19f2da4116a10e0c305a0648915587f8", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/RenderPipelineVk.cpp", "new_id": "55860c518dc7d071ed27980218ea23e7c7e5d4a2", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/RenderPipelineVk.cpp" }, { "type": "modify", "old_id": "6f4cf7c3e728a24666c6eceabada6fb0bdc55047", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/ResolveTextureLoadingUtilsVk.cpp", "new_id": "1bc34c7836cdda9bf99a9bd99cd4236623547401", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/ResolveTextureLoadingUtilsVk.cpp" }, { "type": "modify", "old_id": "c3c383d245319cdee934a213969d158f9ec258b8", "old_mode": 33188, "old_path": "src/dawn/node/binding/Converter.cpp", "new_id": "181c42ac560e1ead05bb57e3017c151d4244c105", "new_mode": 33188, "new_path": "src/dawn/node/binding/Converter.cpp" }, { "type": "modify", "old_id": "363d07605a2be508d1e53c83f3725b36ca2cbc99", "old_mode": 33188, "old_path": "src/dawn/node/binding/Converter.h", "new_id": "7eeb76be02a3dec0d6a33e480fdbee41ac4e9aac", "new_mode": 33188, "new_path": "src/dawn/node/binding/Converter.h" }, { "type": "modify", "old_id": "59667311f3d46e39d00a447157ccc12f2845a796", "old_mode": 33188, "old_path": "src/dawn/tests/end2end/DepthBiasTests.cpp", "new_id": "43f817bd31f4e725aebc816e59190cd714819450", "new_mode": 33188, "new_path": "src/dawn/tests/end2end/DepthBiasTests.cpp" }, { "type": "modify", "old_id": "0cae10b5395bd392804ceccfd7f20d9bbedf3a8f", "old_mode": 33188, "old_path": "src/dawn/tests/end2end/DepthStencilCopyTests.cpp", "new_id": "1eb060eb544ba6aff1fffe16b39ece0fb3fc3f78", "new_mode": 33188, "new_path": "src/dawn/tests/end2end/DepthStencilCopyTests.cpp" }, { "type": "modify", "old_id": "0f7835ded6dd3d57520c442b1f59e460f7098f76", "old_mode": 33188, "old_path": "src/dawn/tests/end2end/DepthStencilSamplingTests.cpp", "new_id": "edbe12f435399ce67d008e47b5a8f20b88f1bc9f", "new_mode": 33188, "new_path": "src/dawn/tests/end2end/DepthStencilSamplingTests.cpp" }, { "type": "modify", "old_id": "2071920651ec55faa2f2bb9024491cdd50ed5a4a", "old_mode": 33188, "old_path": "src/dawn/tests/end2end/DepthStencilStateTests.cpp", "new_id": "bca6738810e2b4ec03e3641d49cb8c011d69807a", "new_mode": 33188, "new_path": "src/dawn/tests/end2end/DepthStencilStateTests.cpp" }, { "type": "modify", "old_id": "9af05335cf5c5754e7a16d92553d08420fc6d007", "old_mode": 33188, "old_path": "src/dawn/tests/end2end/FragDepthTests.cpp", "new_id": "fb490b9a4a1d820ccfa2c542099f5f5898e784b2", "new_mode": 33188, "new_path": "src/dawn/tests/end2end/FragDepthTests.cpp" }, { "type": "modify", "old_id": "97ba10878d54a7ecfbcf5340e188a1c53f97c79e", "old_mode": 33188, "old_path": "src/dawn/tests/end2end/MultisampledRenderingTests.cpp", "new_id": "9cdd67e5b9474f552f3b19ce4539b14799bb5413", "new_mode": 33188, "new_path": "src/dawn/tests/end2end/MultisampledRenderingTests.cpp" }, { "type": "modify", "old_id": "39b60b3d52793987dddcde253d70a519820bb471", "old_mode": 33188, "old_path": "src/dawn/tests/end2end/MultisampledSamplingTests.cpp", "new_id": "3c8ca16c547d63ecaa9de540eb698e63d7f06a06", "new_mode": 33188, "new_path": "src/dawn/tests/end2end/MultisampledSamplingTests.cpp" }, { "type": "modify", "old_id": "154bcf23197aaa82b50a9d8d9c39c740bcbb7fc8", "old_mode": 33188, "old_path": "src/dawn/tests/end2end/PrimitiveStateTests.cpp", "new_id": "284c9c17d61a27db931149eadd8caad2941cefee", "new_mode": 33188, "new_path": "src/dawn/tests/end2end/PrimitiveStateTests.cpp" }, { "type": "modify", "old_id": "6b7b53566776b7672aedb12155112d44cb2f60dd", "old_mode": 33188, "old_path": "src/dawn/tests/end2end/ReadOnlyDepthStencilAttachmentTests.cpp", "new_id": "1237c5bf334720608d05d717f52c47ee1f216699", "new_mode": 33188, "new_path": "src/dawn/tests/end2end/ReadOnlyDepthStencilAttachmentTests.cpp" }, { "type": "modify", "old_id": "05974b5ca001673a96086776398edfcddc8b7ab7", "old_mode": 33188, "old_path": "src/dawn/tests/end2end/ShaderTests.cpp", "new_id": "a5309c0c84ea48e4769c741111f95071bb28211d", "new_mode": 33188, "new_path": "src/dawn/tests/end2end/ShaderTests.cpp" }, { "type": "modify", "old_id": "22ebed90656175a9a57d92e6ada7e94147061ea9", "old_mode": 33188, "old_path": "src/dawn/tests/end2end/VertexOnlyRenderPipelineTests.cpp", "new_id": "3118c4dcb9c71b6e90fc24d15596d2c655a61d61", "new_mode": 33188, "new_path": "src/dawn/tests/end2end/VertexOnlyRenderPipelineTests.cpp" }, { "type": "modify", "old_id": "2d6049b3746d6d656f715283e3caf6c659103da5", "old_mode": 33188, "old_path": "src/dawn/tests/end2end/ViewportTests.cpp", "new_id": "11df0696ca6294bfcedb59838c01b594005fca7d", "new_mode": 33188, "new_path": "src/dawn/tests/end2end/ViewportTests.cpp" }, { "type": "modify", "old_id": "48a1cb2cbc9ac5c53d8067f85b3722465d26b953", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/validation/CompatValidationTests.cpp", "new_id": "9280c2b1facbed4fe63db481ffe913c5e93ad037", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/validation/CompatValidationTests.cpp" }, { "type": "modify", "old_id": "32ba3f7ce02db804640f16afcbdf455f85aaf4b4", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/validation/PipelineAndPassCompatibilityTests.cpp", "new_id": "0e361424b61caf13a97b06a4e3f2d95bdd3cc68f", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/validation/PipelineAndPassCompatibilityTests.cpp" }, { "type": "modify", "old_id": "d14f8aca77e0d8deb0d20c0531815f27a64524b7", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/validation/RenderPipelineValidationTests.cpp", "new_id": "439c6a9664f5a8f07e320ba4b93b8d390f9adf7c", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/validation/RenderPipelineValidationTests.cpp" }, { "type": "modify", "old_id": "078e42d1c8db614503c4d8af969e5e8f2f8fe983", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/wire/WireOptionalTests.cpp", "new_id": "159d0c21431db72350022d49de3277487fefd7fd", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/wire/WireOptionalTests.cpp" }, { "type": "modify", "old_id": "3f653d736c49ba9b7cda32d2701a12d017d5e7b3", "old_mode": 33188, "old_path": "src/dawn/utils/ComboRenderPipelineDescriptor.cpp", "new_id": "e181766c402be76c13acc07a24de4dcd83613689", "new_mode": 33188, "new_path": "src/dawn/utils/ComboRenderPipelineDescriptor.cpp" }, { "type": "modify", "old_id": "f98c605200d921015aa692a85e1ccf001032d329", "old_mode": 33188, "old_path": "tools/android/BUILD.gn", "new_id": "f614befa7c2fa9c15f3faea43ae5ba5b6f86eff2", "new_mode": 33188, "new_path": "tools/android/BUILD.gn" }, { "type": "modify", "old_id": "95d6a940472e51720fb03ab13a2f6e8efad5fb51", "old_mode": 33188, "old_path": "tools/android/webgpu/src/test/java/android/dawn/MappedNamedConstantsTest.kt", "new_id": "dd7c38833b7c95bd0439026943f3581917c4c216", "new_mode": 33188, "new_path": "tools/android/webgpu/src/test/java/android/dawn/MappedNamedConstantsTest.kt" } ] }