commit fada50119020483021a6b620c8fb85d62fc3e8f0
author Jiawei Shao <jiawei.shao@intel.com> Fri Jul 31 00:03:43 2020 +0000
committer Commit Bot service account <commit-bot@chromium.org> Fri Jul 31 00:03:43 2020 +0000
tree 3a6d9c75fac055ec995efae9aee088e66eefcfe7
parent f03590a7549289f209e9a7f83fc9d9d135d80d7f

Metal: Add shader compilation error message to DAWN_VALIDATION_ERROR

BUG=dawn:498

Change-Id: I850956a6c57ffe9d77e0729e89da6d9a62076509
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26060
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>

src/dawn_native/metal/ShaderModuleMTL.mm

diff --git a/src/dawn_native/metal/ShaderModuleMTL.mm b/src/dawn_native/metal/ShaderModuleMTL.mm
index bb3dffa..e49cc95 100644
--- a/src/dawn_native/metal/ShaderModuleMTL.mm
+++ b/src/dawn_native/metal/ShaderModuleMTL.mm
@@ -218,11 +218,10 @@
                                                              options:nil
                                                                error:&error];
             if (error != nil) {
-                // TODO(cwallez@chromium.org): Switch that NSLog to use dawn::InfoLog or even be
-                // folded in the DAWN_VALIDATION_ERROR
-                NSLog(@"MTLDevice newLibraryWithSource => %@", error);
                 if (error.code != MTLLibraryErrorCompileWarning) {
-                    return DAWN_VALIDATION_ERROR("Unable to create library object");
+                    const char* errorString = [error.localizedDescription UTF8String];
+                    return DAWN_VALIDATION_ERROR(std::string("Unable to create library object: ") +
+                                                 errorString);
                 }
             }