commit fbf7092ab3b6ee3a4791ff9f6e216a5c31b20019
author Corentin Wallez <cwallez@chromium.org> Thu Apr 11 18:30:54 2019 +0000
committer Commit Bot service account <commit-bot@chromium.org> Thu Apr 11 18:30:54 2019 +0000
tree 769e65de65be98a827bc5547194fe71fe730e18b
parent 9a9b837519953393aa8c76dd4f6df6090fba08c7

PushConstantsTest: Don't use additive blending

One of the test was doing additive blending with a render target that
was uninitialized causing flaky failure. This additive blending was
useful when we had multi-pass render passes but isn't anymore.

BUG=dawn:133

Change-Id: I0aef3dc31e98dbc51c267dc1e481429930162a93
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6540
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>

src/tests/end2end/PushConstantTests.cpp

diff --git a/src/tests/end2end/PushConstantTests.cpp b/src/tests/end2end/PushConstantTests.cpp
index e385a17..0bd371c 100644
--- a/src/tests/end2end/PushConstantTests.cpp
+++ b/src/tests/end2end/PushConstantTests.cpp
@@ -195,13 +195,6 @@
             descriptor.cFragmentStage.module = fsModule;
             descriptor.primitiveTopology = dawn::PrimitiveTopology::PointList;
 
-            dawn::BlendDescriptor blend;
-            blend.operation = dawn::BlendOperation::Add;
-            blend.srcFactor = dawn::BlendFactor::One;
-            blend.dstFactor = dawn::BlendFactor::One;
-            descriptor.cColorStates[0]->alphaBlend = blend;
-            descriptor.cColorStates[0]->colorBlend = blend;
-
             return device.CreateRenderPipeline(&descriptor);
         }
 };