commit fdc365abbc6eb700c52b509fd7c276967d347297
author Stephen White <senorblanco@chromium.org> Sat Jun 08 00:20:41 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat Jun 08 00:20:41 2024 +0000
tree 6f5721228dd2392558d822c2b5ed7ec085428273
parent 74a55189ab5064552d4e3a15373ebf25d2011c6b

OpenGL: tweak end2end test suppressions.

Remove suppression for SamplerFilterAnisotropicTest.SlantedPlaneMipmap, now passing.

Refine suppressions for MaxLimitTests.ReallyLargeBindGroup.

Bug: dawn:648 dawn:590
Change-Id: Ibc47871f8a79b84d679da4dbfed03e6b12e2acd0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/192320
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>

src/dawn/tests/end2end/MaxLimitTests.cpp

diff --git a/src/dawn/tests/end2end/MaxLimitTests.cpp b/src/dawn/tests/end2end/MaxLimitTests.cpp
index 9b54d6c..352b55b 100644
--- a/src/dawn/tests/end2end/MaxLimitTests.cpp
+++ b/src/dawn/tests/end2end/MaxLimitTests.cpp
@@ -553,7 +553,12 @@
     // Remove this suppression once the issue is fixed.
     DAWN_SUPPRESS_TEST_IF(IsVulkan() && IsBackendValidationEnabled());
 
-    DAWN_SUPPRESS_TEST_IF(IsOpenGLES());
+    // TODO(crbug.com/dawn/590): Crashing on ANGLE/D3D11.
+    DAWN_SUPPRESS_TEST_IF(IsANGLED3D11());
+
+    // TODO(crbug.com/dawn/590): Failing on Pixel4
+    DAWN_SUPPRESS_TEST_IF(IsOpenGLES() && IsAndroid() && IsQualcomm());
+
     wgpu::Limits limits = GetSupportedLimits().limits;
 
     std::ostringstream interface;

src/dawn/tests/end2end/SamplerFilterAnisotropicTests.cpp

diff --git a/src/dawn/tests/end2end/SamplerFilterAnisotropicTests.cpp b/src/dawn/tests/end2end/SamplerFilterAnisotropicTests.cpp
index 4302910..352d51d 100644
--- a/src/dawn/tests/end2end/SamplerFilterAnisotropicTests.cpp
+++ b/src/dawn/tests/end2end/SamplerFilterAnisotropicTests.cpp
@@ -294,7 +294,6 @@
     // TODO(crbug.com/dawn/740): Test output is wrong with D3D12 + WARP.
     DAWN_SUPPRESS_TEST_IF(IsD3D12() && IsWARP());
 
-    DAWN_SUPPRESS_TEST_IF(IsOpenGL() || IsOpenGLES());
     const uint16_t maxAnisotropyLists[] = {1, 2, 16, 128};
     for (uint16_t t : maxAnisotropyLists) {
         TestFilterAnisotropic(t);