commit 3d5402c0a4a06f82493ff66752d81af075510fc6
author Jiawei Shao <jiawei.shao@intel.com> Sun Jun 27 05:38:05 2021 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Sun Jun 27 05:38:05 2021 +0000
tree 8eba441fc76f0a6047c9b98a58ee26292d9e9dcf
parent f7cde7e5a416b75927056a8a73ad379b3e04e1d6

OpenGL: Return error when calling writeTexture() on stencil aspect

This patch adds a missing check in QueueGL::WriteTexture() to return
a validation error when we try to call writeTexture() on the stencil
aspect on OpenGL backends as copying from a buffer into a stencil
texture is not supported on OpenGL.

BUG=dawn:439

Change-Id: I203d40aefe346aea663a492c5a065248b74f8ea3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/56002
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>

src/dawn_native/opengl/QueueGL.cpp

diff --git a/src/dawn_native/opengl/QueueGL.cpp b/src/dawn_native/opengl/QueueGL.cpp
index 9a6335e..977f8bf 100644
--- a/src/dawn_native/opengl/QueueGL.cpp
+++ b/src/dawn_native/opengl/QueueGL.cpp
@@ -56,6 +56,10 @@
                                        const void* data,
                                        const TextureDataLayout& dataLayout,
                                        const Extent3D& writeSizePixel) {
+        if (destination.aspect == wgpu::TextureAspect::StencilOnly) {
+            return DAWN_VALIDATION_ERROR("Writes to stencil textures unsupported on OpenGL");
+        }
+
         TextureCopy textureCopy;
         textureCopy.texture = destination.texture;
         textureCopy.mipLevel = destination.mipLevel;