)]}' { "commit": "d05777bd2fdc9e5edd65fc067c76acbedf15eb01", "tree": "c7400e732a927aeef3befd157aa728e79a665b71", "parents": [ "448e3ac4c253dea1e04265274166801675703d7f" ], "author": { "name": "Austin Eng", "email": "enga@chromium.org", "time": "Thu Jul 29 08:06:07 2021 +0000" }, "committer": { "name": "Dawn LUCI CQ", "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jul 29 08:06:07 2021 +0000" }, "message": "Support multisampled depth texture bindings\n\nAdds support for processing texture_depth_multisampled_2d bindings\nreflected from Tint, and also removes Dawn restrictions against\nmultisampled depth. These restrictions were originally added in\nhttps://dawn-review.googlesource.com/c/dawn/+/30240 to validate\nagainst using a multisampled depth texture with a\ncomparison sampler. This is now disallowed by the language with\ndistinct binding types and builtins in WGSL. Previously with\nSPIR-V, we inferred Depth if the texture was used\nwith a comparison sampler.\n\nAlso check Vulkan limits for supported sample counts.\n\nBug: dawn:1021, dawn:1030\nChange-Id: I7233b16c14dc80d10a851cc4e786d5b05512b57a\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/60020\nReviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\nReviewed-by: Jiawei Shao \u003cjiawei.shao@intel.com\u003e\nCommit-Queue: Austin Eng \u003cenga@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "97c6180794a20183ef5b13827e77ff0e7b1be2f7", "old_mode": 33188, "old_path": "src/dawn_native/BindGroupLayout.cpp", "new_id": "e3f808225f3a6b0b98efaa88b280cb346c7d333e", "new_mode": 33188, "new_path": "src/dawn_native/BindGroupLayout.cpp" }, { "type": "modify", "old_id": "cb8704d2e5cac84cbb6da35bbd628e797715a10f", "old_mode": 33188, "old_path": "src/dawn_native/ShaderModule.cpp", "new_id": "2fe2f5ccfb92f09e1375e04a6ed67e3b57b2d73e", "new_mode": 33188, "new_path": "src/dawn_native/ShaderModule.cpp" }, { "type": "modify", "old_id": "6250edba4446ecebc309a70b1c2b80cfb83fc131", "old_mode": 33188, "old_path": "src/dawn_native/vulkan/AdapterVk.cpp", "new_id": "194cc8264d9ea3648182cf0285b434834df3c12f", "new_mode": 33188, "new_path": "src/dawn_native/vulkan/AdapterVk.cpp" }, { "type": "modify", "old_id": "03fe789aef1c7aa46f8587f84721af02998c54eb", "old_mode": 33188, "old_path": "src/tests/end2end/MultisampledSamplingTests.cpp", "new_id": "5ad3e8bb4340b7345c97193dcb3905e03d3e56bd", "new_mode": 33188, "new_path": "src/tests/end2end/MultisampledSamplingTests.cpp" }, { "type": "modify", "old_id": "dab809c4456cc288768e2b15a80daa6785cacd50", "old_mode": 33188, "old_path": "src/tests/unittests/validation/BindGroupValidationTests.cpp", "new_id": "305e2295d14c24290048ce61bce86ae91945f788", "new_mode": 33188, "new_path": "src/tests/unittests/validation/BindGroupValidationTests.cpp" } ] }