)]}' { "commit": "9a8099eb8bee6f7e01435ee9850885560f1d0460", "tree": "5f826b41a2ebe73a7af85af21e00b5359043dcc1", "parents": [ "5497aad24034ff797de11fceffe7882065b756a0" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Fri Oct 08 14:39:39 2021 +0000" }, "committer": { "name": "Dawn LUCI CQ", "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Oct 08 14:39:39 2021 +0000" }, "message": "Fix Wbitwise-instead-of-logical warnings\n\n`a \u0026\u0026 b` only evaluates b if a is true. `a \u0026 b` always evaluates\nboth a and b. If a and b are of type bool, `\u0026\u0026` is usually what you\nwant, so clang now warns on `\u0026` where both arguments are of type bool.\nFrom what I can tell, in Dawn it wasn\u0027t important if we evaluate both\nbranches or not in the places where this fired, so I went with `\u0026\u0026`\neverywhere.\n\nBug: chromium:1255745\nChange-Id: Ifa196a7150d5bdfb8527fe8b6f40d7e2e957d609\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/66200\nAuto-Submit: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "347ef04fde95e35b660ed2eefc75d210ec7a019e", "old_mode": 33188, "old_path": "src/tests/end2end/QueryTests.cpp", "new_id": "20bd3929a4ace9b17d0742b5878f4bb922451f0e", "new_mode": 33188, "new_path": "src/tests/end2end/QueryTests.cpp" } ] }