)]}' { "commit": "b19556e907c5012e6e28906a797f62b197aff965", "tree": "e581afafb186d80f663bdcb8972b27e2a3d2aae2", "parents": [ "bcfa7b12533097ae4fed5f3f8f675c0b4ba44f98" ], "author": { "name": "Loko Kung", "email": "lokokung@google.com", "time": "Fri Oct 29 21:01:54 2021 +0000" }, "committer": { "name": "Dawn LUCI CQ", "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Oct 29 21:01:54 2021 +0000" }, "message": "Revert \"Adds destroy handling for simple objects without new backend changes yet.\"\n\nThis reverts commit 9901c710d1f834fd3e98356f0842553e1ac4afb2.\n\nReason for revert: Breaking dawn roll due to include in ShaderMock\n\nOriginal change\u0027s description:\n\u003e Adds destroy handling for simple objects without new backend changes yet.\n\u003e\n\u003e Simple objects are defined here as objects that do not already have a destroy or destroy-like API available. They include:\n\u003e - BindGroups\n\u003e - ComputePipelines\n\u003e - PipelineLayouts\n\u003e - RenderPipelines\n\u003e - Samplers\n\u003e - ShaderModules\n\u003e - SwapChains\n\u003e\n\u003e Changes include:\n\u003e - Adds necessary constructors for testing and caching\n\u003e - Adding mock objects, mock constructors, and tests\n\u003e\n\u003e Bug: dawn:628\n\u003e Change-Id: I26a5e37bc5580b9064db299a75ef1243521b266a\n\u003e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/65864\n\u003e Commit-Queue: Loko Kung \u003clokokung@google.com\u003e\n\u003e Reviewed-by: Austin Eng \u003cenga@chromium.org\u003e\n\n# Not skipping CQ checks because original CL landed \u003e 1 day ago.\n\nBug: dawn:628\nChange-Id: Ic727106f3dc701dc25418adf9824fbc5397aa656\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/67960\nReviewed-by: Loko Kung \u003clokokung@google.com\u003e\nReviewed-by: Austin Eng \u003cenga@chromium.org\u003e\nCommit-Queue: Loko Kung \u003clokokung@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "874c369c767d7162da60bd0e0a2c3898d0dda7f3", "old_mode": 33188, "old_path": "src/dawn_native/BindGroup.cpp", "new_id": "361ca82618599e6285d1c31f1a5e8a130814fd5e", "new_mode": 33188, "new_path": "src/dawn_native/BindGroup.cpp" }, { "type": "modify", "old_id": "6792d619b94712913d0d903823e6da4d873174e9", "old_mode": 33188, "old_path": "src/dawn_native/BindGroup.h", "new_id": "1ce4b9fe43362bc49492b6eb3b696b9d72fe859c", "new_mode": 33188, "new_path": "src/dawn_native/BindGroup.h" }, { "type": "modify", "old_id": "aea7c40e5485f46800e3397cd35a339328a74f29", "old_mode": 33188, "old_path": "src/dawn_native/BindGroupLayout.cpp", "new_id": "c0097ccd0ddf34b404e3b809ccd35e1ebb9749db", "new_mode": 33188, "new_path": "src/dawn_native/BindGroupLayout.cpp" }, { "type": "modify", "old_id": "1c2c4e3647eedfefdc0a05a52d68714745597c59", "old_mode": 33188, "old_path": "src/dawn_native/BindGroupLayout.h", "new_id": "61b811f990b30d022ecfbc61af0e553d89c2bdee", "new_mode": 33188, "new_path": "src/dawn_native/BindGroupLayout.h" }, { "type": "modify", "old_id": "9eca55c987fc40e470b39b3ec6b2cde4b3769e26", "old_mode": 33188, "old_path": "src/dawn_native/ComputePipeline.cpp", "new_id": "72addc479731f181f634fd7b4008a602b42144ce", "new_mode": 33188, "new_path": "src/dawn_native/ComputePipeline.cpp" }, { "type": "modify", "old_id": "18729237ce616c6d0ca92f0b0a4c7145a64852ac", "old_mode": 33188, "old_path": "src/dawn_native/ComputePipeline.h", "new_id": "6352c1999b9a2903826d298e9190876f23d8a868", "new_mode": 33188, "new_path": "src/dawn_native/ComputePipeline.h" }, { "type": "modify", "old_id": "cf33c02a719c35241a59331bb59cf42141970fd0", "old_mode": 33188, "old_path": "src/dawn_native/Device.cpp", "new_id": "4ba8749b4b415912fc24b9a9b8975c4548035394", "new_mode": 33188, "new_path": "src/dawn_native/Device.cpp" }, { "type": "modify", "old_id": "6d0130229a917080633f77b563bd07ca98f1776e", "old_mode": 33188, "old_path": "src/dawn_native/Device.h", "new_id": "7852c6afe73d2bbfa68e0945cde2e75a6c73bb3b", "new_mode": 33188, "new_path": "src/dawn_native/Device.h" }, { "type": "modify", "old_id": "291e806613d01b22a135c59ad1bd2469cad8bb55", "old_mode": 33188, "old_path": "src/dawn_native/ObjectBase.h", "new_id": "d05a56e0e676a4e069c215e70e069c47b0ee0793", "new_mode": 33188, "new_path": "src/dawn_native/ObjectBase.h" }, { "type": "modify", "old_id": "bb846fdb152ec07a6c9cf0d474c37298df4ec454", "old_mode": 33188, "old_path": "src/dawn_native/Pipeline.cpp", "new_id": "ab232c356691459b5eeae0f5114c353fde2a3679", "new_mode": 33188, "new_path": "src/dawn_native/Pipeline.cpp" }, { "type": "modify", "old_id": "7a1e09a5951cc16017cd13ccf492303feef3d932", "old_mode": 33188, "old_path": "src/dawn_native/Pipeline.h", "new_id": "74442930b43d85a997504cd0b3ca371ad64d05ef", "new_mode": 33188, "new_path": "src/dawn_native/Pipeline.h" }, { "type": "modify", "old_id": "eb23756465dc33ea4dfec72306a200d1294d8fe1", "old_mode": 33188, "old_path": "src/dawn_native/PipelineLayout.cpp", "new_id": "9b1b707b69c49ae0e57c7fff29baff0ed91f6923", "new_mode": 33188, "new_path": "src/dawn_native/PipelineLayout.cpp" }, { "type": "modify", "old_id": "597de4588668a98a69d471a16eef3b7c3fc35deb", "old_mode": 33188, "old_path": "src/dawn_native/PipelineLayout.h", "new_id": "7371dab46df418a36c3c0cf162d0052f8cafb825", "new_mode": 33188, "new_path": "src/dawn_native/PipelineLayout.h" }, { "type": "modify", "old_id": "d1305132a2402c25858711e1315407ef847ad2ee", "old_mode": 33188, "old_path": "src/dawn_native/RenderPipeline.cpp", "new_id": "1c16bbad6c9077b7500b2870f6086e45c14593f1", "new_mode": 33188, "new_path": "src/dawn_native/RenderPipeline.cpp" }, { "type": "modify", "old_id": "b69b6ed712160c119f5df1e99afcb6343ebb3b28", "old_mode": 33188, "old_path": "src/dawn_native/RenderPipeline.h", "new_id": "bd354ab5de2edb3dd209f7a9c548c2ab93d8791f", "new_mode": 33188, "new_path": "src/dawn_native/RenderPipeline.h" }, { "type": "modify", "old_id": "94c26dde53db35f94b38f2b17ad9e48cec2ca1e5", "old_mode": 33188, "old_path": "src/dawn_native/Sampler.cpp", "new_id": "ec3266c50cbb64b9aca4211d6757aa50c7fb20e0", "new_mode": 33188, "new_path": "src/dawn_native/Sampler.cpp" }, { "type": "modify", "old_id": "6d9e945bb281244e8e5c5449e2981032e008afb8", "old_mode": 33188, "old_path": "src/dawn_native/Sampler.h", "new_id": "3e7d1fbae485ff4eaa033ef88ba42be6ab339002", "new_mode": 33188, "new_path": "src/dawn_native/Sampler.h" }, { "type": "modify", "old_id": "3a8c26ca761323e37de87f95ebacfd6d1652f4e8", "old_mode": 33188, "old_path": "src/dawn_native/ShaderModule.cpp", "new_id": "058f886e48f2e3d85ef6decb0e2b002d2dfc2804", "new_mode": 33188, "new_path": "src/dawn_native/ShaderModule.cpp" }, { "type": "modify", "old_id": "30f32946bbfec0c04708fd57a051089eb47e11ae", "old_mode": 33188, "old_path": "src/dawn_native/ShaderModule.h", "new_id": "09bede54cdb9ec3b8a87c5165572159f2e709d7e", "new_mode": 33188, "new_path": "src/dawn_native/ShaderModule.h" }, { "type": "modify", "old_id": "26617b1a5153e5dbcb08618783cec388330cf153", "old_mode": 33188, "old_path": "src/dawn_native/SwapChain.cpp", "new_id": "7bba116c1091fc44fe9e7a8b35068b8313168512", "new_mode": 33188, "new_path": "src/dawn_native/SwapChain.cpp" }, { "type": "modify", "old_id": "8ffd9215241a0a670091503ced590c42360ace41", "old_mode": 33188, "old_path": "src/tests/BUILD.gn", "new_id": "37b6a5997da83edaf74bc06bad7e35ba210dd57b", "new_mode": 33188, "new_path": "src/tests/BUILD.gn" }, { "type": "modify", "old_id": "a82a7f4aa93331e91fb74851adbb44a9d7e89895", "old_mode": 33188, "old_path": "src/tests/unittests/native/DestroyObjectTests.cpp", "new_id": "6e9c2835a34a0b24c47091628849ee3f5fb80daf", "new_mode": 33188, "new_path": "src/tests/unittests/native/DestroyObjectTests.cpp" }, { "type": "delete", "old_id": "e36dc8457cadc8c19b137b433ac46833d252c7e6", "old_mode": 33188, "old_path": "src/tests/unittests/native/mocks/BindGroupMock.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "6289b56a084865449caf3ed2e5cbf32626863e11", "old_mode": 33188, "old_path": "src/tests/unittests/native/mocks/ComputePipelineMock.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "4b9201a2cf14efc6ff8a185563d86028774e2e06", "old_mode": 33188, "old_path": "src/tests/unittests/native/mocks/PipelineLayoutMock.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "fa82ab5d1ed4c564f0ea22327521c1c6607540d9", "old_mode": 33188, "old_path": "src/tests/unittests/native/mocks/RenderPipelineMock.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "ca9a6b00e8f3c77c4b98bfd51828e5e7c1ea6270", "old_mode": 33188, "old_path": "src/tests/unittests/native/mocks/SamplerMock.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "4d0f0f2d201456ef8faf03e8d21911d59f1e3388", "old_mode": 33188, "old_path": "src/tests/unittests/native/mocks/ShaderModuleMock.cpp", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "ebe2357c6e8e61a3dd7dea30aeea782b690fa101", "old_mode": 33188, "old_path": "src/tests/unittests/native/mocks/ShaderModuleMock.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "cee332b44589fa771d81ac489c07b1faf6ac5fda", "old_mode": 33188, "old_path": "src/tests/unittests/native/mocks/SwapChainMock.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" } ] }