)]}' { "commit": "6abf1a1adb8a20523267f39f4c619a139f9a152f", "tree": "a98a38fad7bb1c74f0ea5b8d9fde7a831ffc5987", "parents": [ "d4b9cda0561c768db4c00b72d991525a70536d2d" ], "author": { "name": "Austin Eng", "email": "enga@chromium.org", "time": "Tue Nov 02 18:23:49 2021 +0000" }, "committer": { "name": "Dawn LUCI CQ", "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Nov 02 18:23:49 2021 +0000" }, "message": "Remove deferred BufferLocation updates for drawIndexedIndirect\n\nInstead of using BufferLocation as another layer of indirection,\nthe indirectBuffer can be set directly on the indirect command.\nThis makes the indirect validation a bit simpler, but introduces\nadditional lifetime dependencies in that the indirect draw validation\nMUST be encoded while the DrawIndexedIndirectCmds it references\nare still valid.\n\nBug: dawn:809\nChange-Id: I1ef084622d8737ad5ec1b0247bf9062712e35008\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/67241\nCommit-Queue: Austin Eng \u003cenga@chromium.org\u003e\nReviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "979c7c4dc74e0bd9d5db6936a57129feb5f3a2a8", "old_mode": 33188, "old_path": "src/dawn_native/BUILD.gn", "new_id": "cfea7074d713b58dc1d0f2965bc9967b3e12b6e5", "new_mode": 33188, "new_path": "src/dawn_native/BUILD.gn" }, { "type": "delete", "old_id": "5ee24f2ff8b361d0a6a3f08adaa0b6021a1eac8a", "old_mode": 33188, "old_path": "src/dawn_native/BufferLocation.cpp", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "4ff733d97243e512c0b10bd03f90bde37c41532e", "old_mode": 33188, "old_path": "src/dawn_native/BufferLocation.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "6b90e2cdc56e2e3d0c14811fd19a75c1dbf79811", "old_mode": 33188, "old_path": "src/dawn_native/CMakeLists.txt", "new_id": "2c2ead49d63978135071fb8097a7b68c3c6abf73", "new_mode": 33188, "new_path": "src/dawn_native/CMakeLists.txt" }, { "type": "modify", "old_id": "a964f40bec9a649240236465416e630c6f0d05bd", "old_mode": 33188, "old_path": "src/dawn_native/CommandBuffer.cpp", "new_id": "3fadb1a08a666be426180ac6667d6ced9a09dceb", "new_mode": 33188, "new_path": "src/dawn_native/CommandBuffer.cpp" }, { "type": "modify", "old_id": "c6d47ae24cb250a11e4728ff69c21939b1f40903", "old_mode": 33188, "old_path": "src/dawn_native/CommandBuffer.h", "new_id": "023208bca47ab50d45aa64013e797a7d986bd40b", "new_mode": 33188, "new_path": "src/dawn_native/CommandBuffer.h" }, { "type": "modify", "old_id": "c9510d0327370cc58693be5267389a31b4c3f1dc", "old_mode": 33188, "old_path": "src/dawn_native/CommandEncoder.cpp", "new_id": "153ef7b721451182c7be811cd234b254779b9c68", "new_mode": 33188, "new_path": "src/dawn_native/CommandEncoder.cpp" }, { "type": "modify", "old_id": "6547e7d936b161bf5081e4cfe92a116c46255875", "old_mode": 33188, "old_path": "src/dawn_native/CommandEncoder.h", "new_id": "d390d70c2c2da6d349dd9c26093c9db0f9472e89", "new_mode": 33188, "new_path": "src/dawn_native/CommandEncoder.h" }, { "type": "modify", "old_id": "ea122e7468c73d2c3cb007edf4ef572e9543e939", "old_mode": 33188, "old_path": "src/dawn_native/Commands.cpp", "new_id": "c2bd0dde6db962effe8ef221a0ec667ebc6430d4", "new_mode": 33188, "new_path": "src/dawn_native/Commands.cpp" }, { "type": "modify", "old_id": "09acd10abffcc77a276160d8527d23f967d1c5cb", "old_mode": 33188, "old_path": "src/dawn_native/Commands.h", "new_id": "cee9bbd52eeea7d28ab02c3be0b24734abd43c4d", "new_mode": 33188, "new_path": "src/dawn_native/Commands.h" }, { "type": "modify", "old_id": "e150d78a19a9c5841e74e1bafd9b52f9a4f70583", "old_mode": 33188, "old_path": "src/dawn_native/IndirectDrawMetadata.cpp", "new_id": "9d514f33df23559825a2a11279124e9bc99e7730", "new_mode": 33188, "new_path": "src/dawn_native/IndirectDrawMetadata.cpp" }, { "type": "modify", "old_id": "f55f3d317b3833130a692d5524df348382104b00", "old_mode": 33188, "old_path": "src/dawn_native/IndirectDrawMetadata.h", "new_id": "e6527502b3a8d1210dad3405e8b196eab97f6771", "new_mode": 33188, "new_path": "src/dawn_native/IndirectDrawMetadata.h" }, { "type": "modify", "old_id": "1eba1ba3121449d57467ebbd73a73b580730cddb", "old_mode": 33188, "old_path": "src/dawn_native/IndirectDrawValidationEncoder.cpp", "new_id": "02cef8e12cdf62fe65e71d12594ed2f21975118b", "new_mode": 33188, "new_path": "src/dawn_native/IndirectDrawValidationEncoder.cpp" }, { "type": "modify", "old_id": "a8ef2ffbf1dc44a74d0b3f47f64563f77ab88870", "old_mode": 33188, "old_path": "src/dawn_native/RenderEncoderBase.cpp", "new_id": "f2a8dce2ffa8a98ccfaa2e6d89732cd03ec04bb2", "new_mode": 33188, "new_path": "src/dawn_native/RenderEncoderBase.cpp" }, { "type": "modify", "old_id": "e7d12a51a8ffac6a6f72995f72d1a30ab09cfe08", "old_mode": 33188, "old_path": "src/dawn_native/d3d12/CommandBufferD3D12.cpp", "new_id": "445c7810b1c752a496f270da60d0855d13f36425", "new_mode": 33188, "new_path": "src/dawn_native/d3d12/CommandBufferD3D12.cpp" }, { "type": "modify", "old_id": "cacefa03d574b1b8081ec961c214df76323b0a3e", "old_mode": 33188, "old_path": "src/dawn_native/metal/CommandBufferMTL.mm", "new_id": "f1be722b451fd51eff796c319fde587781b5d673", "new_mode": 33188, "new_path": "src/dawn_native/metal/CommandBufferMTL.mm" }, { "type": "modify", "old_id": "b34935a0c3f55177bb2c5a3481dc6d56c6af0351", "old_mode": 33188, "old_path": "src/dawn_native/opengl/CommandBufferGL.cpp", "new_id": "f6b80ab9648c270df00dae60db8f414283d399c2", "new_mode": 33188, "new_path": "src/dawn_native/opengl/CommandBufferGL.cpp" }, { "type": "modify", "old_id": "30fd55e799c7fd29a270c6af71cbbd23bba5b391", "old_mode": 33188, "old_path": "src/dawn_native/vulkan/CommandBufferVk.cpp", "new_id": "cfcdb36c74778220706771c5328b653d96879607", "new_mode": 33188, "new_path": "src/dawn_native/vulkan/CommandBufferVk.cpp" } ] }