commit 8ce15b3ce97efbb175ba67ae1df9a10cdc3ea4af
author Jiawei Shao <jiawei.shao@intel.com> Wed Nov 17 00:31:38 2021 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Nov 17 00:31:38 2021 +0000
tree bce5c7f766055edbb1f97cda83b76eb80bca0e3c
parent ca646ab4fb1e356daa012cc76812c1b73c569ba8

Fix a bug in the generation of expected data in CopyTests

This patch fixes a bug in the generation of expected data in CopyTests.
In function GetExpectedTextureData() we intend to initialize every byte
of the expected texture data, so we need to calculate the index of the
expected texture data with "bytesPerRow" instead of "texelBlocksPerRow".

BUG=chromium:1161355
TEST=dawn_end2end_tests

Change-Id: I05bcab629fc961c7425c10fcd534c451af199712
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/69600
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>

src/tests/end2end/CopyTests.cpp

diff --git a/src/tests/end2end/CopyTests.cpp b/src/tests/end2end/CopyTests.cpp
index c33ef20..4456f6f 100644
--- a/src/tests/end2end/CopyTests.cpp
+++ b/src/tests/end2end/CopyTests.cpp
@@ -50,7 +50,7 @@
             const uint32_t byteOffsetPerSlice = layout.bytesPerImage * layer;
             for (uint32_t y = 0; y < layout.mipSize.height; ++y) {
                 for (uint32_t x = 0; x < layout.mipSize.width * bytesPerTexelBlock; ++x) {
-                    uint32_t i = x + y * layout.texelBlocksPerRow;
+                    uint32_t i = x + y * layout.bytesPerRow;
                     textureData[byteOffsetPerSlice + i] =
                         static_cast<uint8_t>((x + 1 + (layer + 1) * y) % 256);
                 }