)]}'
{
  "commit": "c6be53e172b0bf035f33d8ec51ed3924a769e080",
  "tree": "91953b1ea71702622c97f394bf7eac2b701196f0",
  "parents": [
    "8661cb07ab4f81b91b42b7cb1f1e3d070d926e99"
  ],
  "author": {
    "name": "Brandon Jones",
    "email": "bajones@chromium.org",
    "time": "Mon Apr 18 17:35:53 2022 +0000"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Mon Apr 18 17:35:53 2022 +0000"
  },
  "message": "Revert \"Enable gn check for all build targets.\"\n\nThis reverts commit 61bc38fd52161ce7c0722a966eb4d66315b07cc1.\n\nReason for revert: Appears to have broken the Dawn-\u003eChromium autoroller, which is now seeing Abseil linking issues on Mac and Linux.\n\nExample failing roll: https://chromium-review.googlesource.com/c/chromium/src/+/3590451/\n\nExample error log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8816532799903001889/+/u/compile__with_patch_/stdout\n\nLog Excerpt:\n[802/31819] LINK ./dawn_unittests\nFAILED: dawn_unittests \nTOOL_VERSION\u003d1650247560 ../../build/toolchain/apple/linker_driver.py -Wcrl,strippath,../../build/mac_files/xcode_binaries/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip -Wcrl,installnametoolpath,../../build/mac_files/xcode_binaries/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool ../../third_party/llvm-build/Release+Asserts/bin/clang++  -Werror -fuse-ld\u003dlld -Wl,-fatal_warnings -Wl,--color-diagnostics -arch x86_64 -no-canonical-prefixes -Wl,-dead_strip -nostdlib++ -isysroot ../../build/mac_files/xcode_binaries/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk -mmacosx-version-min\u003d10.11.0 -fprofile-instr-generate -Wl,-ObjC -rpath @executable_path/ -o \"./dawn_unittests\" \"@./dawn_unittests.rsp\"\nld64.lld: error: duplicate symbol: __ZN4absl15AsciiStrToLowerEPNSt3__112basic_stringIcNS0_11char_traitsIcEENS0_9allocatorIcEEEE\n\u003e\u003e\u003e defined in obj/third_party/dawn/third_party/gn/abseil-cpp/strings/ascii.o\n\u003e\u003e\u003e defined in obj/third_party/abseil-cpp/absl/strings/strings/ascii.o\n\nld64.lld: error: duplicate symbol: __ZN4absl15AsciiStrToUpperEPNSt3__112basic_stringIcNS0_11char_traitsIcEENS0_9allocatorIcEEEE\n\u003e\u003e\u003e defined in obj/third_party/dawn/third_party/gn/abseil-cpp/strings/ascii.o\n\u003e\u003e\u003e defined in obj/third_party/abseil-cpp/absl/strings/strings/ascii.o\n\nld64.lld: error: duplicate symbol: __ZN4absl26RemoveExtraAsciiWhitespaceEPNSt3__112basic_stringIcNS0_11char_traitsIcEENS0_9allocatorIcEEEE\n\u003e\u003e\u003e defined in obj/third_party/dawn/third_party/gn/abseil-cpp/strings/ascii.o\n\u003e\u003e\u003e defined in obj/third_party/abseil-cpp/absl/strings/strings/ascii.o\n\nOriginal change\u0027s description:\n\u003e Enable gn check for all build targets.\n\u003e\n\u003e This CL removes the `check_targets` entry from the .gn file which\n\u003e will enable checking all targets. Two of the GN targets have had\n\u003e missing dependencies added.\n\u003e\n\u003e The `gn/abseil-cpp/BUILD.gn` was referenced against the Chromium\n\u003e BUILD.gn for abseil to make sure the `public_deps` and `deps`\n\u003e match in the two versions. The paths are re-written to match\n\u003e the Dawn paths.\n\u003e\n\u003e Bug: dawn:1372\n\u003e Change-Id: I371e17ec9647e6627429be5c81eb7985da3cc5b3\n\u003e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86861\n\u003e Auto-Submit: Dan Sinclair \u003cdsinclair@chromium.org\u003e\n\u003e Kokoro: Kokoro \u003cnoreply+kokoro@google.com\u003e\n\u003e Reviewed-by: Brandon Jones \u003cbajones@chromium.org\u003e\n\u003e Reviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\n\u003e Commit-Queue: Corentin Wallez \u003ccwallez@chromium.org\u003e\n\n# Not skipping CQ checks because original CL landed \u003e 1 day ago.\n\nBug: dawn:1372\nChange-Id: I1ce6d62138cd99aa3a75c74eea0ac04ce5048b6b\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87161\nReviewed-by: Brandon Jones \u003cbajones@chromium.org\u003e\nAuto-Submit: Brandon Jones \u003cbajones@chromium.org\u003e\nReviewed-by: Shrek Shao \u003cshrekshao@google.com\u003e\nKokoro: Kokoro \u003cnoreply+kokoro@google.com\u003e\nReviewed-by: Austin Eng \u003cenga@chromium.org\u003e\nCommit-Queue: Austin Eng \u003cenga@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "09e3d24a92c007760280c43c8c580e1f58118eaa",
      "old_mode": 33188,
      "old_path": ".gn",
      "new_id": "38604408470d71c2071b2dadcee56b9f0a59a4fb",
      "new_mode": 33188,
      "new_path": ".gn"
    },
    {
      "type": "modify",
      "old_id": "58874cf623e39ced7b9531d1adba592ac08ae029",
      "old_mode": 33188,
      "old_path": "src/dawn/samples/BUILD.gn",
      "new_id": "26067fed2cc96f34fc92a7ca40afb95b8fc00142",
      "new_mode": 33188,
      "new_path": "src/dawn/samples/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "052ab07de1da7645a223d338036117a762b948d3",
      "old_mode": 33188,
      "old_path": "src/dawn/tests/BUILD.gn",
      "new_id": "0fee0dd776a1e6f99e5ea83881b044d94e8d6b83",
      "new_mode": 33188,
      "new_path": "src/dawn/tests/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "4561dfda439aef65feb6f0ad0791578abf73de0d",
      "old_mode": 33188,
      "old_path": "third_party/gn/abseil-cpp/BUILD.gn",
      "new_id": "6b4017e894640f0434956b77605cbace6a40b098",
      "new_mode": 33188,
      "new_path": "third_party/gn/abseil-cpp/BUILD.gn"
    }
  ]
}