)]}' { "commit": "d42a809e8c7411f665041e83403018127bce111c", "tree": "0c46c077c43f4e1c89a9f02beef44d64586c2967", "parents": [ "a09b0dbd8319c9b18b97ab6263f307bf76c6b6ac" ], "author": { "name": "Takahiro", "email": "hogehoge@gachapin.jp", "time": "Thu May 26 01:26:34 2022 +0000" }, "committer": { "name": "Dawn LUCI CQ", "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu May 26 01:26:34 2022 +0000" }, "message": "Record zero-attribute vertex buffer when creating render pipeline\n\nCurrently Dawn ignores all zero-attribute vertex buffer in the given\npipeline descriptor when creating RenderPipelineBase because\nzero-attribute vertex buffer is treated as unused slot, however the spec\ndoesn\u0027t state that zero-attribute vertex buffer should be ignored.\n\nTo support zero-attribute vertex buffer, this commit has the following\nchanges.\n\n1. Add VertexBufferNotUsed enum value to wgpu::VertexStepMode to\n represent unused slots\n2. Ignore VertexBufferNotUsed step mode buffers when creating\n RenderPipelineBase and add tests to check it\n3. Record zero-attribute vertex buffers when creating RenderPipelineBase\n and add tests to check it\n4. Fix VertexStateTest::LastAllowedVertexBuffer broken by the above\n changes\n\nTemporarily we set the enum value of\nwgpu::VertexStepMode::VertexBufferNotUsed to 0 to pass the CTS tests\nbecause currently empty vertex buffer slots step mode can be\nzero-initialized. We will make a CL to Blink to explicitly set\nwgpu::VertexStepMode::VertexBufferNotUsed for empty slots and change\nthe enum value to 2.\n\nBug: dawn:1000\nChange-Id: Ibd4ab87f2c922e8e460f2311547f13d58f1d5611\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89340\nReviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\nKokoro: Kokoro \u003cnoreply+kokoro@google.com\u003e\nCommit-Queue: Takahiro \u003chogehoge@gachapin.jp\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "2b417fbd3b3b130ff66712d95395e61c6dda5f69", "old_mode": 33188, "old_path": "dawn.json", "new_id": "f7fe018c17a6d97b7eb0b3284e6e8d63a1119c2f", "new_mode": 33188, "new_path": "dawn.json" }, { "type": "modify", "old_id": "75f642063419ad3634c68e95e65c05630c0a71c3", "old_mode": 33188, "old_path": "src/dawn/native/RenderPipeline.cpp", "new_id": "3ec6bdcd3ec1bf191475f4421a66aa8f93166f1a", "new_mode": 33188, "new_path": "src/dawn/native/RenderPipeline.cpp" }, { "type": "modify", "old_id": "43fb89e017a498c8ae526b9340d419158a2592f3", "old_mode": 33188, "old_path": "src/dawn/native/ShaderModule.cpp", "new_id": "21edca997faa9f8320d9951d44d1b383cc066ae6", "new_mode": 33188, "new_path": "src/dawn/native/ShaderModule.cpp" }, { "type": "modify", "old_id": "9f513cf76d44c78de69cf183056313d336fbc420", "old_mode": 33188, "old_path": "src/dawn/native/d3d12/RenderPipelineD3D12.cpp", "new_id": "8980b30a81b1e4c6eb4cf796c3fb3630488a19e6", "new_mode": 33188, "new_path": "src/dawn/native/d3d12/RenderPipelineD3D12.cpp" }, { "type": "modify", "old_id": "89548aec86c3626f880bf5db88ea74f946e615c9", "old_mode": 33188, "old_path": "src/dawn/native/metal/RenderPipelineMTL.mm", "new_id": "6e5afd54fe0cc659421ae27ef73ca3c08b81bdc1", "new_mode": 33188, "new_path": "src/dawn/native/metal/RenderPipelineMTL.mm" }, { "type": "modify", "old_id": "6f93260e3b9f2f95ae955e0526cf1200dad1357e", "old_mode": 33188, "old_path": "src/dawn/native/opengl/RenderPipelineGL.cpp", "new_id": "54b6ffba668206354d2bf415d2eea39704e35406", "new_mode": 33188, "new_path": "src/dawn/native/opengl/RenderPipelineGL.cpp" }, { "type": "modify", "old_id": "8a808a14142c9bf445e019a76f46d155e7ef6ec1", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/RenderPipelineVk.cpp", "new_id": "47c3c8507694ef00cb5f2fc515fe4b9b88ca520a", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/RenderPipelineVk.cpp" }, { "type": "modify", "old_id": "2089cd62505387916ba42a479f503d578fc12226", "old_mode": 33188, "old_path": "src/dawn/tests/end2end/VertexStateTests.cpp", "new_id": "aea465d227808242b9b74b981f57d66d1efa1d55", "new_mode": 33188, "new_path": "src/dawn/tests/end2end/VertexStateTests.cpp" }, { "type": "modify", "old_id": "fa66bbaeec6909df74ed98f0fe1334d578e5b054", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/validation/DrawVertexAndIndexBufferOOBValidationTests.cpp", "new_id": "4b91c27f2f45d78f70860c9c61bb214179641f18", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/validation/DrawVertexAndIndexBufferOOBValidationTests.cpp" } ] }