)]}' { "commit": "2b4df7889186d2e98e437a2d1bb3e083b4722edb", "tree": "7620235a49674b2cda20db194f160268ccd0eeda", "parents": [ "368f95a078eeadc547a3b3d1d0a55847130f3404" ], "author": { "name": "Ben Clayton", "email": "bclayton@google.com", "time": "Wed Jun 29 11:31:41 2022 +0000" }, "committer": { "name": "Dawn LUCI CQ", "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jun 29 11:31:41 2022 +0000" }, "message": "tint/number: Fix CheckedConvert() logic\n\nThis function was attempting to pick a higher-precision type by using\nthe decltype() of FROM + TO. This doesn\u0027t work if FROM and TO are both\nsimilar bit-widths, and of a different signness, as the picked type may\nnot be wide enough to hold both the signed and unsigned representation.\n\nJust use AInt or AFloat (both 64-bit), which are the largest types\nsupported by WGSL.\n\nChange-Id: Ic76475d98bad8def12a0283a1c83c62f2ed58b5d\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95041\nKokoro: Kokoro \u003cnoreply+kokoro@google.com\u003e\nCommit-Queue: Ben Clayton \u003cbclayton@google.com\u003e\nReviewed-by: dan sinclair \u003cdsinclair@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "7f0c2f1005b617028ac5d277b112017b48850c18", "old_mode": 33188, "old_path": "src/tint/number.h", "new_id": "4e3e6fd3179be4eae3dcdd527cdf58342d206830", "new_mode": 33188, "new_path": "src/tint/number.h" }, { "type": "modify", "old_id": "52ba4aea3e8f5f22f8322c6492aecde99b9973f7", "old_mode": 33188, "old_path": "src/tint/number_test.cc", "new_id": "6a48f9d7ebb1e041c1fe737014f3282e149b8e5e", "new_mode": 33188, "new_path": "src/tint/number_test.cc" } ] }