)]}'
{
  "commit": "79781f26d1fc525fb9c3ba291e5660ea3da6eeb1",
  "tree": "b214cf8132c1f7d31524e36683149f472f7ba988",
  "parents": [
    "28ec26b6783932de76fcd052340f4a73000b16ce"
  ],
  "author": {
    "name": "Ben Clayton",
    "email": "bclayton@google.com",
    "time": "Sat Feb 18 17:13:18 2023 +0000"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Sat Feb 18 17:13:18 2023 +0000"
  },
  "message": "tint: Unkeyword \u0027var\u0027 template args\n\nChange the address space and access mode in ast::Var from enums\nto Expressions. Have the resolver resolve these, like we do for\nother template arguments.\n\nAs the AST nodes now have identifier expressions, the tint-internal\n\u0027in\u0027 and \u0027out\u0027 address spaces have been prefixed with underscores to\nprevent input code from using this.\n\nChange-Id: Ie8abf371ee6a7031613709b83b575d2723418fcf\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/120405\nKokoro: Kokoro \u003cnoreply+kokoro@google.com\u003e\nReviewed-by: Dan Sinclair \u003cdsinclair@chromium.org\u003e\nCommit-Queue: Dan Sinclair \u003cdsinclair@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "dd679c7f0278ddf8eea8960768c408b2f6e67ce0",
      "old_mode": 33188,
      "old_path": "src/tint/BUILD.gn",
      "new_id": "fbed83aca3619f61e8c76f2c18bfa8aa0b2d20c8",
      "new_mode": 33188,
      "new_path": "src/tint/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "67ca5e9087f40306e3ae18b6960f05a2c251660d",
      "old_mode": 33188,
      "old_path": "src/tint/CMakeLists.txt",
      "new_id": "4b87d7b4a88f10f5891f98e05aa78b3961c3c56a",
      "new_mode": 33188,
      "new_path": "src/tint/CMakeLists.txt"
    },
    {
      "type": "modify",
      "old_id": "b748381470961b2947a64997ef50d4b05d3b7ce2",
      "old_mode": 33188,
      "old_path": "src/tint/ast/var.cc",
      "new_id": "bccdbccfadc7963ed86e3738f56e5f3fb299a7a0",
      "new_mode": 33188,
      "new_path": "src/tint/ast/var.cc"
    },
    {
      "type": "modify",
      "old_id": "e3537d1e32c280c1de2665abdb1af863db7a3131",
      "old_mode": 33188,
      "old_path": "src/tint/ast/var.h",
      "new_id": "006d8de385062c41baf7ac9106150a1dcb2a3f38",
      "new_mode": 33188,
      "new_path": "src/tint/ast/var.h"
    },
    {
      "type": "modify",
      "old_id": "88bcdc46a5b27a62f249ebadad79a8d604fd9942",
      "old_mode": 33188,
      "old_path": "src/tint/ast/variable_test.cc",
      "new_id": "dcbf1e5a2465adc055f5b8c4e1e9d21d02e41eff",
      "new_mode": 33188,
      "new_path": "src/tint/ast/variable_test.cc"
    },
    {
      "type": "modify",
      "old_id": "ee280106d9156b981f19d286e9ca8271c19de43e",
      "old_mode": 33188,
      "old_path": "src/tint/intrinsics.def",
      "new_id": "f55b12cd6e4cddd146be9977386674e362bb2228",
      "new_mode": 33188,
      "new_path": "src/tint/intrinsics.def"
    },
    {
      "type": "modify",
      "old_id": "1c04faf85cef11fe3e462910ee6ae9a87c8e8a6c",
      "old_mode": 33188,
      "old_path": "src/tint/program_builder.h",
      "new_id": "f89a30baeee49a7e304f73a4acd54b4c548ebe23",
      "new_mode": 33188,
      "new_path": "src/tint/program_builder.h"
    },
    {
      "type": "modify",
      "old_id": "046780fec1724f7e03a0f0518a19c5170aa5f77f",
      "old_mode": 33188,
      "old_path": "src/tint/reader/spirv/function.cc",
      "new_id": "513b7f3a810df50b667df3eae8cf79a231d6b467",
      "new_mode": 33188,
      "new_path": "src/tint/reader/spirv/function.cc"
    },
    {
      "type": "modify",
      "old_id": "5707bf14e688f74e8a67b304f588a473e0956084",
      "old_mode": 33188,
      "old_path": "src/tint/reader/spirv/parser_impl.cc",
      "new_id": "443b28f357e4702f5c5f6412b826dbc01a021004",
      "new_mode": 33188,
      "new_path": "src/tint/reader/spirv/parser_impl.cc"
    },
    {
      "type": "modify",
      "old_id": "5d6daa4380ce3df083b191e8ed604a92efda12e0",
      "old_mode": 33188,
      "old_path": "src/tint/reader/spirv/parser_impl.h",
      "new_id": "0c77a028497bbbe69812aabb9eb2ed2210ceabcc",
      "new_mode": 33188,
      "new_path": "src/tint/reader/spirv/parser_impl.h"
    },
    {
      "type": "modify",
      "old_id": "0ccef952e3ae8e3787c1f57521e63fb0ba398075",
      "old_mode": 33188,
      "old_path": "src/tint/reader/wgsl/classify_template_args.cc",
      "new_id": "79d39d22289c30ff5842714ecabec8c0e55e1462",
      "new_mode": 33188,
      "new_path": "src/tint/reader/wgsl/classify_template_args.cc"
    },
    {
      "type": "modify",
      "old_id": "c50335343e74f0fc6b2a84d5a3b976bbe838a6e8",
      "old_mode": 33188,
      "old_path": "src/tint/reader/wgsl/parser_impl.cc",
      "new_id": "c9a8576e4ca902ed26a3ce66cf2eff0ca60d50d7",
      "new_mode": 33188,
      "new_path": "src/tint/reader/wgsl/parser_impl.cc"
    },
    {
      "type": "modify",
      "old_id": "f692d777b262f9549d0c492d50eefa963d1d114b",
      "old_mode": 33188,
      "old_path": "src/tint/reader/wgsl/parser_impl.h",
      "new_id": "64618b370489f62b855145b2f2478beacfcf8987",
      "new_mode": 33188,
      "new_path": "src/tint/reader/wgsl/parser_impl.h"
    },
    {
      "type": "delete",
      "old_id": "32c3c47c69c092006904144d88399d7aa22eda96",
      "old_mode": 33188,
      "old_path": "src/tint/reader/wgsl/parser_impl_address_space_test.cc",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "modify",
      "old_id": "d40898aedeab8af97dee35c278d601642832cc5b",
      "old_mode": 33188,
      "old_path": "src/tint/reader/wgsl/parser_impl_error_msg_test.cc",
      "new_id": "18b40beb8f11907c2317c6e7ab797803cd8133aa",
      "new_mode": 33188,
      "new_path": "src/tint/reader/wgsl/parser_impl_error_msg_test.cc"
    },
    {
      "type": "modify",
      "old_id": "92272cce5a480f24a4714af8e9afc88226dbcaa7",
      "old_mode": 33188,
      "old_path": "src/tint/reader/wgsl/parser_impl_global_variable_decl_test.cc",
      "new_id": "daf978e9c916d4ca8254e5f59a6cff9ccb41beb4",
      "new_mode": 33188,
      "new_path": "src/tint/reader/wgsl/parser_impl_global_variable_decl_test.cc"
    },
    {
      "type": "modify",
      "old_id": "b40d887a4cbca15c26cb4bb8b50b38c952e75b10",
      "old_mode": 33188,
      "old_path": "src/tint/reader/wgsl/parser_impl_type_decl_test.cc",
      "new_id": "25e60e03683a21a9e7028cfe7e89fbf2c8cf8118",
      "new_mode": 33188,
      "new_path": "src/tint/reader/wgsl/parser_impl_type_decl_test.cc"
    },
    {
      "type": "modify",
      "old_id": "9138d55a7a6ef8528e2327c432b1f11a0cd2284a",
      "old_mode": 33188,
      "old_path": "src/tint/reader/wgsl/parser_impl_variable_decl_test.cc",
      "new_id": "993ecb0ad9387cdfe03e81ce8a0532080c386573",
      "new_mode": 33188,
      "new_path": "src/tint/reader/wgsl/parser_impl_variable_decl_test.cc"
    },
    {
      "type": "modify",
      "old_id": "111f20787a794563dcbfdcbc98b3be1c569b2457",
      "old_mode": 33188,
      "old_path": "src/tint/reader/wgsl/parser_impl_variable_qualifier_test.cc",
      "new_id": "9a8b936e67ecc43c480d829a61596ba12181b48f",
      "new_mode": 33188,
      "new_path": "src/tint/reader/wgsl/parser_impl_variable_qualifier_test.cc"
    },
    {
      "type": "modify",
      "old_id": "2c879de5268a0b39bd52b311969394b1500a6b15",
      "old_mode": 33188,
      "old_path": "src/tint/resolver/address_space_validation_test.cc",
      "new_id": "95301c74adf110b0efbb1594fbab2e5d9c451115",
      "new_mode": 33188,
      "new_path": "src/tint/resolver/address_space_validation_test.cc"
    },
    {
      "type": "modify",
      "old_id": "16a3f8ec159672c157c17310f30aa90ea5c135c0",
      "old_mode": 33188,
      "old_path": "src/tint/resolver/dependency_graph.cc",
      "new_id": "75e377fcab56052b709f6bf0ae838c23aed2819d",
      "new_mode": 33188,
      "new_path": "src/tint/resolver/dependency_graph.cc"
    },
    {
      "type": "modify",
      "old_id": "31e484eec4f66687f7cba9424169da58ff91206a",
      "old_mode": 33188,
      "old_path": "src/tint/resolver/dependency_graph_test.cc",
      "new_id": "a316ad04434d9582bf7274585e761f1289beae22",
      "new_mode": 33188,
      "new_path": "src/tint/resolver/dependency_graph_test.cc"
    },
    {
      "type": "modify",
      "old_id": "b04831ee622e65ec452c880176b5c30c3a8f6ad4",
      "old_mode": 33188,
      "old_path": "src/tint/resolver/function_validation_test.cc",
      "new_id": "1062958a7d7b25b04ef8e44c83b8d1c39854d72b",
      "new_mode": 33188,
      "new_path": "src/tint/resolver/function_validation_test.cc"
    },
    {
      "type": "modify",
      "old_id": "b87852f6461cc8e413817c235c22877bf4503e56",
      "old_mode": 33188,
      "old_path": "src/tint/resolver/resolver.cc",
      "new_id": "833676577a84a822debb14072385d181e45815be",
      "new_mode": 33188,
      "new_path": "src/tint/resolver/resolver.cc"
    },
    {
      "type": "modify",
      "old_id": "73fa9b879e8f6e06318aff0d3e61162d145605e5",
      "old_mode": 33188,
      "old_path": "src/tint/resolver/validation_test.cc",
      "new_id": "8ee795ce91ba416c098bd61c7ee5a9dba7313c5a",
      "new_mode": 33188,
      "new_path": "src/tint/resolver/validation_test.cc"
    },
    {
      "type": "modify",
      "old_id": "5b399cfb145bf7661a17e4a1a1f49f8e2f4ee472",
      "old_mode": 33188,
      "old_path": "src/tint/resolver/validator.cc",
      "new_id": "2935c70c24dc02c9053fd03542f8073ff87d7b92",
      "new_mode": 33188,
      "new_path": "src/tint/resolver/validator.cc"
    },
    {
      "type": "modify",
      "old_id": "b6579807e33a06957b5241a40d5976212626399c",
      "old_mode": 33188,
      "old_path": "src/tint/transform/binding_remapper.cc",
      "new_id": "192b2c93fdc94257be25aa14be5cb8992e3cebe0",
      "new_mode": 33188,
      "new_path": "src/tint/transform/binding_remapper.cc"
    },
    {
      "type": "modify",
      "old_id": "5af8a142fd17d47e64bbbbab5b7e8f63f2f2a585",
      "old_mode": 33188,
      "old_path": "src/tint/transform/canonicalize_entry_point_io_test.cc",
      "new_id": "f0ce8c34c5027dc353e6824f6e7f0d3007c6871a",
      "new_mode": 33188,
      "new_path": "src/tint/transform/canonicalize_entry_point_io_test.cc"
    },
    {
      "type": "modify",
      "old_id": "57d9a40a3c330b89acecc066a5fbf7107465ed16",
      "old_mode": 33188,
      "old_path": "src/tint/transform/clamp_frag_depth.cc",
      "new_id": "8d84ed365437c0bae0ddc0e14e75a7eac15c4c41",
      "new_mode": 33188,
      "new_path": "src/tint/transform/clamp_frag_depth.cc"
    },
    {
      "type": "modify",
      "old_id": "ff65fecf1e70cd127ab21da8243f2393c3810532",
      "old_mode": 33188,
      "old_path": "src/tint/transform/module_scope_var_to_entry_point_param.cc",
      "new_id": "47356e96269a1a7f60390e49d1c9ba7ca0af4c33",
      "new_mode": 33188,
      "new_path": "src/tint/transform/module_scope_var_to_entry_point_param.cc"
    },
    {
      "type": "modify",
      "old_id": "999761dd490ec79287e904cd98069784cefe510d",
      "old_mode": 33188,
      "old_path": "src/tint/transform/module_scope_var_to_entry_point_param_test.cc",
      "new_id": "0f4c5b9d2d5346c40c5fde30888a8a179a692fe7",
      "new_mode": 33188,
      "new_path": "src/tint/transform/module_scope_var_to_entry_point_param_test.cc"
    },
    {
      "type": "modify",
      "old_id": "c233267a219ce6b34a557ff4249a8294ba4df7f5",
      "old_mode": 33188,
      "old_path": "src/tint/transform/renamer_test.cc",
      "new_id": "2d13436ccdaeb505a56c6026fa0a23040fbf265c",
      "new_mode": 33188,
      "new_path": "src/tint/transform/renamer_test.cc"
    },
    {
      "type": "modify",
      "old_id": "4c487d05900913cf44551e3ab3dc541de84e3eeb",
      "old_mode": 33188,
      "old_path": "src/tint/transform/std140.cc",
      "new_id": "a19d78f73cd7d3a10b8d9d82d604db5440f4f98f",
      "new_mode": 33188,
      "new_path": "src/tint/transform/std140.cc"
    },
    {
      "type": "modify",
      "old_id": "49d96d901fabb474a5691beacd4fc629abd6f3e8",
      "old_mode": 33188,
      "old_path": "src/tint/transform/zero_init_workgroup_memory.cc",
      "new_id": "015a25bfd7c8868dac28f9d6ece4e412c22abf89",
      "new_mode": 33188,
      "new_path": "src/tint/transform/zero_init_workgroup_memory.cc"
    },
    {
      "type": "modify",
      "old_id": "68f2c71f8425df3e84d51e6a6ad5dbfdd629a107",
      "old_mode": 33188,
      "old_path": "src/tint/type/address_space.cc",
      "new_id": "c3cfcc67ed06ed75e4f51c89171c624fd4cc5c50",
      "new_mode": 33188,
      "new_path": "src/tint/type/address_space.cc"
    },
    {
      "type": "modify",
      "old_id": "5b3855c2c971de2296154284d85d1ef06dfa7016",
      "old_mode": 33188,
      "old_path": "src/tint/type/address_space.h",
      "new_id": "f0b0224591ed1b6b27994e6c1caebcbe9a707a51",
      "new_mode": 33188,
      "new_path": "src/tint/type/address_space.h"
    },
    {
      "type": "modify",
      "old_id": "ecd3ccf57b96ff99a71c78367dc21db066df01a7",
      "old_mode": 33188,
      "old_path": "src/tint/type/address_space_bench.cc",
      "new_id": "6f33497ee24e0c77c7e524c056e31143d0d18d47",
      "new_mode": 33188,
      "new_path": "src/tint/type/address_space_bench.cc"
    },
    {
      "type": "modify",
      "old_id": "8b2af5c66187d5c0daf5fd222df0880fe6921707",
      "old_mode": 33188,
      "old_path": "src/tint/type/address_space_test.cc",
      "new_id": "7909f0ec4516dfebea8f96ca72032cdda056f552",
      "new_mode": 33188,
      "new_path": "src/tint/type/address_space_test.cc"
    },
    {
      "type": "modify",
      "old_id": "ae34abb7dc882163bd18a66c48d630f8c3758dee",
      "old_mode": 33188,
      "old_path": "src/tint/writer/wgsl/generator_impl.cc",
      "new_id": "c92e51ad6d4a860a6513ea1efe1af5480ee00db8",
      "new_mode": 33188,
      "new_path": "src/tint/writer/wgsl/generator_impl.cc"
    },
    {
      "type": "modify",
      "old_id": "56c0dfb75d78f52202800eb27888af40dd1ee887",
      "old_mode": 33188,
      "old_path": "src/tint/writer/wgsl/generator_impl.h",
      "new_id": "746ce0f7985626e7cb537198d14ee97939e9a2c0",
      "new_mode": 33188,
      "new_path": "src/tint/writer/wgsl/generator_impl.h"
    }
  ]
}