)]}'
{
  "commit": "0c7a99f894dfea64a0fa1fd03132a7a36ac93683",
  "tree": "c30d44fb5ed23709f7638f25d091f417eb628024",
  "parents": [
    "4957327cc9865fd7d169971752f372016b5721bf"
  ],
  "author": {
    "name": "Stephen White",
    "email": "senorblanco@chromium.org",
    "time": "Fri May 26 04:53:17 2023 +0000"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Fri May 26 04:53:17 2023 +0000"
  },
  "message": "Tint/GLSL: rename identifiers containing double-underscores.\n\nThis is prohibited by the GLSL ES spec:\n\n\"In addition, all identifiers containing two consecutive underscores (__) are reserved for use by underlying\nsoftware layers. Defining such a name in a shader does not itself result in an error, but may result in\nunintended behaviors that stem from having multiple definitions of the same name.\"\n\n(https://registry.khronos.org/OpenGL/specs/es/3.1/GLSL_ES_Specification_3.10.withchanges.pdf, section 3.7).\n\nHowever, while glslang validation will not give an error on this, NVidia\nES drivers will. So I\u0027ve added a Dawn end2end test instead of a WGSL test.\n\nBug: tint:1944\nChange-Id: I4b965af00039ca7a232bc11be884483f8e02ccf6\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/134140\nReviewed-by: Ben Clayton \u003cbclayton@google.com\u003e\nCommit-Queue: Stephen White \u003csenorblanco@chromium.org\u003e\nKokoro: Kokoro \u003cnoreply+kokoro@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "fc94c481a6cf09507bfd782c693e094b8ef96a6d",
      "old_mode": 33188,
      "old_path": "src/dawn/tests/end2end/ShaderTests.cpp",
      "new_id": "683e36184a12d3de0e2610b48c376bea0ec14ece",
      "new_mode": 33188,
      "new_path": "src/dawn/tests/end2end/ShaderTests.cpp"
    },
    {
      "type": "modify",
      "old_id": "b7c03a10c892b538c5d82d224524809b823a4f5c",
      "old_mode": 33188,
      "old_path": "src/tint/ast/transform/renamer.cc",
      "new_id": "ff669f757cd5c20c2976d7ec801d5770f59911c6",
      "new_mode": 33188,
      "new_path": "src/tint/ast/transform/renamer.cc"
    },
    {
      "type": "modify",
      "old_id": "9e34babfbc9da5eab5d1a44dbdc5c51157c6155f",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/atomics/from_gen/literal/atomicCompareExchangeWeak/storage_i32.spvasm.expected.glsl",
      "new_id": "873c74647b02a6a0131d4f2765305a15deeb3640",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/atomics/from_gen/literal/atomicCompareExchangeWeak/storage_i32.spvasm.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "cb7126a4724d078e6feaa98d1364d4d7bd3e1969",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/atomics/from_gen/literal/atomicCompareExchangeWeak/storage_u32.spvasm.expected.glsl",
      "new_id": "36812c318940acf9b9425eb8315d298f804ad670",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/atomics/from_gen/literal/atomicCompareExchangeWeak/storage_u32.spvasm.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "e84462ab0f112b3d734db9ec25c4f5b2b149cccb",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/atomics/from_gen/literal/atomicCompareExchangeWeak/workgroup_i32.spvasm.expected.glsl",
      "new_id": "6e8440d6cc16a885843676e37737c5278645e719",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/atomics/from_gen/literal/atomicCompareExchangeWeak/workgroup_i32.spvasm.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "b8db0ed5ed1f34df5cde60eb907751740137b3e9",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/atomics/from_gen/literal/atomicCompareExchangeWeak/workgroup_u32.spvasm.expected.glsl",
      "new_id": "b127c4a5c680173862b83caa6617cdc92b208cf6",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/atomics/from_gen/literal/atomicCompareExchangeWeak/workgroup_u32.spvasm.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "dffc4024d402a0b999f4feb21a2819d7498a0db1",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/atomics/from_gen/var/atomicCompareExchangeWeak/storage_i32.spvasm.expected.glsl",
      "new_id": "0ae16865473897dbf91aceaca1f111b378433557",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/atomics/from_gen/var/atomicCompareExchangeWeak/storage_i32.spvasm.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "7c0b63fc94ec2e6c296fd63f71995657beccc85d",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/atomics/from_gen/var/atomicCompareExchangeWeak/storage_u32.spvasm.expected.glsl",
      "new_id": "a52bb8e7001322edc4643d617a730a7943101e40",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/atomics/from_gen/var/atomicCompareExchangeWeak/storage_u32.spvasm.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "c93cea245d700511a98858004733c6d5b7ac7864",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/atomics/from_gen/var/atomicCompareExchangeWeak/workgroup_i32.spvasm.expected.glsl",
      "new_id": "18b479ffd011e54cbae8ad45c7763f0c79f8bc45",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/atomics/from_gen/var/atomicCompareExchangeWeak/workgroup_i32.spvasm.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "920a16edf0b3d0194b0ca977831585f843307011",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/atomics/from_gen/var/atomicCompareExchangeWeak/workgroup_u32.spvasm.expected.glsl",
      "new_id": "51e6c91e5962afbb08e9aecb3a6090e3570ccc4b",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/atomics/from_gen/var/atomicCompareExchangeWeak/workgroup_u32.spvasm.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "8e59b08f3688e66373dd3132c5e48a4320874668",
      "old_mode": 33188,
      "old_path": "test/tint/identifiers/underscore/double/fn.wgsl.expected.glsl",
      "new_id": "03def7287bc221db820011671fe7569be59a468b",
      "new_mode": 33188,
      "new_path": "test/tint/identifiers/underscore/double/fn.wgsl.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "f274d04ea9a267f77b16ba64d9b134ad4559e359",
      "old_mode": 33188,
      "old_path": "test/tint/identifiers/underscore/double/let.wgsl.expected.glsl",
      "new_id": "638acd9c18d221d4cc05c9076d1786539df72b15",
      "new_mode": 33188,
      "new_path": "test/tint/identifiers/underscore/double/let.wgsl.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "1c7262a4562f51b9a53542427d1acd103c4ac8f8",
      "old_mode": 33188,
      "old_path": "test/tint/identifiers/underscore/double/parameter.wgsl.expected.glsl",
      "new_id": "8e829352e2da342fce88471dbced7e7e7b05d3af",
      "new_mode": 33188,
      "new_path": "test/tint/identifiers/underscore/double/parameter.wgsl.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "9eb009e147091e2d4ab89a76ff5b1e58899cc9bf",
      "old_mode": 33188,
      "old_path": "test/tint/identifiers/underscore/double/struct.wgsl.expected.glsl",
      "new_id": "a6ac4ffe9779f64f88f15ad38950aae6c4b1b63b",
      "new_mode": 33188,
      "new_path": "test/tint/identifiers/underscore/double/struct.wgsl.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "f61376ad0db3fc136d84e393937ff335aeb46925",
      "old_mode": 33188,
      "old_path": "test/tint/identifiers/underscore/double/var.wgsl.expected.glsl",
      "new_id": "9addc2921b09fe08aba9250c2b19b6ed743a83d5",
      "new_mode": 33188,
      "new_path": "test/tint/identifiers/underscore/double/var.wgsl.expected.glsl"
    }
  ]
}