commit 6d385e414cc076878d86bc335e5d5296fa98dee2
author Shrek Shao <shrekshao@google.com> Fri Jun 02 00:49:07 2023 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jun 02 00:49:07 2023 +0000
tree 4d5eccc135b2f1ba63b69517123e802d641087e6
parent 5ad1adc9ffa4f91efb96b5269d41722b1eb3fb6b

More fixes for dawn->google3 roll

Add -Wctad-maybe-unsupported flag to clang like google3.

Change-Id: Ie2bd9377a22c3618d208e698f9f6a20626dc0138
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/135621
Reviewed-by: Austin Eng <enga@chromium.org>
Auto-Submit: Shrek Shao <shrekshao@google.com>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>

src/dawn/common/BUILD.gn

diff --git a/src/dawn/common/BUILD.gn b/src/dawn/common/BUILD.gn
index 7b821e7..c02f46c 100644
--- a/src/dawn/common/BUILD.gn
+++ b/src/dawn/common/BUILD.gn
@@ -118,6 +118,7 @@
     cflags += [
       "-Wconditional-uninitialized",
       "-Wcstring-format-directive",
+      "-Wctad-maybe-unsupported",
       "-Wc++11-narrowing",
       "-Wdeprecated-copy",
       "-Wdeprecated-copy-dtor",

src/dawn/native/CommandBufferStateTracker.cpp

diff --git a/src/dawn/native/CommandBufferStateTracker.cpp b/src/dawn/native/CommandBufferStateTracker.cpp
index 833ee90..6ca913d 100644
--- a/src/dawn/native/CommandBufferStateTracker.cpp
+++ b/src/dawn/native/CommandBufferStateTracker.cpp
@@ -363,7 +363,8 @@
             !TextureViewsAllMatch(views),
             "In compatibility mode, %s must not have different views in a single draw/dispatch "
             "command. texture views: %s",
-            texture, ityp::span(views->data(), views->size()));
+            texture,
+            ityp::span<size_t, const TextureViewBase* const>(views->data(), views->size()));
     }
 
     return {};