)]}' { "commit": "e7f7ac3753cfbbaeae2de129a06b594180b87f62", "tree": "b2eba231a5f5048b847150aed0562e461405b258", "parents": [ "9acf005c437d1ec0c931afa37389807ba029a98b" ], "author": { "name": "Loko Kung", "email": "lokokung@google.com", "time": "Wed Jul 19 18:35:58 2023 +0000" }, "committer": { "name": "Dawn LUCI CQ", "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jul 19 18:35:58 2023 +0000" }, "message": "Revert \"Updates ContentLessObjectCache to use WeakRefs.\"\n\nThis reverts commit 5759b5539e7902149f31cd5c5392b504f5fd4cab.\n\nReason for revert: Breaking roll into Chromium.\nBug: chromium:1466134\n\nOriginal change\u0027s description:\n\u003e Updates ContentLessObjectCache to use WeakRefs.\n\u003e\n\u003e - Re-implements the cache using WeakRefs.\n\u003e - Cleans up old Uncache* functions that are no longer needed.\n\u003e - Removes \"cached\" state from CachedObject since it\u0027s no longer needed.\n\u003e - Minor updates to related tests.\n\u003e\n\u003e Bug: dawn:1769\n\u003e Change-Id: I25cf5d3d5d3c9bcd793239db735304e74e9d6b76\n\u003e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/139283\n\u003e Reviewed-by: Austin Eng \u003cenga@chromium.org\u003e\n\u003e Kokoro: Kokoro \u003cnoreply+kokoro@google.com\u003e\n\u003e Reviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\n\u003e Commit-Queue: Loko Kung \u003clokokung@google.com\u003e\n\nTBR\u003dcwallez@chromium.org,enga@chromium.org,noreply+kokoro@google.com,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com,lokokung@google.com\n\nChange-Id: Iead07169439f4dfa8a7ffb28a38baa3e0646a4b7\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: dawn:1769\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/141940\nReviewed-by: Loko Kung \u003clokokung@google.com\u003e\nCommit-Queue: Loko Kung \u003clokokung@google.com\u003e\nKokoro: Austin Eng \u003cenga@chromium.org\u003e\nReviewed-by: Austin Eng \u003cenga@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "6b72bb5e05dd79426a2c346881b368f6859a7c1f", "old_mode": 33188, "old_path": "src/dawn/common/BUILD.gn", "new_id": "297565f4bf5493b1ef2c52003bf46f0c6d499db2", "new_mode": 33188, "new_path": "src/dawn/common/BUILD.gn" }, { "type": "modify", "old_id": "ca789090ab99f83747b54e0841122c6946c73f1b", "old_mode": 33188, "old_path": "src/dawn/common/CMakeLists.txt", "new_id": "cb1b38867000e2822fda50d6c37f85d78b607375", "new_mode": 33188, "new_path": "src/dawn/common/CMakeLists.txt" }, { "type": "modify", "old_id": "66547776f50983b15d7332d8d02b6795bf7fbba2", "old_mode": 33188, "old_path": "src/dawn/common/ContentLessObjectCache.h", "new_id": "551f796fc228ba0f6570381a2c39c25c88c9902d", "new_mode": 33188, "new_path": "src/dawn/common/ContentLessObjectCache.h" }, { "type": "delete", "old_id": "eae50e91ba6bd383b5495476ca7ed55c3fa23614", "old_mode": 33188, "old_path": "src/dawn/common/ContentLessObjectCacheable.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "697186287c29a20542af30e534c167fb4ce873fe", "old_mode": 33188, "old_path": "src/dawn/common/RefCounted.h", "new_id": "342427184a8c5665094f9765837670121bd3b2a0", "new_mode": 33188, "new_path": "src/dawn/common/RefCounted.h" }, { "type": "modify", "old_id": "26485f6bcfc8b3a3286957a92d114c26c4cd325c", "old_mode": 33188, "old_path": "src/dawn/common/WeakRef.h", "new_id": "4764924050d4592161119ccfe241eb3e3b364d71", "new_mode": 33188, "new_path": "src/dawn/common/WeakRef.h" }, { "type": "modify", "old_id": "a85a9d79400f41cc088bbe42a07ba05956c88cc4", "old_mode": 33188, "old_path": "src/dawn/common/WeakRefSupport.cpp", "new_id": "9273ff1cc75096cd752f37a6bf56e7fd0683b8e3", "new_mode": 33188, "new_path": "src/dawn/common/WeakRefSupport.cpp" }, { "type": "modify", "old_id": "de3796547dca8bb6cdd51b4861748018646ee7f1", "old_mode": 33188, "old_path": "src/dawn/common/WeakRefSupport.h", "new_id": "9702905d76653aabe3aa3225f8f25db6a928c4a3", "new_mode": 33188, "new_path": "src/dawn/common/WeakRefSupport.h" }, { "type": "modify", "old_id": "9ece45d7941826e7d6c88932327178fdbf9bab75", "old_mode": 33188, "old_path": "src/dawn/native/AttachmentState.cpp", "new_id": "1e7e370d0335e64576e4d9d2795367d2aae97e39", "new_mode": 33188, "new_path": "src/dawn/native/AttachmentState.cpp" }, { "type": "modify", "old_id": "c17faae22aeffb9a126c97df98b3bd7483bf3841", "old_mode": 33188, "old_path": "src/dawn/native/AttachmentState.h", "new_id": "fcb0e435934bc018250b7f73adcdfaba4e98d83d", "new_mode": 33188, "new_path": "src/dawn/native/AttachmentState.h" }, { "type": "modify", "old_id": "6bb8c5f00c518ee7e4e1cdbccac0fdf09d1084a9", "old_mode": 33188, "old_path": "src/dawn/native/BindGroupLayout.cpp", "new_id": "43245484e18022bc22ac5388aabd153c821d74a5", "new_mode": 33188, "new_path": "src/dawn/native/BindGroupLayout.cpp" }, { "type": "modify", "old_id": "77042b948d06dae55814c942657ad0cd0f3203be", "old_mode": 33188, "old_path": "src/dawn/native/BindGroupLayout.h", "new_id": "c2ffb97a73ce24e9b46b75faf14693b0d5b568d7", "new_mode": 33188, "new_path": "src/dawn/native/BindGroupLayout.h" }, { "type": "modify", "old_id": "3460bc1f680ecab9bba11fe151bad434324f2d05", "old_mode": 33188, "old_path": "src/dawn/native/CachedObject.cpp", "new_id": "bf2be11eb82b60a81d18899150651d23040a666a", "new_mode": 33188, "new_path": "src/dawn/native/CachedObject.cpp" }, { "type": "modify", "old_id": "5b7afec265384d95b623969dd0069e9e6b50e24c", "old_mode": 33188, "old_path": "src/dawn/native/CachedObject.h", "new_id": "1040f541fffe6732f70740da38aca74d7ee2f0b8", "new_mode": 33188, "new_path": "src/dawn/native/CachedObject.h" }, { "type": "modify", "old_id": "9916a0aa1f1bb2a2b905c4c2beee952969f32173", "old_mode": 33188, "old_path": "src/dawn/native/ComputePipeline.cpp", "new_id": "99364e740b4604930f5974d9f2b8e2521200a019", "new_mode": 33188, "new_path": "src/dawn/native/ComputePipeline.cpp" }, { "type": "modify", "old_id": "47662ba8e8045d4011cb97af01994ce1ce62510e", "old_mode": 33188, "old_path": "src/dawn/native/ComputePipeline.h", "new_id": "85794ecd868c3900cf2cef06ccba9ae1425bf1b4", "new_mode": 33188, "new_path": "src/dawn/native/ComputePipeline.h" }, { "type": "modify", "old_id": "72e81e6963e54f09033bf939d127e3075e771512", "old_mode": 33188, "old_path": "src/dawn/native/Device.cpp", "new_id": "2a77e66d86f6dd0645cc5c06d78358dd791ed3a9", "new_mode": 33188, "new_path": "src/dawn/native/Device.cpp" }, { "type": "modify", "old_id": "03ee64863ce919960da98abd46563c91ed9426c2", "old_mode": 33188, "old_path": "src/dawn/native/Device.h", "new_id": "015447432c9486ca1e406d45307bee18387de83e", "new_mode": 33188, "new_path": "src/dawn/native/Device.h" }, { "type": "modify", "old_id": "839efe9fcce86d0c7c520c14d99ec54b6a4ce463", "old_mode": 33188, "old_path": "src/dawn/native/PipelineLayout.cpp", "new_id": "c11a86bdc23872ce6eeca924f6c9cadf79135645", "new_mode": 33188, "new_path": "src/dawn/native/PipelineLayout.cpp" }, { "type": "modify", "old_id": "6f89786ceb163e2bf7e55d2ad87a3651e5c3e998", "old_mode": 33188, "old_path": "src/dawn/native/PipelineLayout.h", "new_id": "cd23026b57f5da6a7cc81efa590380e7b49a4f2e", "new_mode": 33188, "new_path": "src/dawn/native/PipelineLayout.h" }, { "type": "modify", "old_id": "e8c7e4fd33c72c7e4c39c4ccf5fc75446d79020f", "old_mode": 33188, "old_path": "src/dawn/native/RenderPipeline.cpp", "new_id": "33dd20db81d428aee5f40d345dfc6cb938952fe6", "new_mode": 33188, "new_path": "src/dawn/native/RenderPipeline.cpp" }, { "type": "modify", "old_id": "0408a98c6f214e323266230cced85f5e36cf23d3", "old_mode": 33188, "old_path": "src/dawn/native/RenderPipeline.h", "new_id": "ad5593a0c23928134c258cee3fe387bc8aa7b395", "new_mode": 33188, "new_path": "src/dawn/native/RenderPipeline.h" }, { "type": "modify", "old_id": "b45255abb60ae76c14b63335ff43233e4d35ea2b", "old_mode": 33188, "old_path": "src/dawn/native/Sampler.cpp", "new_id": "4e44d73376d46c24a6ea1940bd8deb9a2e9b3f70", "new_mode": 33188, "new_path": "src/dawn/native/Sampler.cpp" }, { "type": "modify", "old_id": "08c8bf8b5a953076000c62573c1c5c9564e7a40d", "old_mode": 33188, "old_path": "src/dawn/native/Sampler.h", "new_id": "93e6b58bc2600c34399b052306c63f3123e23f12", "new_mode": 33188, "new_path": "src/dawn/native/Sampler.h" }, { "type": "modify", "old_id": "fb9279b2925a36ce8846a573b4dc002e06ade665", "old_mode": 33188, "old_path": "src/dawn/native/ShaderModule.cpp", "new_id": "ece5cd9e27bc39fd43205521e407b507ca216914", "new_mode": 33188, "new_path": "src/dawn/native/ShaderModule.cpp" }, { "type": "modify", "old_id": "16be99a4ead12379ca8ba6b03688a6d35d8af836", "old_mode": 33188, "old_path": "src/dawn/native/ShaderModule.h", "new_id": "da58ad9929cee7ad0daba49ae1024ee54fecb239", "new_mode": 33188, "new_path": "src/dawn/native/ShaderModule.h" }, { "type": "modify", "old_id": "7ecacd574d543c4374101ed0985fc03681d2bda9", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/ContentLessObjectCacheTests.cpp", "new_id": "4ad91c681e6bbba6cf49131cdae898898e32ffd4", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/ContentLessObjectCacheTests.cpp" }, { "type": "modify", "old_id": "3bc14e5b8a89b42689fc229aa75473f8c4cf3768", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/native/DestroyObjectTests.cpp", "new_id": "74d80546bcb8e9b27364bacb0aa47fc0a3049e49", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/native/DestroyObjectTests.cpp" } ] }