commit dcaaedb4be533558f5bdc602235c66afcef820cd
author Stephen White <senorblanco@chromium.org> Sat Jun 08 00:23:06 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat Jun 08 00:23:06 2024 +0000
tree b54eb413df741f0c1faddb85769dfbf9d493cad1
parent fdc365abbc6eb700c52b509fd7c276967d347297

OpenGL: tweak test suppression.

Updated suppression for MultipleWriteThenMultipleReadTests.OneBuffer.
It's passing on most OpenGLES devices, but still failing on Pixel 6.

Also fix some comments to reflect Compat validation.

Bug: dawn:595 dawn:646 dawn:1300

Change-Id: I38003da434e7dc889511c64205888cc7227b84c4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/192323
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>

src/dawn/tests/end2end/GpuMemorySynchronizationTests.cpp

diff --git a/src/dawn/tests/end2end/GpuMemorySynchronizationTests.cpp b/src/dawn/tests/end2end/GpuMemorySynchronizationTests.cpp
index 42066fe..782e402 100644
--- a/src/dawn/tests/end2end/GpuMemorySynchronizationTests.cpp
+++ b/src/dawn/tests/end2end/GpuMemorySynchronizationTests.cpp
@@ -551,10 +551,8 @@
 // buffer is composed of vertices, indices, uniforms and readonly storage. Data to be read in the
 // buffer in render pass depend on the write operation in compute pass.
 TEST_P(MultipleWriteThenMultipleReadTests, OneBuffer) {
-    // TODO(crbug.com/dawn/646): diagnose and fix this OpenGL ES failure.
-    // "Push constant block cannot be expressed as neither std430 nor std140. ES-targets do not
-    // support GL_ARB_enhanced_layouts."
-    DAWN_SUPPRESS_TEST_IF(IsOpenGLES());
+    // TODO(crbug.com/dawn/646): diagnose this failure on Pixel 6 OpenGLES
+    DAWN_SUPPRESS_TEST_IF(IsOpenGLES() && IsAndroid() && IsARM());
 
     // Create pipeline, bind group, and a complex buffer for compute pass.
     wgpu::ShaderModule csModule = utils::CreateShaderModule(device, R"(

src/dawn/tests/end2end/TextureViewTests.cpp

diff --git a/src/dawn/tests/end2end/TextureViewTests.cpp b/src/dawn/tests/end2end/TextureViewTests.cpp
index f6ea563..254e59e 100644
--- a/src/dawn/tests/end2end/TextureViewTests.cpp
+++ b/src/dawn/tests/end2end/TextureViewTests.cpp
@@ -344,7 +344,7 @@
                             uint32_t textureViewBaseLayer,
                             uint32_t textureViewLayerCount,
                             bool isCubeMapArray) {
-        // TODO(crbug.com/dawn/1300): OpenGLES does not support cube map arrays.
+        // Cube map arrays are unsupported in Compatbility mode.
         DAWN_TEST_UNSUPPORTED_IF(isCubeMapArray && IsCompatibilityMode());
 
         ASSERT_TRUE((textureViewLayerCount == 6) ||

src/dawn/utils/TextureUtils.cpp

diff --git a/src/dawn/utils/TextureUtils.cpp b/src/dawn/utils/TextureUtils.cpp
index 7036d32..9f2357b 100644
--- a/src/dawn/utils/TextureUtils.cpp
+++ b/src/dawn/utils/TextureUtils.cpp
@@ -46,7 +46,7 @@
         case wgpu::TextureFormat::RGBA32Sint:
         case wgpu::TextureFormat::RGBA32Float:
             return true;
-            // TODO(crbug.com/dawn/595): 32-bit RG* formats are unsupported on OpenGL ES.
+            // 32-bit RG* formats are unsupported in Compatibility mode.
         case wgpu::TextureFormat::RG32Uint:
         case wgpu::TextureFormat::RG32Sint:
         case wgpu::TextureFormat::RG32Float: