commit c40e1ab6b0139c8665d596c09fc482eaa1ab8a4e
author Jaswant Panchumarti <jaswant.panchumarti@kitware.com> Wed Jun 26 20:59:37 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jun 26 20:59:37 2024 +0000
tree 4ec9b27f717c1d4d3f4f41adfb501f934f0c2214
parent 95aae3c3eed1689c711453bbce78ab37a88255fb

Use dawn_add_library function to create the dawn_proc library

Change-Id: Id2434604edd39b1d0a35a7e0ef7ab9e8a86948a6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/194916
Commit-Queue: Jaswant Panchumarti <jaswant.panchumarti@kitware.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

src/dawn/CMakeLists.txt

diff --git a/src/dawn/CMakeLists.txt b/src/dawn/CMakeLists.txt
index 166afab..6c1d516 100644
--- a/src/dawn/CMakeLists.txt
+++ b/src/dawn/CMakeLists.txt
@@ -106,27 +106,23 @@
     OUTPUT_SOURCES DAWNPROC_GEN_SOURCES
 )
 
-add_library(dawn_proc)
-common_compile_options(dawn_proc)
-target_compile_definitions(dawn_proc PRIVATE "WGPU_IMPLEMENTATION")
-if(BUILD_SHARED_LIBS)
-    target_compile_definitions(dawn_proc PRIVATE "WGPU_SHARED_LIBRARY")
-endif()
-target_sources(dawn_proc
-  INTERFACE
+dawn_add_library(
+  dawn_proc
+  UTILITY_TARGET dawn_internal_config
+  HEADERS
     "${DAWN_INCLUDE_DIR}/dawn/dawn_thread_dispatch_proc.h"
     "${DAWN_INCLUDE_DIR}/dawn/dawn_proc.h"
-  PRIVATE
-    ${DAWNPROC_GEN_SOURCES}
+  SOURCES
+    "${DAWNPROC_GEN_SOURCES}"
+  DEPENDS
+    dawn::dawn_headers
+  PRIVATE_DEPENDS
+    dawn::dawn_common
 )
-target_link_libraries(dawn_proc
-  PUBLIC
-  dawn_headers
-  PRIVATE
-  dawn_common
-  dawn_internal_config
-)
-
+target_compile_definitions(dawn_proc PRIVATE "WGPU_IMPLEMENTATION")
+if(BUILD_SHARED_LIBS)
+  target_compile_definitions(dawn_proc PUBLIC "WGPU_SHARED_LIBRARY")
+endif()
 install_if_enabled(dawn_proc)
 
 ###############################################################################