)]}'
{
  "commit": "db27b9960804dc6eef83fb9128b4ebe3c413c1a8",
  "tree": "a7c6579e4c8962590adb2fa6627c021420553d30",
  "parents": [
    "2d913200c8319e9a4d1e0ff1b39fe008df8d5c46"
  ],
  "author": {
    "name": "Lokbondo Kung",
    "email": "lokokung@google.com",
    "time": "Thu Aug 29 07:00:08 2024 +0000"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Thu Aug 29 07:00:08 2024 +0000"
  },
  "message": "[dawn] Add custom deleters for surface descriptor glfw_utils.\n\n- Because wgpu::ChainedStruct doesn\u0027t have a virtual dtor, naively\n  using std::unique_ptr doesn\u0027t clean up the allocated descriptors\n  properly. I tried adding virtual dtor for wgpu::ChainedStruct,\n  but as a result of adding that, some of the static_asserts we\n  use to verify struct layouts started failing. Since this is just\n  a helper util, I just added custom deleters where applicable\n  which just casts the wgpu::ChainedStruct into the backing\n  implementation before deleting.\n\nChange-Id: Ib37d4430b394f8e6da754033533ca36b30f14754\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/204415\nCommit-Queue: Corentin Wallez \u003ccwallez@chromium.org\u003e\nReviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "c35252cf1ecf07a0be567b7600e32ba67c42bfcf",
      "old_mode": 33188,
      "old_path": "include/webgpu/webgpu_glfw.h",
      "new_id": "a319ffcb69a96ace34d32a2d9869526272c6a322",
      "new_mode": 33188,
      "new_path": "include/webgpu/webgpu_glfw.h"
    },
    {
      "type": "modify",
      "old_id": "2723374c1109a89addbc4fa3bac42164d447623b",
      "old_mode": 33188,
      "old_path": "src/dawn/glfw/utils.cpp",
      "new_id": "4003931ab0e33618b372357a253f7b0e96c9c235",
      "new_mode": 33188,
      "new_path": "src/dawn/glfw/utils.cpp"
    },
    {
      "type": "modify",
      "old_id": "6131a46b2864f92b8aaca131db7dd1a517ff80a0",
      "old_mode": 33188,
      "old_path": "src/dawn/glfw/utils_metal.mm",
      "new_id": "be71ac7f5cf5fe8f33b8b1a50f758c61735e47c6",
      "new_mode": 33188,
      "new_path": "src/dawn/glfw/utils_metal.mm"
    },
    {
      "type": "modify",
      "old_id": "5c03f047edd6012add010ece62f968a9bfe8f83b",
      "old_mode": 33188,
      "old_path": "src/dawn/tests/end2end/WindowSurfaceTests.cpp",
      "new_id": "c1dd09303eae147429e4a4f4f97799c26c3767ac",
      "new_mode": 33188,
      "new_path": "src/dawn/tests/end2end/WindowSurfaceTests.cpp"
    }
  ]
}