)]}'
{
  "commit": "aebc7be46ec601333832bc14256242f3280bbbd1",
  "tree": "9546659a438c35989ff5847bade520508bed1ff9",
  "parents": [
    "f4340f83b2e522102f4b4038b2ac096eef24f130"
  ],
  "author": {
    "name": "Corentin Wallez",
    "email": "cwallez@chromium.org",
    "time": "Fri Sep 20 13:11:56 2024 +0000"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Fri Sep 20 13:11:56 2024 +0000"
  },
  "message": "dawn::native: Fix the check for no attachment pipelines.\n\nThe check for attachments being required for render pipelines was\nincorrect because it was only performed if desc-\u003efragment !\u003d nullptr,\nwhich is incorrect because desc-\u003efragment \u003d\u003d nullptr means that there is\nno color attachment, and is an error if there\u0027s no depthStencil state.\n\nAdds a regression test.\nFixes unittests that were triggering this validation by mistake, and\nsent a CTS PR for the same purpose.\n\nBug: 341812551\nChange-Id: I1daf726e258712535a42451323c84349257aefe4\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/204934\nReviewed-by: Jiawei Shao \u003cjiawei.shao@intel.com\u003e\nCommit-Queue: Corentin Wallez \u003ccwallez@chromium.org\u003e\nReviewed-by: Kai Ninomiya \u003ckainino@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "0f95190e7039b56d01a9a9348bd60064b5b24f8a",
      "old_mode": 33188,
      "old_path": "src/dawn/native/RenderPipeline.cpp",
      "new_id": "138d39a8139295fe67a217b107ede8f298c1a8dd",
      "new_mode": 33188,
      "new_path": "src/dawn/native/RenderPipeline.cpp"
    },
    {
      "type": "modify",
      "old_id": "9907f87d379759f290bf21345e26ae7b9262848b",
      "old_mode": 33188,
      "old_path": "src/dawn/tests/end2end/CreatePipelineAsyncTests.cpp",
      "new_id": "82d062a72ab8e24f91bc2cce2b75fdf1d00c3d2e",
      "new_mode": 33188,
      "new_path": "src/dawn/tests/end2end/CreatePipelineAsyncTests.cpp"
    },
    {
      "type": "modify",
      "old_id": "ca76375067e6caa5e2bbef23320aa7ba96040a32",
      "old_mode": 33188,
      "old_path": "src/dawn/tests/unittests/native/AllowedErrorTests.cpp",
      "new_id": "3db6073d259fb5c701764a693b89c8508f6f05cb",
      "new_mode": 33188,
      "new_path": "src/dawn/tests/unittests/native/AllowedErrorTests.cpp"
    },
    {
      "type": "modify",
      "old_id": "d899c480e43eb3df0f3b159af768e2e727ae205f",
      "old_mode": 33188,
      "old_path": "src/dawn/tests/unittests/native/CreatePipelineAsyncEventTests.cpp",
      "new_id": "cf7fec6f53d6a25f953a08d57ec7c3fd8e6bc03c",
      "new_mode": 33188,
      "new_path": "src/dawn/tests/unittests/native/CreatePipelineAsyncEventTests.cpp"
    },
    {
      "type": "modify",
      "old_id": "67b37f0b669db1ae64d7f56edc5fe1990f1dbd8b",
      "old_mode": 33188,
      "old_path": "src/dawn/tests/unittests/validation/RenderPipelineValidationTests.cpp",
      "new_id": "cad56a42bc334d29790c0a5aa7754174586777be",
      "new_mode": 33188,
      "new_path": "src/dawn/tests/unittests/validation/RenderPipelineValidationTests.cpp"
    }
  ]
}