)]}' { "commit": "66155c6b84a055faac0b3d3a24093c72662ed98b", "tree": "37f25b3fbfc09a9e3e4239e9daa6c12b41399e6d", "parents": [ "020e317f38755e80d0ffb20e95aae5b47869c1ee" ], "author": { "name": "Corentin Wallez", "email": "cwallez@chromium.org", "time": "Thu Oct 10 09:04:33 2024 +0000" }, "committer": { "name": "Dawn LUCI CQ", "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Oct 10 09:04:33 2024 +0000" }, "message": "Revert \"[dawn][webgpu.h] Use wgpu::StringView for strings in output structs.\"\n\nThis reverts commit 980e48de901e70a01ca96fcc30032492bfc1468f.\n\nReason for revert: breaks compilation of MLDrift in branded Chrome.\n\nOriginal change\u0027s description:\n\u003e [dawn][webgpu.h] Use wgpu::StringView for strings in output structs.\n\u003e\n\u003e These are wgpu::AdapterInfo and wgpu::CompilationMessage.\n\u003e\n\u003e - Adds a deprecation #define for a few code changes in Skia and\n\u003e Chromium.\n\u003e - Fixup the FreeMembers logic for StringView that 1) doesn\u0027t need a\n\u003e FreeMembers method itself, 2) should have .data checked when deciding\n\u003e whether to auto-free members in the C++ header.\n\u003e - For convenience, add StringView support to webgpu_cpp_print.h\n\u003e - During conversion of dawn::native, try to simplify the handling of\n\u003e allocation and returning of output strings in Adapter and\n\u003e CompilationMessages.\n\u003e - Likewise for dawn::wire.\n\u003e - Simplify GPUCompilationMessages in dawn.node to compute all members\n\u003e in its constructor.\n\u003e - Fixup various other files for compilation errors after the change.\n\u003e\n\u003e Bug: 42241188\n\u003e Change-Id: I6db839a6b8862b4a55c1ea9911ed3725b465c2f3\n\u003e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/208534\n\u003e Commit-Queue: Corentin Wallez \u003ccwallez@chromium.org\u003e\n\u003e Reviewed-by: Kai Ninomiya \u003ckainino@chromium.org\u003e\n\nTBR\u003dcwallez@chromium.org,kainino@chromium.org,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com,lokokung@google.com\n\nChange-Id: Ib0e16a9c9486b931f3e1dca7744635a394bf5aeb\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: 42241188\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/210434\nCommit-Queue: Corentin Wallez \u003ccwallez@chromium.org\u003e\nReviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\nBot-Commit: rubber-stamper@appspot.gserviceaccount.com \u003crubber-stamper@appspot.gserviceaccount.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "45be92dfa8a7eeebeee74bd9209300f1d5272aaf", "old_mode": 33188, "old_path": "generator/dawn_json_generator.py", "new_id": "ef21844dfd6a8cd44fdd01ab87a170240d641816", "new_mode": 33188, "new_path": "generator/dawn_json_generator.py" }, { "type": "modify", "old_id": "05f8575dc0cee2aebfe158134d6b08d69e58dcca", "old_mode": 33188, "old_path": "generator/templates/api.h", "new_id": "df298b022e344faa4c3dfab67d4ac15339477f22", "new_mode": 33188, "new_path": "generator/templates/api.h" }, { "type": "modify", "old_id": "fe78b715fec3459f365e93016f527c74c3e624e0", "old_mode": 33188, "old_path": "generator/templates/api_cpp.h", "new_id": "be78c158ee3d68d2d703cca948966c0c46905b1e", "new_mode": 33188, "new_path": "generator/templates/api_cpp.h" }, { "type": "modify", "old_id": "e2c99615638b41b4fc01a95138e472fffdf95322", "old_mode": 33188, "old_path": "generator/templates/api_cpp_print.h", "new_id": "4c7c84a2ea09366c2363dab970687f53d6af9e28", "new_mode": 33188, "new_path": "generator/templates/api_cpp_print.h" }, { "type": "modify", "old_id": "2b0fb20b1fd1f1efb53df239c13c876c80b8ba61", "old_mode": 33188, "old_path": "generator/templates/dawn/cpp_macros.tmpl", "new_id": "a63acd15ce7a3a6484267df4d46c9f91c41060ec", "new_mode": 33188, "new_path": "generator/templates/dawn/cpp_macros.tmpl" }, { "type": "modify", "old_id": "64e373b7dae51270255feec11a1bb83059a57fa2", "old_mode": 33188, "old_path": "generator/templates/dawn/native/api_structs.cpp", "new_id": "8b8c9c8588235242994fd2545138f69614ce8d27", "new_mode": 33188, "new_path": "generator/templates/dawn/native/api_structs.cpp" }, { "type": "modify", "old_id": "64ab821659d61fded256215797d5c4b8be7b79d7", "old_mode": 33188, "old_path": "src/dawn/common/BUILD.gn", "new_id": "63d20a8cac2d26bdc6acdcfdeeb98e2d80e28ab3", "new_mode": 33188, "new_path": "src/dawn/common/BUILD.gn" }, { "type": "modify", "old_id": "8fe3b9542156e9414a6efadb0f8bf37c9f307bae", "old_mode": 33188, "old_path": "src/dawn/common/CMakeLists.txt", "new_id": "aa0e401f3a65b752b030569885f9eb68dbb06dea", "new_mode": 33188, "new_path": "src/dawn/common/CMakeLists.txt" }, { "type": "delete", "old_id": "63a4a51e31aba968f277ef8780b1f1ff0b0a2285", "old_mode": 33188, "old_path": "src/dawn/common/StringViewUtils.cpp", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "4b3850673876085368afbe3f3b8248ff1d913fc3", "old_mode": 33188, "old_path": "src/dawn/common/StringViewUtils.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "2a9da95b068c5dcd47bd3495744457797b339560", "old_mode": 33188, "old_path": "src/dawn/dawn.json", "new_id": "34a84e0fb30d50d7da24467c7159ab4d79ffb6bb", "new_mode": 33188, "new_path": "src/dawn/dawn.json" }, { "type": "modify", "old_id": "3e79c840af53a666300f99e6f4687c8e5b7d13a8", "old_mode": 33188, "old_path": "src/dawn/native/Adapter.cpp", "new_id": "eebd22c4bc13403b28a06a7781c4325a6dc8a064", "new_mode": 33188, "new_path": "src/dawn/native/Adapter.cpp" }, { "type": "modify", "old_id": "91c3b59272671a4b07f0b4c8f9635cb5dc78117d", "old_mode": 33188, "old_path": "src/dawn/native/CompilationMessages.cpp", "new_id": "3fed812a771d64e07920b5ea8a2e7d40cc7d985a", "new_mode": 33188, "new_path": "src/dawn/native/CompilationMessages.cpp" }, { "type": "modify", "old_id": "8a0280d2f8817dc17d9d35d5ffa9aaeccf95f7f1", "old_mode": 33188, "old_path": "src/dawn/native/CompilationMessages.h", "new_id": "55c7c8b27e0ac74b184ea6be2d13e58d55b1bef2", "new_mode": 33188, "new_path": "src/dawn/native/CompilationMessages.h" }, { "type": "modify", "old_id": "cf73dfc7c4c2df399a89b0199a07d81c1f243d7a", "old_mode": 33188, "old_path": "src/dawn/native/ShaderModule.cpp", "new_id": "46b9536d33f8ded59dfd5ed44bd7ee921b76b974", "new_mode": 33188, "new_path": "src/dawn/native/ShaderModule.cpp" }, { "type": "modify", "old_id": "31c8e8d1e9bd1aade243cfea47c98ba3a86210fa", "old_mode": 33188, "old_path": "src/dawn/node/binding/GPU.cpp", "new_id": "4903aa7eed8b5dc6db09d6792c1a6c4f7045e77c", "new_mode": 33188, "new_path": "src/dawn/node/binding/GPU.cpp" }, { "type": "modify", "old_id": "80c75c9e1dab8362cb6e371ba91ca64d0a949fc9", "old_mode": 33188, "old_path": "src/dawn/node/binding/GPUAdapterInfo.cpp", "new_id": "bedffcfd9f28eb658ba7de2fced5c72702b5a54e", "new_mode": 33188, "new_path": "src/dawn/node/binding/GPUAdapterInfo.cpp" }, { "type": "modify", "old_id": "965d2da814576af0c73b8c1d86f5af5ec2636473", "old_mode": 33188, "old_path": "src/dawn/node/binding/GPUAdapterInfo.h", "new_id": "316e78f63787ef9f95cce2bbf47eabea1aa19abb", "new_mode": 33188, "new_path": "src/dawn/node/binding/GPUAdapterInfo.h" }, { "type": "modify", "old_id": "d5f8f8718c8bf9beefb8e3cfcbb18fcbf2852f67", "old_mode": 33188, "old_path": "src/dawn/node/binding/GPUShaderModule.cpp", "new_id": "44cf9378b7a96b3494bb116a651011b0238823e3", "new_mode": 33188, "new_path": "src/dawn/node/binding/GPUShaderModule.cpp" }, { "type": "modify", "old_id": "cc5eaa60892aa7a58cfc4be719c572ae5ca9ae6e", "old_mode": 33188, "old_path": "src/dawn/samples/DawnInfo.cpp", "new_id": "4ca39d938dd26489e585f8910dba1a1ce41b3a4f", "new_mode": 33188, "new_path": "src/dawn/samples/DawnInfo.cpp" }, { "type": "modify", "old_id": "cb6095c18f19a4d313313498149d9eb7d48de304", "old_mode": 33188, "old_path": "src/dawn/samples/SampleUtils.cpp", "new_id": "18cee4b64e620adabae4018930668984eae974a3", "new_mode": 33188, "new_path": "src/dawn/samples/SampleUtils.cpp" }, { "type": "modify", "old_id": "6ba7dd038c09bc68b28a8bc004980f692c1db836", "old_mode": 33188, "old_path": "src/dawn/tests/DawnTest.cpp", "new_id": "2a7e9a6e81227d5f5504d4f6a67c94a2bb522808", "new_mode": 33188, "new_path": "src/dawn/tests/DawnTest.cpp" }, { "type": "modify", "old_id": "b0d23c04b82ae5fb1d218946dde1a3f9823aa74b", "old_mode": 33188, "old_path": "src/dawn/tests/end2end/AdapterCreationTests.cpp", "new_id": "df281cc877e9c4906189bfcad4278dbad9ad2509", "new_mode": 33188, "new_path": "src/dawn/tests/end2end/AdapterCreationTests.cpp" }, { "type": "modify", "old_id": "a6206b23c118e12537832437e11bada04ffef227", "old_mode": 33188, "old_path": "src/dawn/tests/end2end/AdapterEnumerationTests.cpp", "new_id": "a8e721be2738fa5899c9ecf602b95dce75795214", "new_mode": 33188, "new_path": "src/dawn/tests/end2end/AdapterEnumerationTests.cpp" }, { "type": "modify", "old_id": "9400ecae60e2a8ecb0537a0007f17e5860eb097a", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/validation/ShaderModuleValidationTests.cpp", "new_id": "299eeff06a5d52ed20621cd887a463974363aa36", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/validation/ShaderModuleValidationTests.cpp" }, { "type": "modify", "old_id": "f6865a788643bbd1cb7074b5b49f6bfe31e3ef4d", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/wire/WireInstanceTests.cpp", "new_id": "8b97d85596a4f1d7242432bbd072407cd726dd45", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/wire/WireInstanceTests.cpp" }, { "type": "modify", "old_id": "3dff5f7d207a00b2ccc6920acfa40e6afc9fb6a5", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/wire/WireShaderModuleTests.cpp", "new_id": "f6f2cb674c3d2d0a4a4b9fd1bc97cb0e8654420e", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/wire/WireShaderModuleTests.cpp" }, { "type": "modify", "old_id": "fcfcacadd40891b9e89b244b4bea644c32464f4b", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/wire/WireTest.cpp", "new_id": "519d2127d6c2aeb0693e3d540ad147f166c39d6d", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/wire/WireTest.cpp" }, { "type": "modify", "old_id": "3c07a4bdf3f026adadd65402cea14b9620e10f0a", "old_mode": 33188, "old_path": "src/dawn/wire/client/Adapter.cpp", "new_id": "95030513d5a4fe6fb25e7164d283e5580271df05", "new_mode": 33188, "new_path": "src/dawn/wire/client/Adapter.cpp" }, { "type": "modify", "old_id": "614489b55bc8f452d4c810959a10ad07b5457384", "old_mode": 33188, "old_path": "src/dawn/wire/client/ShaderModule.cpp", "new_id": "66951d8ce57a68adf31532d7fe191019211a72f8", "new_mode": 33188, "new_path": "src/dawn/wire/client/ShaderModule.cpp" } ] }