)]}'
{
  "commit": "12a3b24c456cebd9fd11f23ac0164f78129b00c6",
  "tree": "299b18e83c708bf078d274dd89bbbe51397b17f9",
  "parents": [
    "031b57680c4d7c48de49c3d1f44c054879ddc17d"
  ],
  "author": {
    "name": "Ryan Harrison",
    "email": "rharrison@chromium.org",
    "time": "Wed Nov 27 22:01:26 2024 +0000"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed Nov 27 22:01:26 2024 +0000"
  },
  "message": "[tint][ir][val] Enforce rules around scope for function vars\n\n- Adds a check that function address space vars are only declared in a\n  function scope\n- Adds a check that non-function address space are not declared in a\n  function scope\n- Add a capability to allow MSL specific IR to have private address\n  space vars declared in a function scope.\n- Bunch of test fixes/updates\n\nFixes: 381109471\nFixes: 381109773\nChange-Id: I874930a858777c43a0c26354c7d888ffeab9056c\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/216957\nAuto-Submit: Ryan Harrison \u003crharrison@chromium.org\u003e\nCommit-Queue: Ryan Harrison \u003crharrison@chromium.org\u003e\nReviewed-by: dan sinclair \u003cdsinclair@chromium.org\u003e\nReviewed-by: James Price \u003cjrprice@google.com\u003e\nCommit-Queue: dan sinclair \u003cdsinclair@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "0b366b8526bf991621658998525efdee1b33dfd1",
      "old_mode": 33188,
      "old_path": "src/tint/lang/core/ir/transform/remove_terminator_args.h",
      "new_id": "63bb87d80d3b899296b7ca24c2154d6e2f48bd79",
      "new_mode": 33188,
      "new_path": "src/tint/lang/core/ir/transform/remove_terminator_args.h"
    },
    {
      "type": "modify",
      "old_id": "a56cab3a28d790cfb96c825320c25ddf6088d246",
      "old_mode": 33188,
      "old_path": "src/tint/lang/core/ir/transform/rename_conflicts.h",
      "new_id": "fb5d4b5d7c3053bac27302f24711ed4d60c64e56",
      "new_mode": 33188,
      "new_path": "src/tint/lang/core/ir/transform/rename_conflicts.h"
    },
    {
      "type": "modify",
      "old_id": "e418b0c8e86d8ef63682b985dd5e74911e22e9df",
      "old_mode": 33188,
      "old_path": "src/tint/lang/core/ir/transform/rename_conflicts_test.cc",
      "new_id": "b1be9ad3490e3d5184d02be203de3b785b777c35",
      "new_mode": 33188,
      "new_path": "src/tint/lang/core/ir/transform/rename_conflicts_test.cc"
    },
    {
      "type": "modify",
      "old_id": "945f773024003e1068f14c20ed6b30e562e50784",
      "old_mode": 33188,
      "old_path": "src/tint/lang/core/ir/transform/value_to_let.h",
      "new_id": "852c5548834d3830d6aeb37ef73f129df405af87",
      "new_mode": 33188,
      "new_path": "src/tint/lang/core/ir/transform/value_to_let.h"
    },
    {
      "type": "modify",
      "old_id": "7677f4ccd7464d987426c65c7cae73af2d31802e",
      "old_mode": 33188,
      "old_path": "src/tint/lang/core/ir/validator.cc",
      "new_id": "70fc25512b81631e7c6faa42b797f5fc22e1b534",
      "new_mode": 33188,
      "new_path": "src/tint/lang/core/ir/validator.cc"
    },
    {
      "type": "modify",
      "old_id": "cf4809a4ae059cd83b67ca75fe2feac20ede1cb8",
      "old_mode": 33188,
      "old_path": "src/tint/lang/core/ir/validator.h",
      "new_id": "dcf8564f15aa5d7ddcea65fb2cd7839cb665e242",
      "new_mode": 33188,
      "new_path": "src/tint/lang/core/ir/validator.h"
    },
    {
      "type": "modify",
      "old_id": "57f72f04b43a41c2194465a06a338ce7005e7445",
      "old_mode": 33188,
      "old_path": "src/tint/lang/core/ir/validator_test.cc",
      "new_id": "a9dfb11b971a345fb0ad851d1802e608ca064820",
      "new_mode": 33188,
      "new_path": "src/tint/lang/core/ir/validator_test.cc"
    },
    {
      "type": "modify",
      "old_id": "543d05dc5c5c7bd106c81767447a4805d599600a",
      "old_mode": 33188,
      "old_path": "src/tint/lang/glsl/writer/type_test.cc",
      "new_id": "487394f62be0ff75fbd85947c0471086dec77b63",
      "new_mode": 33188,
      "new_path": "src/tint/lang/glsl/writer/type_test.cc"
    },
    {
      "type": "modify",
      "old_id": "a9f978d8df11b438ed7e38abaf62320bb5b429ba",
      "old_mode": 33188,
      "old_path": "src/tint/lang/hlsl/writer/raise/promote_initializers_test.cc",
      "new_id": "e63a11139d0a4dc31812eb94dc7f88bce97fc8db",
      "new_mode": 33188,
      "new_path": "src/tint/lang/hlsl/writer/raise/promote_initializers_test.cc"
    },
    {
      "type": "modify",
      "old_id": "5bb79e24f5fb87252320455e62cac1480a014d45",
      "old_mode": 33188,
      "old_path": "src/tint/lang/msl/writer/printer/printer.cc",
      "new_id": "a2a1e218b9380970823fddc2d130afe393cff21b",
      "new_mode": 33188,
      "new_path": "src/tint/lang/msl/writer/printer/printer.cc"
    },
    {
      "type": "modify",
      "old_id": "bdf4b0739d3e3e75a528c5f86a7c488d03a1c6ca",
      "old_mode": 33188,
      "old_path": "src/tint/lang/msl/writer/raise/binary_polyfill.cc",
      "new_id": "536065a3a8dd34ae96d6f6c33f456ace4a54befd",
      "new_mode": 33188,
      "new_path": "src/tint/lang/msl/writer/raise/binary_polyfill.cc"
    },
    {
      "type": "modify",
      "old_id": "8f3983a35d5a60ff96dd6cde0378ddb5f3eac49b",
      "old_mode": 33188,
      "old_path": "src/tint/lang/msl/writer/raise/builtin_polyfill.cc",
      "new_id": "cca1607af42ffd55507358d8a68af6b8213134f2",
      "new_mode": 33188,
      "new_path": "src/tint/lang/msl/writer/raise/builtin_polyfill.cc"
    },
    {
      "type": "modify",
      "old_id": "a3c69ee01b2c2287f5848952632b3057c056d6f1",
      "old_mode": 33188,
      "old_path": "src/tint/lang/msl/writer/raise/module_scope_vars.h",
      "new_id": "f9570e708817649c29f30a95642921715813b689",
      "new_mode": 33188,
      "new_path": "src/tint/lang/msl/writer/raise/module_scope_vars.h"
    },
    {
      "type": "modify",
      "old_id": "775b6f703d2594c786d36e3d0f24e7b1716e67b5",
      "old_mode": 33188,
      "old_path": "src/tint/lang/msl/writer/raise/module_scope_vars_test.cc",
      "new_id": "7a64b1d70b4052d70bea4dd7755f02b846fc9ddf",
      "new_mode": 33188,
      "new_path": "src/tint/lang/msl/writer/raise/module_scope_vars_test.cc"
    },
    {
      "type": "modify",
      "old_id": "a230647ea71e5b2727b2a74b66cfaf7b904ad170",
      "old_mode": 33188,
      "old_path": "src/tint/lang/msl/writer/raise/packed_vec3_test.cc",
      "new_id": "d65648fc333fa54662eb00a44a6d27d23b718b93",
      "new_mode": 33188,
      "new_path": "src/tint/lang/msl/writer/raise/packed_vec3_test.cc"
    },
    {
      "type": "modify",
      "old_id": "940f16acb5193c67ba2623b513f6ed986dc13662",
      "old_mode": 33188,
      "old_path": "src/tint/lang/msl/writer/raise/unary_polyfill.cc",
      "new_id": "072bb952f34ec3f42a2775a8e7f3167b07654e9c",
      "new_mode": 33188,
      "new_path": "src/tint/lang/msl/writer/raise/unary_polyfill.cc"
    },
    {
      "type": "modify",
      "old_id": "502ae94fafb6f8125a3a8750eff2fa75c0b41e49",
      "old_mode": 33188,
      "old_path": "src/tint/lang/msl/writer/type_test.cc",
      "new_id": "9c41fdfd640d6480399cfb5ba43c5c1c3ffd8c17",
      "new_mode": 33188,
      "new_path": "src/tint/lang/msl/writer/type_test.cc"
    }
  ]
}