Fix dawn.node GPU adapter log The code was referencing a destroyed stack object. Strange the me that in 2024 the C++ compiler doesn't notice this type of issue. Change-Id: I79121003f4199ef7658bf3d694842a0078021020 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/221855 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Gregg Tavares <gman@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
diff --git a/src/dawn/node/binding/GPU.cpp b/src/dawn/node/binding/GPU.cpp index dec8168..6ec8958 100644 --- a/src/dawn/node/binding/GPU.cpp +++ b/src/dawn/node/binding/GPU.cpp
@@ -231,18 +231,16 @@ } wgpu::Adapter* adapter = nullptr; - AdapterInfo* adapterInfo = nullptr; + wgpu::AdapterInfo adapterInfo; for (auto& a : adapters) { - wgpu::AdapterInfo info; - a.GetInfo(&info); + a.GetInfo(&adapterInfo); if (!deviceName.empty() && - std::string_view(info.device).find(deviceName) == std::string::npos) { + std::string_view(adapterInfo.device).find(deviceName) == std::string::npos) { continue; } adapter = &a; - adapterInfo = &info; break; } @@ -274,7 +272,7 @@ } if (flags_.Get("verbose")) { - std::cout << "using GPU adapter: " << adapterInfo->device << "\n"; + std::cout << "using GPU adapter: " << adapterInfo.device << "\n"; } auto gpuAdapter = GPUAdapter::Create<GPUAdapter>(env, *adapter, flags_, async_);