)]}' { "commit": "1fa8f21027a55087ded8e9c0d5fef8ab74b39924", "tree": "ca587e69447f8b0207a6912ddb00e17f41ec838d", "parents": [ "4fb42a6a016fd155d73070c5711b72e011c45685" ], "author": { "name": "Corentin Wallez", "email": "cwallez@chromium.org", "time": "Wed May 06 06:13:59 2026 -0700" }, "committer": { "name": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com", "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed May 06 06:13:59 2026 -0700" }, "message": "Revert \"vulkan: Implement coherent FramebufferFetch\"\n\nThis reverts commit 5d40cfd4cf77fee5a479e97e8912ca45b143ef0d.\n\nReason for revert: Likely causing the failure on mac-rel in the Dawn/Chromium roller.\n\nOriginal change\u0027s description:\n\u003e vulkan: Implement coherent FramebufferFetch\n\u003e\n\u003e This adds FramebufferFetch support to the Vulkan backend when the\n\u003e VK_EXT_rasterization_order_attachment_access extension is available. The\n\u003e general approach is that when FramebufferFetch is enabled the main\n\u003e subpass will have one input attachment corresponding to each color\n\u003e attachment. If a pipeline uses the @color attribute a VkDescriptorSet\n\u003e with an input attachment for each color attachment is created/bound\n\u003e that Tint can sample them. Tint already has the logic to handle the\n\u003e color attribute and sample attachments.\n\u003e\n\u003e The rasterization order extension ensures that any previous draws in the\n\u003e same render pass are complete before pixel values are sampled.\n\u003e\n\u003e FramebufferFetchHelper encapsulates the logic to allocate\n\u003e VkDescriptorSets and VkDescriptorSetLayouts for this feature.\n\u003e\n\u003e Bug: 42241389\n\u003e Change-Id: I369886c75577966663b181800a71c4d08f9541bc\n\u003e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/290895\n\u003e Commit-Queue: Kyle Charbonneau \u003ckylechar@google.com\u003e\n\u003e Reviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\n\u003e Auto-Submit: Kyle Charbonneau \u003ckylechar@google.com\u003e\n\u003e Reviewed-by: Brandon Jones \u003cbajones@chromium.org\u003e\n\nBug: 42241389\nChange-Id: Ia5802a27548d3cf0cbf0a0f1ae6dc8ca8b2421cf\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/306875\nAuto-Submit: Corentin Wallez \u003ccwallez@chromium.org\u003e\nCommit-Queue: Fr \u003cbeaufort.francois@gmail.com\u003e\nReviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\nReviewed-by: Fr \u003cbeaufort.francois@gmail.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "89eb96ee63e24917daac64a44c80fbb60ce83e1c", "old_mode": 33188, "old_path": "src/dawn/native/BUILD.gn", "new_id": "e9e0b222c9fe4f09b7d721ee77a30eb848cec0a8", "new_mode": 33188, "new_path": "src/dawn/native/BUILD.gn" }, { "type": "modify", "old_id": "3e2501fe5e31ebab2b9117848cf1919fbe39606b", "old_mode": 33188, "old_path": "src/dawn/native/CMakeLists.txt", "new_id": "1eaea375f1ea0529036a10c659a7fcb266711854", "new_mode": 33188, "new_path": "src/dawn/native/CMakeLists.txt" }, { "type": "modify", "old_id": "2cb45c571deaf09c43ba00b1c17f6448f60b4470", "old_mode": 33188, "old_path": "src/dawn/native/PassResourceUsage.h", "new_id": "736ad6146c4e8fe8e1f62083fa0b9a1c5d28a227", "new_mode": 33188, "new_path": "src/dawn/native/PassResourceUsage.h" }, { "type": "modify", "old_id": "266a8a6b58ef89287cd485bc0037ce8f922a2a5f", "old_mode": 33188, "old_path": "src/dawn/native/PassResourceUsageTracker.cpp", "new_id": "7e6e06d14f48a21fc2c0d7ad91dc6d678335e8ec", "new_mode": 33188, "new_path": "src/dawn/native/PassResourceUsageTracker.cpp" }, { "type": "modify", "old_id": "33af9877124a87ac44a792badff29d45177cfdb3", "old_mode": 33188, "old_path": "src/dawn/native/PassResourceUsageTracker.h", "new_id": "e67a9cc4553ba7cd647442745bb97d00e24b95f5", "new_mode": 33188, "new_path": "src/dawn/native/PassResourceUsageTracker.h" }, { "type": "modify", "old_id": "672248780dad5688cf05ced98292eb35bb973edb", "old_mode": 33188, "old_path": "src/dawn/native/RenderEncoderBase.cpp", "new_id": "c892848984a5c5360e70e1dc18af36f16e292826", "new_mode": 33188, "new_path": "src/dawn/native/RenderEncoderBase.cpp" }, { "type": "modify", "old_id": "17bb569ee9a6d74b777e381f534f2b3855e09675", "old_mode": 33188, "old_path": "src/dawn/native/RenderPassEncoder.cpp", "new_id": "34d487ef2ccfa46ec0760382e7d643448318eecd", "new_mode": 33188, "new_path": "src/dawn/native/RenderPassEncoder.cpp" }, { "type": "modify", "old_id": "4467f768f8e2f144ba48636393d3d5f5651f8fdd", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/CommandBufferVk.cpp", "new_id": "1e6d9e0e26d4bc2cad6121212e055acdba6895d0", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/CommandBufferVk.cpp" }, { "type": "modify", "old_id": "cf2e1d2cc4ac45c4b276608200b1622783c3a484", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/CommandBufferVk.h", "new_id": "4a5a2bc26174562162fc18991dad66900d8cb57e", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/CommandBufferVk.h" }, { "type": "modify", "old_id": "5062c31d88046b789d2f85f442e1d1666af81979", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/DeviceVk.cpp", "new_id": "1e0987c2525b49bb1232601d1a41f668c5d0f07b", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/DeviceVk.cpp" }, { "type": "modify", "old_id": "4feece8bd46396ec9c3dd5689653927dc295dfcd", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/DeviceVk.h", "new_id": "5c74441bced754d81536debd08c8b66fe77be39f", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/DeviceVk.h" }, { "type": "delete", "old_id": "8b73aeeadf9dc080c35f33a5817d12bf4757a97f", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/FramebufferFetchHelper.cpp", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "5a65164064d444e5aa3b075b6912cc50c6b7b643", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/FramebufferFetchHelper.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "d4cdf502779267f7aa461d0b023d6333855c58fc", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/PhysicalDeviceVk.cpp", "new_id": "f63ba87e6c01d84aceb117d2f1edc17c0f231bcf", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/PhysicalDeviceVk.cpp" }, { "type": "modify", "old_id": "d3a4411e86cc5bb4f015c87be9d83867c43c4a58", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/PipelineLayoutVk.cpp", "new_id": "817742abecb681d820dd811d742661ab428efde3", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/PipelineLayoutVk.cpp" }, { "type": "modify", "old_id": "a07c5214051825f5b668fe2331d43ca5a79f0cb6", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/PipelineLayoutVk.h", "new_id": "82c4efa40489c5c68f0903650b6fcebe95a0fb65", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/PipelineLayoutVk.h" }, { "type": "modify", "old_id": "bddbd8952c9336f11a8fb8d9a9552202a1dae112", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/RenderPassCache.cpp", "new_id": "2a2be4623c225d757923b6645226c1be445881ca", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/RenderPassCache.cpp" }, { "type": "modify", "old_id": "0cceb5b3927ee8d7222f62b7c78693a224576db3", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/RenderPipelineVk.cpp", "new_id": "ed4727de3fd233fef9c87e891cc8622865eaf250", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/RenderPipelineVk.cpp" }, { "type": "modify", "old_id": "711a72c54e3efe9f1a9140f2d9156e49a0454a10", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/ShaderModuleVk.cpp", "new_id": "f2bf037b65d96e08a6a48acb3706f34385a63b9f", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/ShaderModuleVk.cpp" }, { "type": "modify", "old_id": "eefd10b29ae2f1e635469bbe614373d27a8ceaf4", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/ShaderModuleVk.h", "new_id": "38de4727c57a8642ac9fc6e55f2ecf47f01dbcb6", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/ShaderModuleVk.h" }, { "type": "modify", "old_id": "42eb66d440845293df4afb6975ea49aad1c30e05", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/TextureVk.cpp", "new_id": "e3a87bbd0623dd13f102eb742cac6c64de195a1e", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/TextureVk.cpp" }, { "type": "modify", "old_id": "4825d870ffdd4c5bde6096a10de998034d97db5c", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/UtilsVulkan.cpp", "new_id": "1342fa974216d959a68a5e55daccd1b4936b5d93", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/UtilsVulkan.cpp" }, { "type": "modify", "old_id": "ae5af901888d02bb481fe4bbda602a43b7d5d131", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/UtilsVulkan.h", "new_id": "48782d168ebadc651f138b49429bc03770f326c1", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/UtilsVulkan.h" }, { "type": "modify", "old_id": "40f782055e1ecfe87addbabc2997d1f290a9af8e", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/VulkanExtensions.cpp", "new_id": "0f20c157ba4ecb9cfba680220a85fcaa436f0549", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/VulkanExtensions.cpp" }, { "type": "modify", "old_id": "455be6cb593159a36b77fe63b96d000d81f785a6", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/VulkanExtensions.h", "new_id": "fa82cc406d1a3fcf613de8ce6aeb07698263290a", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/VulkanExtensions.h" }, { "type": "modify", "old_id": "0538369a2799add721a193f0757c85dec22a0312", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/VulkanInfo.cpp", "new_id": "2d870689b8af80ffc9eb4cd124be8a33905c02b6", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/VulkanInfo.cpp" }, { "type": "modify", "old_id": "25bf34053cd6b9b9198b102415e2535741a92bb1", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/VulkanInfo.h", "new_id": "a6a5f480e2e76ede7bb9f0254ed8d42319ceb720", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/VulkanInfo.h" }, { "type": "modify", "old_id": "07ed9cbbd532b370bedb417fc3e8811abbe7a2ce", "old_mode": 33188, "old_path": "src/dawn/tests/end2end/FramebufferFetchTests.cpp", "new_id": "29805d29fbc240afe99e9dd9703c5692e64e6406", "new_mode": 33188, "new_path": "src/dawn/tests/end2end/FramebufferFetchTests.cpp" } ] }