commit 33d0f6aa084072dffd06146374e6e96317a231c3
author Ben Clayton <bclayton@google.com> Fri May 07 14:15:14 2021 +0000
committer Commit Bot service account <commit-bot@chromium.org> Fri May 07 14:15:14 2021 +0000
tree 3e72287f80f06c1d2d0ee202802ae8edc2cacb22
parent 698d01383cda1cad7ca534980e071e072a7efbc3

Fix UBSAN error

As() was being called on a nullptr object.

Change-Id: Iedd7f1c57d12f1ad5ea2af60317817841f5d1392
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/50303
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>

src/reader/spirv/function.cc

diff --git a/src/reader/spirv/function.cc b/src/reader/spirv/function.cc
index 523c370..1cbbc34 100644
--- a/src/reader/spirv/function.cc
+++ b/src/reader/spirv/function.cc
@@ -4033,7 +4033,7 @@
   const auto type_id = def_use_mgr_->GetDef(id)->type_id();
   if (type_id) {
     auto* ast_type = parser_impl_.ConvertType(type_id);
-    if (auto* ptr = ast_type->As<ast::Pointer>()) {
+    if (auto* ptr = As<ast::Pointer>(ast_type)) {
       return ptr->storage_class();
     }
   }