Google Git
Sign in
dawn / tint.git / 340a51e78705706ad0747feb829348dbba9628a5^! / .
commit340a51e78705706ad0747feb829348dbba9628a5[log] [tgz]
authorDavid Neto <dneto@google.com>Fri Apr 17 15:52:49 2020 +0000
committerDavid Neto <dneto@google.com>Fri Apr 17 15:52:49 2020 +0000
tree88eba6e5f11b1552d739959535060c62b04700cd
parent0a196c13c80443fc54a05bb4ccebf0fda111cb7a [diff]
Add required overrides for virtual destructors

Fixes build on macOS

TBR=rharrison@google.com

Change-Id: I22e463b76074b499187a472649c46ef1b17c77cd
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/19880
Reviewed-by: David Neto <dneto@google.com>

diff --git a/src/reader/spirv/parser_impl_test_helper.h b/src/reader/spirv/parser_impl_test_helper.h
index 18132ef..3be8566 100644
--- a/src/reader/spirv/parser_impl_test_helper.h
+++ b/src/reader/spirv/parser_impl_test_helper.h

@@ -34,7 +34,7 @@
 class SpvParserTestBase : public T {
  public:
   SpvParserTestBase() = default;
-  ~SpvParserTestBase() = default;
+  ~SpvParserTestBase() override = default;
 
   /// Sets up the test helper
   void SetUp() override { ctx_.Reset(); }

diff --git a/src/reader/wgsl/parser_impl_builtin_decoration_test.cc b/src/reader/wgsl/parser_impl_builtin_decoration_test.cc
index 7a4cb92..db95974 100644
--- a/src/reader/wgsl/parser_impl_builtin_decoration_test.cc
+++ b/src/reader/wgsl/parser_impl_builtin_decoration_test.cc

@@ -34,7 +34,7 @@
 class BuiltinTest : public testing::TestWithParam<BuiltinData> {
  public:
   BuiltinTest() = default;
-  ~BuiltinTest() = default;
+  ~BuiltinTest() override = default;
 
   void SetUp() override { ctx_.Reset(); }
 

diff --git a/src/reader/wgsl/parser_impl_derivative_modifier_test.cc b/src/reader/wgsl/parser_impl_derivative_modifier_test.cc
index a559258..29b5785e 100644
--- a/src/reader/wgsl/parser_impl_derivative_modifier_test.cc
+++ b/src/reader/wgsl/parser_impl_derivative_modifier_test.cc

@@ -36,7 +36,7 @@
     : public testing::TestWithParam<DerivativeModifierData> {
  public:
   DerivativeModifierTest() = default;
-  ~DerivativeModifierTest() = default;
+  ~DerivativeModifierTest() override = default;
 
   void SetUp() override { ctx_.Reset(); }
 

diff --git a/src/reader/wgsl/parser_impl_pipeline_stage_test.cc b/src/reader/wgsl/parser_impl_pipeline_stage_test.cc
index 19bac5c..028f4c7 100644
--- a/src/reader/wgsl/parser_impl_pipeline_stage_test.cc
+++ b/src/reader/wgsl/parser_impl_pipeline_stage_test.cc

@@ -34,7 +34,7 @@
 class PipelineStageTest : public testing::TestWithParam<PipelineStageData> {
  public:
   PipelineStageTest() = default;
-  ~PipelineStageTest() = default;
+  ~PipelineStageTest() override = default;
 
   void SetUp() override { ctx_.Reset(); }
 

diff --git a/src/reader/wgsl/parser_impl_storage_class_test.cc b/src/reader/wgsl/parser_impl_storage_class_test.cc
index 8a827ef..c2de306 100644
--- a/src/reader/wgsl/parser_impl_storage_class_test.cc
+++ b/src/reader/wgsl/parser_impl_storage_class_test.cc

@@ -34,7 +34,7 @@
 class StorageClassTest : public testing::TestWithParam<StorageClassData> {
  public:
   StorageClassTest() = default;
-  ~StorageClassTest() = default;
+  ~StorageClassTest() override = default;
 
   void SetUp() override { ctx_.Reset(); }
 

diff --git a/src/reader/wgsl/parser_impl_struct_decoration_test.cc b/src/reader/wgsl/parser_impl_struct_decoration_test.cc
index 518ac0b..8c5f27e 100644
--- a/src/reader/wgsl/parser_impl_struct_decoration_test.cc
+++ b/src/reader/wgsl/parser_impl_struct_decoration_test.cc

@@ -35,7 +35,7 @@
     : public testing::TestWithParam<StructDecorationData> {
  public:
   StructDecorationTest() = default;
-  ~StructDecorationTest() = default;
+  ~StructDecorationTest() override = default;
 
   void SetUp() override { ctx_.Reset(); }
 

diff --git a/src/reader/wgsl/parser_impl_type_decl_test.cc b/src/reader/wgsl/parser_impl_type_decl_test.cc
index 8399b2b..1d08341 100644
--- a/src/reader/wgsl/parser_impl_type_decl_test.cc
+++ b/src/reader/wgsl/parser_impl_type_decl_test.cc

@@ -123,7 +123,7 @@
 class VecTest : public testing::TestWithParam<VecData> {
  public:
   VecTest() = default;
-  ~VecTest() = default;
+  ~VecTest() override = default;
 
   void SetUp() override { ctx_.Reset(); }
 
@@ -157,7 +157,7 @@
 class VecMissingGreaterThanTest : public testing::TestWithParam<VecData> {
  public:
   VecMissingGreaterThanTest() = default;
-  ~VecMissingGreaterThanTest() = default;
+  ~VecMissingGreaterThanTest() override = default;
 
   void SetUp() override { ctx_.Reset(); }
 
@@ -190,7 +190,7 @@
 class VecMissingLessThanTest : public testing::TestWithParam<VecData> {
  public:
   VecMissingLessThanTest() = default;
-  ~VecMissingLessThanTest() = default;
+  ~VecMissingLessThanTest() override = default;
 
   void SetUp() override { ctx_.Reset(); }
 
@@ -223,7 +223,7 @@
 class VecBadType : public testing::TestWithParam<VecData> {
  public:
   VecBadType() = default;
-  ~VecBadType() = default;
+  ~VecBadType() override = default;
 
   void SetUp() override { ctx_.Reset(); }
 
@@ -256,7 +256,7 @@
 class VecMissingType : public testing::TestWithParam<VecData> {
  public:
   VecMissingType() = default;
-  ~VecMissingType() = default;
+  ~VecMissingType() override = default;
 
   void SetUp() override { ctx_.Reset(); }
 
@@ -471,7 +471,7 @@
 class MatrixTest : public testing::TestWithParam<MatrixData> {
  public:
   MatrixTest() = default;
-  ~MatrixTest() = default;
+  ~MatrixTest() override = default;
 
   void SetUp() override { ctx_.Reset(); }
 
@@ -513,7 +513,7 @@
 class MatrixMissingGreaterThanTest : public testing::TestWithParam<MatrixData> {
  public:
   MatrixMissingGreaterThanTest() = default;
-  ~MatrixMissingGreaterThanTest() = default;
+  ~MatrixMissingGreaterThanTest() override = default;
 
   void SetUp() override { ctx_.Reset(); }
 
@@ -551,7 +551,7 @@
 class MatrixMissingLessThanTest : public testing::TestWithParam<MatrixData> {
  public:
   MatrixMissingLessThanTest() = default;
-  ~MatrixMissingLessThanTest() = default;
+  ~MatrixMissingLessThanTest() override = default;
 
   void SetUp() override { ctx_.Reset(); }
 
@@ -589,7 +589,7 @@
 class MatrixBadType : public testing::TestWithParam<MatrixData> {
  public:
   MatrixBadType() = default;
-  ~MatrixBadType() = default;
+  ~MatrixBadType() override = default;
 
   void SetUp() override { ctx_.Reset(); }
 
@@ -627,7 +627,7 @@
 class MatrixMissingType : public testing::TestWithParam<MatrixData> {
  public:
   MatrixMissingType() = default;
-  ~MatrixMissingType() = default;
+  ~MatrixMissingType() override = default;
 
   void SetUp() override { ctx_.Reset(); }
 

diff --git a/src/reader/wgsl/parser_impl_variable_storage_decoration_test.cc b/src/reader/wgsl/parser_impl_variable_storage_decoration_test.cc
index a15d211..112df1c 100644
--- a/src/reader/wgsl/parser_impl_variable_storage_decoration_test.cc
+++ b/src/reader/wgsl/parser_impl_variable_storage_decoration_test.cc

@@ -34,7 +34,7 @@
 class VariableStorageTest : public testing::TestWithParam<VariableStorageData> {
  public:
   VariableStorageTest() = default;
-  ~VariableStorageTest() = default;
+  ~VariableStorageTest() override = default;
 
   void SetUp() override { ctx_.Reset(); }