commit 4d32be4f1b3b14640fb9fafd781ddb1f1107d660
author Ryan Harrison <rharrison@chromium.org> Thu Apr 09 18:52:06 2020 +0000
committer dan sinclair <dsinclair@google.com> Thu Apr 09 18:52:06 2020 +0000
tree 2883992a6453a29b2d5e938c8d0368471e57ae6a
parent 1234633b32b01f22d42ca516e415e7d7515168d6

Remove suppressing [chromium-style] errors

Lots of little style nits needed to be fixed for this work.

BUG=tint:44

Change-Id: Ibb45d9e3f6795ee0c09f5eca994bb28e20979d97
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/19221
Reviewed-by: dan sinclair <dsinclair@google.com>

src/ast/binary_expression.h

diff --git a/src/ast/binary_expression.h b/src/ast/binary_expression.h
index 0af2b6e..00fdf66 100644
--- a/src/ast/binary_expression.h
+++ b/src/ast/binary_expression.h
@@ -70,7 +70,7 @@
                    std::unique_ptr<Expression> lhs,
                    std::unique_ptr<Expression> rhs);
   /// Move constructor
-  BinaryExpression(BinaryExpression&&) = default;
+  BinaryExpression(BinaryExpression&&);
   ~BinaryExpression() override;
 
   /// Sets the binary op type
@@ -131,7 +131,7 @@
   Expression* rhs() const { return rhs_.get(); }
 
   /// @returns true if this is a op expression
-  bool IsBinary() const override { return true; }
+  bool IsBinary() const override;
 
   /// @returns true if the node is valid
   bool IsValid() const override;