commit 6eda12a55dea3f34d2938ba4493e9f6d0fcb3c96
author James Price <jrprice@google.com> Mon Mar 15 17:35:02 2021 +0000
committer Commit Bot service account <commit-bot@chromium.org> Mon Mar 15 17:35:02 2021 +0000
tree 435b87d5f22097283b44715761bd9823df91c40c
parent a089a56c7389dc024f214c199514f5740e41860c

[wgsl-writer] Use EmitDecorations() for function parameters

Removes some duplicated code.

Change-Id: I05120e5f443810e54babb842f0f993e4e0a7da79
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44603
Commit-Queue: James Price <jrprice@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

src/writer/wgsl/generator_impl.cc

diff --git a/src/writer/wgsl/generator_impl.cc b/src/writer/wgsl/generator_impl.cc
index 273f934..814dbf2 100644
--- a/src/writer/wgsl/generator_impl.cc
+++ b/src/writer/wgsl/generator_impl.cc
@@ -309,15 +309,11 @@
     }
     first = false;
 
-    for (auto* deco : v->decorations()) {
-      out_ << "[[";
-      if (auto* builtin = deco->As<ast::BuiltinDecoration>()) {
-        out_ << "builtin(" << builtin->value() << ")";
+    if (!v->decorations().empty()) {
+      if (!EmitDecorations(v->decorations())) {
+        return false;
       }
-      if (auto* location = deco->As<ast::LocationDecoration>()) {
-        out_ << "location(" << location->value() << ")";
-      }
-      out_ << "]] ";
+      out_ << " ";
     }
 
     out_ << program_->Symbols().NameFor(v->symbol()) << " : ";