)]}'
{
  "commit": "70f80bb13d80344974898646c8c1ae04a834aee5",
  "tree": "f556f077554899ed36b9b51b7d40358195f19005",
  "parents": [
    "40ac15f157b707ff4b942f90324724275ac983c4"
  ],
  "author": {
    "name": "James Price",
    "email": "jrprice@google.com",
    "time": "Wed May 19 13:40:08 2021 +0000"
  },
  "committer": {
    "name": "Commit Bot service account",
    "email": "commit-bot@chromium.org",
    "time": "Wed May 19 13:40:08 2021 +0000"
  },
  "message": "ast: Support non-literal workgroup_size parameters\n\nChange the type of the values in an ast::WorkgroupDecoration to be\nast::Expression nodes, so that they can represent both\nast::ScalarExpression (literal) and ast::IdentifierExpression\n(module-scope constant).\n\nThe Resolver processes these nodes to produce a uint32_t for the\ndefault value on each dimension, and captures a reference to the\nmodule-scope constant if it is overridable (which will soon be used by\nthe inspector and backends).\n\nThe WGSL parser now uses `primary_expression` to parse arguments to\nworkgroup_size.\n\nAlso added some WorkgroupSize() helpers to ProgramBuilder.\n\nBug: tint:713\nChange-Id: I44b7b0021b925c84f25f65e26dc7da6b19ede508\nReviewed-on: https://dawn-review.googlesource.com/c/tint/+/51262\nCommit-Queue: James Price \u003cjrprice@google.com\u003e\nAuto-Submit: James Price \u003cjrprice@google.com\u003e\nReviewed-by: Ben Clayton \u003cbclayton@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "44ba686b7eb9288cc0f97ae2a5d462eeb12b6249",
      "old_mode": 33188,
      "old_path": "src/ast/function_test.cc",
      "new_id": "a634e6fab878e8c3c98ce6ad66b877bba07030ac",
      "new_mode": 33188,
      "new_path": "src/ast/function_test.cc"
    },
    {
      "type": "modify",
      "old_id": "1b5c7ef411c68b7d5c9a037ff2fad7f106f11eaa",
      "old_mode": 33188,
      "old_path": "src/ast/int_literal.h",
      "new_id": "4a12ef6ef33acb123905a2bcaf286b45817500c0",
      "new_mode": 33188,
      "new_path": "src/ast/int_literal.h"
    },
    {
      "type": "modify",
      "old_id": "ba7d3ff392f844c67d0b4c894c8b8f7eb81253ef",
      "old_mode": 33188,
      "old_path": "src/ast/workgroup_decoration.cc",
      "new_id": "36a0d40d5f23f4faf6d6ab72e06de6c76761af54",
      "new_mode": 33188,
      "new_path": "src/ast/workgroup_decoration.cc"
    },
    {
      "type": "modify",
      "old_id": "583816852790791b6ef678dfe504e937c5b071bb",
      "old_mode": 33188,
      "old_path": "src/ast/workgroup_decoration.h",
      "new_id": "fa68e876a6e276b462d11afe0d7bc72b3de0fe12",
      "new_mode": 33188,
      "new_path": "src/ast/workgroup_decoration.h"
    },
    {
      "type": "modify",
      "old_id": "c5c697fb4f626c06256c8eb0b32dc2009aea3448",
      "old_mode": 33188,
      "old_path": "src/ast/workgroup_decoration_test.cc",
      "new_id": "1f0756db325903366ebc116dcbdc41c0217b5858",
      "new_mode": 33188,
      "new_path": "src/ast/workgroup_decoration_test.cc"
    },
    {
      "type": "modify",
      "old_id": "2c5f01f0380bd45875c7bde091cd689bccd775ac",
      "old_mode": 33188,
      "old_path": "src/inspector/inspector_test.cc",
      "new_id": "62d95a7f2f46957c823f0a93687a6f6073ffa55f",
      "new_mode": 33188,
      "new_path": "src/inspector/inspector_test.cc"
    },
    {
      "type": "modify",
      "old_id": "610f1eb72e1115c9a4787fcaffa9a437158031f1",
      "old_mode": 33188,
      "old_path": "src/program_builder.h",
      "new_id": "05acee43594b4453ae2edd4d8d3862ab771575f3",
      "new_mode": 33188,
      "new_path": "src/program_builder.h"
    },
    {
      "type": "modify",
      "old_id": "93980349710e31f8a003491e2609b0bb68ed4b6c",
      "old_mode": 33188,
      "old_path": "src/reader/wgsl/parser_impl.cc",
      "new_id": "8c91da6d8c200dde449b9310c09c2f9a483f2fa8",
      "new_mode": 33188,
      "new_path": "src/reader/wgsl/parser_impl.cc"
    },
    {
      "type": "modify",
      "old_id": "c9c7c833d06c45e611a2af491aa378d0d3eef818",
      "old_mode": 33188,
      "old_path": "src/reader/wgsl/parser_impl_error_msg_test.cc",
      "new_id": "ba54f604a50dfcdee66c32f46e935b17a08d52b8",
      "new_mode": 33188,
      "new_path": "src/reader/wgsl/parser_impl_error_msg_test.cc"
    },
    {
      "type": "modify",
      "old_id": "3144df3baf9b08946b5708b5d07f62b69fac1553",
      "old_mode": 33188,
      "old_path": "src/reader/wgsl/parser_impl_function_decl_test.cc",
      "new_id": "f08db28e651266fa4eefecf3f6e34ec73c33b1bc",
      "new_mode": 33188,
      "new_path": "src/reader/wgsl/parser_impl_function_decl_test.cc"
    },
    {
      "type": "modify",
      "old_id": "c2272c410f8e79563acdf2e0a29ba5a8179007fd",
      "old_mode": 33188,
      "old_path": "src/reader/wgsl/parser_impl_function_decoration_list_test.cc",
      "new_id": "0b76ef2ab2b1953ebe50368fef76e36b864479c8",
      "new_mode": 33188,
      "new_path": "src/reader/wgsl/parser_impl_function_decoration_list_test.cc"
    },
    {
      "type": "modify",
      "old_id": "dc9fd1f1dce85106bc4ccc12240071d494f58398",
      "old_mode": 33188,
      "old_path": "src/reader/wgsl/parser_impl_function_decoration_test.cc",
      "new_id": "432f99e7fd994e81275ce3d562a96c47c8c8f758",
      "new_mode": 33188,
      "new_path": "src/reader/wgsl/parser_impl_function_decoration_test.cc"
    },
    {
      "type": "modify",
      "old_id": "aac478453eb04240a251051562ed0922a34dace9",
      "old_mode": 33188,
      "old_path": "src/resolver/decoration_validation_test.cc",
      "new_id": "15f8f7e0948aeaf4cfb9bb86e87e5322f66217f5",
      "new_mode": 33188,
      "new_path": "src/resolver/decoration_validation_test.cc"
    },
    {
      "type": "modify",
      "old_id": "423270b54c23e66447601e822743fb9ba66d0410",
      "old_mode": 33188,
      "old_path": "src/resolver/function_validation_test.cc",
      "new_id": "a542b9d13b284c490db3c5c575eb040f67267336",
      "new_mode": 33188,
      "new_path": "src/resolver/function_validation_test.cc"
    },
    {
      "type": "modify",
      "old_id": "93266aa193509d7a156b57fce6e82df9eb4c08b3",
      "old_mode": 33188,
      "old_path": "src/resolver/resolver.cc",
      "new_id": "227331bd20a63b4dc5b0de8d75c0007e754d3aff",
      "new_mode": 33188,
      "new_path": "src/resolver/resolver.cc"
    },
    {
      "type": "modify",
      "old_id": "ad428a8ef5a1417f599a93dab4e117a9b24f5dd0",
      "old_mode": 33188,
      "old_path": "src/resolver/resolver.h",
      "new_id": "8a622d2786f5d0c2d111e873accc6b0e1be473dd",
      "new_mode": 33188,
      "new_path": "src/resolver/resolver.h"
    },
    {
      "type": "modify",
      "old_id": "109b31a279385d09dbc6a3bf419a6f71c1853e8f",
      "old_mode": 33188,
      "old_path": "src/resolver/resolver_test.cc",
      "new_id": "41e15e29f5bd6ca79aa4f5607ba95f4d43c9bdd0",
      "new_mode": 33188,
      "new_path": "src/resolver/resolver_test.cc"
    },
    {
      "type": "modify",
      "old_id": "68f55c7257f189ace8f4470567123da6bbde361b",
      "old_mode": 33188,
      "old_path": "src/writer/hlsl/generator_impl_function_test.cc",
      "new_id": "502b60df928193c5d2ead8d0e3c74affc0e565f8",
      "new_mode": 33188,
      "new_path": "src/writer/hlsl/generator_impl_function_test.cc"
    },
    {
      "type": "modify",
      "old_id": "c3949262c31b85253eb12a2bd2c1325c4d800340",
      "old_mode": 33188,
      "old_path": "src/writer/spirv/builder_function_decoration_test.cc",
      "new_id": "91bc0050fb4080ec8f7418b793da137ca82e4acf",
      "new_mode": 33188,
      "new_path": "src/writer/spirv/builder_function_decoration_test.cc"
    },
    {
      "type": "modify",
      "old_id": "45a77b83a2fa4d84032fc7903c0daa64e4e18c8d",
      "old_mode": 33188,
      "old_path": "src/writer/wgsl/generator_impl.cc",
      "new_id": "ef96c538f22c132c20be1ebaa7d232cd2f864de3",
      "new_mode": 33188,
      "new_path": "src/writer/wgsl/generator_impl.cc"
    },
    {
      "type": "modify",
      "old_id": "fc69ccf57acf1fc145ae0c2e5b5c758f8630d1c0",
      "old_mode": 33188,
      "old_path": "src/writer/wgsl/generator_impl_function_test.cc",
      "new_id": "0e19f5a4ababa3762b97f666115140eb887f2379",
      "new_mode": 33188,
      "new_path": "src/writer/wgsl/generator_impl_function_test.cc"
    },
    {
      "type": "modify",
      "old_id": "d8a4c355dc3f3f38ccf6ce84f30a65f99e87fb78",
      "old_mode": 33188,
      "old_path": "test/samples/function.wgsl.expected.wgsl",
      "new_id": "4cd4fb6a8f43b018489dbce44f02a75a1d6e3233",
      "new_mode": 33188,
      "new_path": "test/samples/function.wgsl.expected.wgsl"
    }
  ]
}